From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9721BCF6493 for ; Sat, 28 Sep 2024 14:15:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E72E86B0208; Sat, 28 Sep 2024 10:15:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E22EF6B0209; Sat, 28 Sep 2024 10:15:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEA4F6B020A; Sat, 28 Sep 2024 10:15:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B283A6B0208 for ; Sat, 28 Sep 2024 10:15:23 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 54CF81C4F6A for ; Sat, 28 Sep 2024 14:15:23 +0000 (UTC) X-FDA: 82614344526.18.3500A83 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf23.hostedemail.com (Postfix) with ESMTP id 19AEF140009 for ; Sat, 28 Sep 2024 14:15:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="fCZtH/oM"; spf=pass (imf23.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.44 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727532883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1n1yhYZ2jePqstMxv83IrNQpWfd5taqozmZvKKkqosE=; b=wWdCD5Cr7/w1Bs+SMLoViWo/BCnxCxYvKZjQmnUcdXrDkCA2HXVhquyiBWvMhS9RB0rcjv uZaMq9iDvFVFahnyCgL4VXbnUPjBk7s9eZPor9QlFeS/tKYscxCGe1tySKhlQBn311vUuN t7YZnj5VbUpq3FoRYKq+qR+4bq1PQco= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="fCZtH/oM"; spf=pass (imf23.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.44 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727532883; a=rsa-sha256; cv=none; b=m7E3PdOkJM5hZ++xfvocALWAX8kJV59U+mh2+MgN+JvdhKmj2Yvzz7cXkvf+fwKAWbHhc4 VfGWqBnBClo8IkmDWNRN1dfRC/G9bAvs9b/RPQ9lIUd33r4GnI/1rkwBfOJEKvSul732wN cfJjgbVd7z2JRFXJnzmkhdj668XtbV4= Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-6cb3d2ce75eso15572436d6.0 for ; Sat, 28 Sep 2024 07:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1727532920; x=1728137720; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=1n1yhYZ2jePqstMxv83IrNQpWfd5taqozmZvKKkqosE=; b=fCZtH/oMgoY9z0livSPer0+SR5tbhabPglKP35YElC7cPDjHYH/RRoQWa/2B8EnfgF Lg6i2mcbLOIHja7P+yBwmOVuRUrEB+rAf7IrNZaO9XXLj69twEe5gsmk+vytzI1fRrQP aEpWEbc9PEQyKLlYZ3KTSa4jKKuk/ab36vtdOsxqEZOfRgF6GrDsnt5FjC7CjtvVngFS qpL+Dw5dx4qIcihd9U5sH6DwRwwRTGeT6KXd3cIcMKO0hEuL506AUNQvQIXwrx0QSZaq Q9ZmJZ8Y8h7Yi3wK9BUYr4sAMeTRyOBTFqpvQ1ZZmjXP4s16s/Qq/iOF9i8AB0pr8llY 53MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727532920; x=1728137720; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1n1yhYZ2jePqstMxv83IrNQpWfd5taqozmZvKKkqosE=; b=awY6pg44s7wtVn+HQmqSnW5Wh3LeZ5QWW443U4iY5T5B9SuoCARRrXnJKq7XgjQXvx Ge/ro+2dVJHtHMhLd0++x2tVTBrNCAsg3lNaRjJXzyRR7+AfHHPxdSh1GgQ1wlu21Qbo HGrMYm63jDTITKqRX9PExr4pKmcrapB3+Mrd6IbhgBLOekiq7qi9VTohmESQ21wldvrp S59bmv+lm5WymcPnyPuyx6I5esYCSGZ3CoFbdHG45wvOiT3hL0fwQvuXiwGlckocftFD ohy4dFl94RX6K4YC4Bs+d6dBU1y7yPdpnid3xtkkQ18sWb4ps/JaP3fkyC7CXa7XpRu+ 5KSw== X-Forwarded-Encrypted: i=1; AJvYcCVHMNm/2l15SxEmp63h0bQvke+/NBW7Uu/fMMCMAv6rrVu5/hvuzaPup/j52+ZJkpCSqZzm/rOLRw==@kvack.org X-Gm-Message-State: AOJu0Yx8LJXdypzmxNHdE6/ERQ91Q/FGqIOOSJv5JgsZskswYf7QSvPA gtLtzzV5D2WOuxmoJHh4qvE8q5oqrtAIte892qqK0BE8Ol2sX24Y5nA3AigMXSC7tPyd3HA5knH 2 X-Google-Smtp-Source: AGHT+IHd3wDhlYhXVZ+88k2ZjgoreOFUU3e+oUfQyAaHR5koWFTiMsugOsIxve2cJUf4gyU3Uemsbw== X-Received: by 2002:a05:6214:4b11:b0:6c3:5c75:d2b1 with SMTP id 6a1803df08f44-6cb3b32d1ebmr109084796d6.5.1727532919982; Sat, 28 Sep 2024 07:15:19 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb3b60fbf0sm19761396d6.37.2024.09.28.07.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Sep 2024 07:15:18 -0700 (PDT) Date: Sat, 28 Sep 2024 10:15:14 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Kanchana P Sridhar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [PATCH v8 6/8] mm: zswap: Support large folios in zswap_store(). Message-ID: <20240928141514.GE957841@cmpxchg.org> References: <20240928021620.8369-1-kanchana.p.sridhar@intel.com> <20240928021620.8369-7-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: 36jox56grqicpsdnbjnqxrybtn8ywgro X-Rspamd-Queue-Id: 19AEF140009 X-Rspamd-Server: rspam11 X-HE-Tag: 1727532920-185375 X-HE-Meta: U2FsdGVkX18AsPoV1RCR/6zBkEH30jRgsw+uiEt9I1Me4XlqiCLkM2BeusO1+r+g7woM0Fic9SquiE9ke1tMVrVYSvQduPAVmytKNHq9DTzBqPQKPIN9X9nXXthv4/Fj82P4L+nlHGx/gLi0PlpLS5vbeDoKjItMC2/EyTzJiOcEHXiRwHQIVQ956DHP07LtjrEJl+YOWv+2Ojuer7YlgICf3c9FFqZRumUyEpWCOjM9K0YhdaqZuJtNgezdZs6a1G0h7+D3XNNamW/5F0aWm5foIkyb+3rQAaswoaWpx5DD8RezJ6ciPbe1WnUoVt79jDkYGfZHfUB0jF76EclDeGVbda/zg/1J4bgwzhhwzoYu4v16MNgOPSs3wAcKZsvhZJbJmEu4b+jGh/y5aG8RPYNRhWfZBa3RnQaZdVPCjZEQye2+mrRIukTrkdb/e0vihrtxdhlJ55kRVq3h672b1nD2xHjK4GgZjk7tGvcHikI4LGq+n5thCmDNl8bEqT/MaYJkVdVRdMJ0hQJVu95Ue0smJ9nTzZu0ae73bq6gf+oPRONJ4QjRypg3S2B+TJv8spp3cagUb/Z6myDpJM7Fnh/KFKDhDu2N80hzUnEC5pS2XM74vCmFcjE8Q0AEDILHMYz90ErmR3hHLENr/T91IpqJpy6lG6Jn+q36F40hQezBbKJZOazcc70T6WK9NUyzsvNyeEZ8JpdM4pkzlsnH/ViADZv3zNFDr6XGgj3Sy7EbjX2V4T0ZAJkmfd/pD/zZArAdw91EsIUze0/H8cobgtuO+/uwoZfPf8TseJX5vPQUlTIZeAWOw5lhpziw+HJRN5UuaLJUlKhE8G3iGBXWpicC6MGQ63QHqFjGW17Hz96YwsyZEqxiQ4jxJjmZasrVh8+fUEIIpDSyF6ufWby7StLdBAvInb8pTC86wkbzl12pjCwur41lxtMnzCWW6sFkK3EK+/nCrbVEeT6S8H+ uQnmbLM/ k7bZeMGPCO4umY4mZX6G4Mou88uAR6ceZEc6N2qYvUaLyO2Q3T2aAF4/OeSXInSA7JqFlKMR8nM90GPcl2VXdCsDeiZoWIWEqsJDIX0YD7bdABVIBJef1KIL/fy1m9EvLoGYnYe3mQ7JiR0+WH6g0YFbi/gUj4Cm+taWMlxqh2FNqcLlBNNuDTSYJZb4HrNoOYsznHba2quQZDhEWZz/oXUcbfTFmJb23fXnTcNj1LlYBl6Y8kmOXI3a1ykKZTDrwLteVJ9LcId8QpWqEBXXGMCahhRyKAiw1VYzGdVyZ4qz9KXuMRmAbg3SzMkO7k5pd+LWlQC+6Ul58HWs/fGgCJmCATwk/TdfbUR7rxRRtHcTbMlaixRaow4808prxlSSILSOTRYq5laKf0cp4gznLkV1Xm9sbw4bJ8rRGwiU+sF1lPuuEhOv3GIMfQOkdgotMxsamgNQbeAIHK7D7/0N+H6tGHAzgkGb3NO5Jdz5H51UVa+Jn/oJ0NkLisq5Gu/Z4ri7LGG5tUqPsqyPEuvJ/deyAJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001055, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 27, 2024 at 08:42:16PM -0700, Yosry Ahmed wrote: > On Fri, Sep 27, 2024 at 7:16 PM Kanchana P Sridhar > > { > > + struct page *page = folio_page(folio, index); > > swp_entry_t swp = folio->swap; > > - pgoff_t offset = swp_offset(swp); > > struct xarray *tree = swap_zswap_tree(swp); > > + pgoff_t offset = swp_offset(swp) + index; > > struct zswap_entry *entry, *old; > > - struct obj_cgroup *objcg = NULL; > > - struct mem_cgroup *memcg = NULL; > > - > > - VM_WARN_ON_ONCE(!folio_test_locked(folio)); > > - VM_WARN_ON_ONCE(!folio_test_swapcache(folio)); > > + int type = swp_type(swp); > > Why do we need type? We use it when initializing entry->swpentry to > reconstruct the swp_entry_t we already have. It's not the same entry. folio->swap points to the head entry, this function has to store swap entries with the offsets of each subpage. Given the name of this function, it might be better to actually pass a page pointer to it; do the folio_page() inside zswap_store(). Then do entry->swpentry = page_swap_entry(page); below. > > obj_cgroup_put(objcg); > > - if (zswap_pool_reached_full) > > - queue_work(shrink_wq, &zswap_shrink_work); > > -check_old: > > + return false; > > +} > > + > > +bool zswap_store(struct folio *folio) > > +{ > > + long nr_pages = folio_nr_pages(folio); > > + swp_entry_t swp = folio->swap; > > + struct xarray *tree = swap_zswap_tree(swp); > > + pgoff_t offset = swp_offset(swp); > > + struct obj_cgroup *objcg = NULL; > > + struct mem_cgroup *memcg = NULL; > > + struct zswap_pool *pool; > > + size_t compressed_bytes = 0; > > Why size_t? entry->length is int. In light of Willy's comment, I think size_t is a good idea.