From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A3B6CF6493 for ; Sat, 28 Sep 2024 13:53:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A3786B0109; Sat, 28 Sep 2024 09:53:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 954166B0175; Sat, 28 Sep 2024 09:53:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81B6F6B0171; Sat, 28 Sep 2024 09:53:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 61C336B01FE for ; Sat, 28 Sep 2024 09:53:51 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 12AED1C76E9 for ; Sat, 28 Sep 2024 13:53:51 +0000 (UTC) X-FDA: 82614290262.30.4F137EB Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf18.hostedemail.com (Postfix) with ESMTP id 1890D1C0020 for ; Sat, 28 Sep 2024 13:53:48 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=rDjz8KyS; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf18.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.52 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727531611; a=rsa-sha256; cv=none; b=rbjDJ2SYqVHWFrVyIuYEyXAa0GReZeOXC6tMMOF06AOuw/Af4ceOl4YhIEFC8KF+0l647V XavncxiFaaSzsLMrUnguPt86if1SvdIKu0z/bjh8LODZjMC9u2BPQggpyGf1kEyslBaVSF 6pEeuBPraUollix9taz8b0vyiEnB0eg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=rDjz8KyS; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf18.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.52 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727531611; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dayhq3MTxfga64TVXaDsvojrghHz89xXzeqjJuXzgwk=; b=Gcy04FJYe5HdXrUgPzGCF/ZtDFRrR+a+3vdJG+UKKwCyKIuA/OuBTGevlA9UiHOWg5T/I6 MAuKZBTYawwypDFdJKmke4fUMmdtOYcNn50h9wP+wI+YlrZ+fi4jkGJOr6D1BJAYMqYyzp 6gPOwcCYYq7ffeu0o5zaIraWsRBe2ww= Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6cb37b34a87so18587376d6.0 for ; Sat, 28 Sep 2024 06:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1727531628; x=1728136428; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dayhq3MTxfga64TVXaDsvojrghHz89xXzeqjJuXzgwk=; b=rDjz8KySKxMbUz7JXz5m32IPBPooh7a2sh6SkbWttYbfR59GVe7VBGi8m6u7tRLqYS 44z2ZF5PVXTm/vhfKzZsKn7576u/DNoe9WzDWcGLMPQcdk0gJQw2ZSdmL/Mli7GNzGFp CA0njUIvVWUaG3O66xGrfIdXATfLDCRtFylN3AljNFIjUzEBslC/Jhn7vuFoi+8MN5f5 dUie0HqZ2LUQ+WwvObZz4gy1wbd5tk/SBxBJqqeXI+pxJgrGEk5tYd+TA/07Lz3BP2M9 ODTjRrQAXs997Pm414NNDjlE3tTJkOINivzC/4G87aYAoXp7fWBJxxFQ2c0NPRiGVJi1 GUEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727531628; x=1728136428; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dayhq3MTxfga64TVXaDsvojrghHz89xXzeqjJuXzgwk=; b=vsF+2Cixyhb2vynvsq/VUIxrRD8h9XCfgSMcC2ZzveLtDBYDqxYFEZOafa+KXl4voa itmj3o6tzkxA8j0rfLHlqAH4K6OpgX7AqN5Cg7f/f9VIve4BvOlztVjqc+lBgaWST6l4 vqzn+cqq+1YXEFZyQWotazXxh8TYSRJ15RkUgtfXgXwu09uraZlak38EmCe5A4uToJs0 BhK8gV73R8zZIO/S2fUJn7CuK9VfWLtvXCCFSRv/PuJB/z97LrC9wMUDFO7IpPeX0GT5 6OIKJNufCbJbSYsvSwO5kMdy4f7J8hRUM+SYy2PKGKVAt9dtYhH2wIUbmY/zQPF8tONz 452A== X-Forwarded-Encrypted: i=1; AJvYcCX6grzxW6fXEvyPnD1yTzHN5HYdE8Y2gc93UVBqKhzVOwJyW3RikIwfZwLItc5dpW3fluL+hcT9fg==@kvack.org X-Gm-Message-State: AOJu0YyJBWKvRqm8rjiAsKHNRIV0+zQdi14YPso7sLAlf3bkmUVxZqmb Dt9wr2zps0Bc9+Bo7G4vzZnIHVCfiFpAxcySikAoD7Ok3s1ZfCH7kfjAv+kuStM= X-Google-Smtp-Source: AGHT+IEj8ecZQlUVp6W/h+37oUBnpND2E6jQoQDicgs2joAcvMOP+ThVv/U8AlLrIsjEWgOlvkuL5A== X-Received: by 2002:a05:6214:4884:b0:6c5:b883:92c6 with SMTP id 6a1803df08f44-6cb3b5da9eamr82694856d6.12.1727531628043; Sat, 28 Sep 2024 06:53:48 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb3b5ff612sm19534126d6.9.2024.09.28.06.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Sep 2024 06:53:46 -0700 (PDT) Date: Sat, 28 Sep 2024 09:53:46 -0400 From: Johannes Weiner To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [PATCH v8 5/8] mm: zswap: Modify zswap_stored_pages to be atomic_long_t. Message-ID: <20240928135346.GD957841@cmpxchg.org> References: <20240928021620.8369-1-kanchana.p.sridhar@intel.com> <20240928021620.8369-6-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240928021620.8369-6-kanchana.p.sridhar@intel.com> X-Rspam-User: X-Stat-Signature: y7xwnrhgd6bsu847g4b8a9sfqimrj5c3 X-Rspamd-Queue-Id: 1890D1C0020 X-Rspamd-Server: rspam02 X-HE-Tag: 1727531628-42636 X-HE-Meta: U2FsdGVkX1+1ofRbBc89fGpXVDR6i5L58Bjb4Y+kK25NXGoxZbGorJrOz3DeKr2j+blVC/ebLOOudk+0cHXMyJLtmfQo4GtYmCijGWICmFCE8crN0Cdj/avBVcMhEoqWBKg8mVH6JzRBO+OGP2cXvcTxnwh1eUP70192MCpGG4mnjKK8uylsIIZIXx+FoJayjCItNbOkPDwBtYpOgrFMjDHEWAaC98hw+foSfdSZb6MksMOgBZnUN/6QoUVzfIgDYu6HMsbomxlWC4zI1Xu8ayFjjTtR5GNhuu2QOUNRqSnBH/G1pf70V5fcsBBTqDIM8NIrXJ/QXJB3w2gEp8qmX7rZxDOwGHXOxistEn+7Qr7Q9+L4q/Pi1WHWDWYfB1Qe08t4CLnfN97lVQ2oz9ozzTJ9GNY/JXJw7dsznFF26zJSO4JCD9IYe5CjgZsnS09t7uXd964NeT4qLdWpo4i0CuNlU34Z6BhJayFwEGoKTRFB1wvsSh+IMf0tSQbKE1JFTYSScRn2CltBaBhbsZYo+qeEhUc3SD38rWIe3Uk9/nYuJrvGxQaI2gtxuiBruqDFJiiYRyEqq9hb7s2Xwsvn9cbZJaOfBcmtFDjQFzJ9rjFXzlb4Z3Igy+p53zbJzbZIEPOMLVNYDjhzDOH5wYSDOt99dWcOsBhx7zDtZC+FTFESle4nJPC8h/Fiw1dmiiqaRSbbcC0U1L3b3L83YjZAgPs5qU/VznFoaRqzLytdECYBjFjq0gKTBZB+oCynzauK94Ueq/vPixdtOTQrsyqdT5/v5sTCqtQvXBtr/X4Z5b28dsLVC7TdSNAiSSCBUcoyZnLK1ztZacspZmLdux+Kfr6lRyf0TI/L5jnpNM9KntaQ4VXimcUeidGEPgs9KD7582laRUqVPNndihatOLSXZSVi1y830OO3MLjeRgWtuiQe9QzVOZwNJEGpOWe0J/FfEsXTJwmbijow2+0h6Fi YjYQ85mN zzCzjJYoFTTl1qe6WEFYKUm2BFOMF/6Kpgl/tV+Y3FqZHy570sgOE8+7OudvueeZcGmXG+NrrCnJjP2JlsWBosScxXJpHEncJU7MaT7tABTZm8OaU/ws5Je6OvHzqdZAYekhk3VEuKWYh0t3UDG57n8boqQ0z4Rka+QcQIAgzca1r0ePF2kFeod62xQ+JC6dTRiqFNFblX4Y/bzzMdlOlavINKH+AKT+g0qWPGTmmg5qd4AkM/35uYzPdfHrV5tDNbc2ztNZUiCLBAmH1BKPNJtV+N7pdHW/ok5i3wz8qCcDro/XY9PT6zPHYCtN7uXNqlvB7gaTYG43s+yd5vmtAzJiv4UXGPKwxYw/18jScRaZCrRmlGDKs61TebO40OLOJr8xBeI3vKHwfJEUYtAu4RO6Sux4dKARc7zPqwX/bAGxrm5VXT7xxZ5njeUHARqI8TRdnaBE/tIC+9R3sYhGa9TDGPktTLlnlhw4WTmI0uQ/dTf8D+cw1tUYyX0250ISIccZmaF4/gsGU4Zwu4fe9ahF3SHax4BeMeUShcUrvdHof4b0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 27, 2024 at 07:16:17PM -0700, Kanchana P Sridhar wrote: > For zswap_store() to support large folios, we need to be able to do > a batch update of zswap_stored_pages upon successful store of all pages > in the folio. For this, we need to add folio_nr_pages(), which returns > a long, to zswap_stored_pages. > > Signed-off-by: Kanchana P Sridhar Long for pages makes sense to me even independent of the large folios coming in. An int is just 8TB in 4k (base) pages. Acked-by: Johannes Weiner