From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9390ACF6493 for ; Sat, 28 Sep 2024 13:47:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0276A6B01FB; Sat, 28 Sep 2024 09:47:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F19D96B01FC; Sat, 28 Sep 2024 09:47:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE0D66B01FE; Sat, 28 Sep 2024 09:47:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BFB7B6B01FB for ; Sat, 28 Sep 2024 09:47:41 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 46814812D5 for ; Sat, 28 Sep 2024 13:47:41 +0000 (UTC) X-FDA: 82614274722.28.753471D Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf09.hostedemail.com (Postfix) with ESMTP id 780BE140004 for ; Sat, 28 Sep 2024 13:47:39 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=QnbZt7em; spf=pass (imf09.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.182 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727531222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=khoSGRl71etMO/s0bYkJkYQdhSsFb2b4yNg67LBVG4M=; b=I4gK7vZ2+zlxDo0CRNE5zJGRow9+93fS6r+ibwfnhdbL5eXWbEn7/aQVLF3X6MSrTeyhli JGejTI205Umr3DzQ7vi8wwy63day93GNU6utAU73mhd6ZRFhAPVwjXCTWv5o7XLPN3SiBp iN1FnxVCuo73gWu5ut3WgWuHdH3WUQs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=QnbZt7em; spf=pass (imf09.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.182 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727531222; a=rsa-sha256; cv=none; b=y5fBsluUz9tqsfq3zcZmXJZ6WcavAyAalfdMJHwXV2SSwmCv5FkYy1dZtWecq/mrmBscq8 ngAOmlo1BK2d0No11L9u1a12L+KgcB0d9pFKo34J1gq73DWJ3oB0Zj6/Xk5aHSFMBrQ8Wa k13UYS2Wsq3F+SGbJ7IVJbOCEYRRUfM= Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-45826431d4bso20557431cf.0 for ; Sat, 28 Sep 2024 06:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1727531258; x=1728136058; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=khoSGRl71etMO/s0bYkJkYQdhSsFb2b4yNg67LBVG4M=; b=QnbZt7emgyBSRw31Tejtrdc0aPW3tY/gAEbeOUs+BrRfWiosi9INyBt68z8Rqm0o2C RG8PLVAFYWHzCJSCK9euZc6qCVzUmD/IjSG4KsfkMEeorWWf9uNkZe3320HJMVJo0wni QUB8CxeXbleeq8Q7K2KJfQ3HlS6LYtRaG8JudfNlJoR4pGxhFWfpknsnaMuAzCLEqmTE /jp0ipxz90oAgca75ef9yZqFNOhis0fL7cOqcKOjoYYLoVa9OtHkLT+mQg+qSpc7vf2Z ZFw3X1d2H8Y55vgRj5FNBpU7J4eBOlyWoRNPffWrS7ipEywDxsNseO4DDIht0IeJHfNR +v4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727531258; x=1728136058; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=khoSGRl71etMO/s0bYkJkYQdhSsFb2b4yNg67LBVG4M=; b=pZtyL7Kn7yQYf0UiAhEU103pA4XR0F2YpGd7nLb2SsWYEtF/Ooh7xUBxQ+X1pMpY2y hlcu5M1tr9puXfxCo+JL1nYlra1GEBm1URNwo9rlBeqlviHdba+rmQWd4dpJHWc/CScK WN9a2GbOPFGTtLoR0s3ozqknVaQ+LDqHEe1KjF8ijFQfJRKD56JQuRWna2PXQUAzkSi6 A33DakU7nlRyoVVHuMZcGvzyoEgJd8hb7Ja7abmkb/Zp7vFf7jdmb5mtpqGwMcdlRmip +9JrAVb2myMksJ1OrkEzQb7rWRrtsABTRU2X96DGBZzY2HqwL+d4QACctHh94S1IJPFw 1Low== X-Forwarded-Encrypted: i=1; AJvYcCXDx320r8lzoqhBApC6j/SjgaecMMJnTf4ob41lFqB3BnN/3qEBBYsXi/YBh2ENuYX9s2Xd+DVP+Q==@kvack.org X-Gm-Message-State: AOJu0Yw0Vt2aoFxPXF4SzC30y6IyoPVEnVsqzTqilDJSS51LbkNfe3f8 0ZL3k+GnwaDpiqUGaH/ZHRQfXEJZ/lPsuKlczcDp09A3Alb9rM/On5v3tm7NutM= X-Google-Smtp-Source: AGHT+IG5cur4H7TXPCsaGrTV+Sv7uoqUUEnXnL5/Eewd6Rp/ABFkY9N4sX0YnP955vwj69c9o3rXvg== X-Received: by 2002:ac8:7f07:0:b0:457:c74a:6384 with SMTP id d75a77b69052e-45c9f1e8b5fmr107843991cf.20.1727531258594; Sat, 28 Sep 2024 06:47:38 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45c9f33b809sm17586391cf.65.2024.09.28.06.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Sep 2024 06:47:37 -0700 (PDT) Date: Sat, 28 Sep 2024 09:47:36 -0400 From: Johannes Weiner To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [PATCH v8 3/8] mm: zswap: Rename zswap_pool_get() to zswap_pool_tryget(). Message-ID: <20240928134736.GC957841@cmpxchg.org> References: <20240928021620.8369-1-kanchana.p.sridhar@intel.com> <20240928021620.8369-4-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240928021620.8369-4-kanchana.p.sridhar@intel.com> X-Rspam-User: X-Stat-Signature: agxqrgbju8azkmmthghn3h87bwga8hzi X-Rspamd-Queue-Id: 780BE140004 X-Rspamd-Server: rspam11 X-HE-Tag: 1727531259-788301 X-HE-Meta: U2FsdGVkX1/FKPeJioP0VR7e4j7GgPLsxKgeopzh72bCuJUgBKG/i4CgKH/VHKFHby188R7HlxNEhhieKw87j1IBj5BMRN6SvMOuNIdnifIBcH7N76S/BVTGWPyLABUlisKlWBGsJ/AFJG25Kk0j+vNwPljuHQdJ6kJLI88+ENdPb4SrNcAhIezzRE96Xi915kCOy0j9HkReO/o0bLKYXEPauKdO+3ST4eIgsqypv3tnd2+N8Yhp9Noqmkt3wIpLLed8Oh80B2FZIKEuuaXJC/8i/sYNCYn0C2tiQoIUZjVBK+Iyed+G3R+qnpKLT1yMWUhHs1uXBIK93wVosjQwJ9nTgxoXE1mD+Fu0MIp4MZjnB0bvVEbo6JO3REYkRaOHsMokiDuxgyngpsZmwSIF58/BV/0SNqw/2e5fFt4lTnK3oFOCpONA8aGjfp83I0O5ypWflF1QAbb4ndS6IPjnhmCvOD4pcVlV2tQse4QJGXA850MZGO3PJLMPfJOpASU9cHRiksTu7VBhUww/N6x4xoyCeSoAwTgFmgnrFzT3rVhkZi+XGOfD8g9VyA/IHM+qFZ191T0/gNC3+25OH8YDAzXcma8XXcWeJZNRgma7pFr14hGedxy5QtTTzm0WxR6543VIYnCzkf9nd/9lPiwAIWN680FbtxLSRlpgu27nQAFx14MeV7TRHF2v+lr43CNAwNMydudCcBERpk/qt/Lwp8a/zzcFa+Q0Z4UWpZbeqWjKBdQLYVmayCa3akNdi6O9DMHf0Ks3zZdh39V8N1ijXcSWq5ibf0jT1vE0Ft+Ywcrxmi1JttEmPBofIS4X6ZcDT23foyznm3aj4RYVOp+4xOUaigGx3nL2DwhtouzUACX33JR+7c7cebblxMqAVUl8KpiBKrLOafBI+cB1+TQ3GgByr2EHMcy7qm4/utSbQOocqG5S9SYMUlZ9cMst3XDtlyELtmhIwTD/hkUcBPF JPnT/UwC SR2u2jVeRuGCauNvsibsSLGGmg+Iw9P6u1HfFTgNPco8gCvAx9pM0Ki88NbnvW373heqZNFM9gigX6ipfcgVWPykRuqetCrmF0vSQ9AqNoyP0d0N5OPva7bQCvLbk/10fQCjYH4f0B28lwHf7AtlocBv9snfnYtO03C360eBmXSUGUmHrSDnDcbkRQL4c2AoO1unS1Xy5wcDw8cGafB9yD96DnaVanGQDxO408aiV7G4STcMmgOgwnHcO8Ye8QeO3PHqmeMF8z8zjA5SzUkQ8pOJBIi1EsGe1/vFvpA35Q1JQApfBT4+5ZpcvuyFq1l4T8s0Ys8eYVejyZ/LKLqREyLdITCFrb7SzmNgo4J7Ps3Vh45ZTPtiRDgc7UgnOCexaUA6skMR07D2RNCnkQN2mnbR/qZ1JwC8PLPorT73xw/UUexBtxeyqcYFYAUZQe+d4kYXXUuOvOFt8pzMlvRB8JvOi5y0+X5qtzj70VGP06bvXulWAGIWKNIY5jNV0Rlh7rbq1TijY2/nC2atEPsPQLFbrIkEVlIyIICkuO6fsPCnd2TE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 27, 2024 at 07:16:15PM -0700, Kanchana P Sridhar wrote: > Modify the name of the existing zswap_pool_get() to zswap_pool_tryget() > to be representative of the call it makes to percpu_ref_tryget(). > A subsequent patch will introduce a new zswap_pool_get() that calls > percpu_ref_get(). > > The intent behind this change is for higher level zswap API such as > zswap_store() to call zswap_pool_tryget() to check upfront if the pool's > refcount is "0" (which means it could be getting destroyed) and to handle > this as an error condition. zswap_store() would proceed only if > zswap_pool_tryget() returns success, and any additional pool refcounts that > need to be obtained for compressing sub-pages in a large folio could simply > call zswap_pool_get(). > > Signed-off-by: Kanchana P Sridhar Acked-by: Johannes Weiner