From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 144DDCF6493 for ; Sat, 28 Sep 2024 13:46:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EEA36B01F7; Sat, 28 Sep 2024 09:46:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79ECE6B01F8; Sat, 28 Sep 2024 09:46:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6662B6B01F9; Sat, 28 Sep 2024 09:46:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 499256B01F7 for ; Sat, 28 Sep 2024 09:46:27 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 00C22419DB for ; Sat, 28 Sep 2024 13:46:26 +0000 (UTC) X-FDA: 82614271614.17.964ED0D Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf17.hostedemail.com (Postfix) with ESMTP id B670040005 for ; Sat, 28 Sep 2024 13:46:24 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=P40DYlMK; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.49 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727531122; a=rsa-sha256; cv=none; b=TSIw05uIjXnWoKAiIjqWXZ3xPijLWF85/ok14hXcGxeu8v6A/3t4yoMnU473jcUs5Q0luu /10ERbQBiJdND4SAEDp3xY8k+MbVuVSpbfW3fiEH0GWPm/3w5YM1JdpROd/pD90hdA364F xaTsEJsRktQ5UEWFL5iCbN9dRHG4YjE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=P40DYlMK; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.49 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727531122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1sN4zfuTrVKtE2y+7jsLqat92Xu1bOSH8FKZo9LAfzk=; b=Ep1EaZhk21AcIHGxO42reqkm6lxlbfADxB10JjKBf4JypUDePdYqsMIvFBnF7qb9eGOrF+ 7P9HwYu4uP1AJ2QWBsPAL+Ow+LvpttzXBDx0N5KlCRKotl1V0LbUeZP6cNCkgQqJrAeqmT iuklTxXQlCuRfCiph8WmM+8S0sx6njk= Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6cb4f1137a8so3705636d6.2 for ; Sat, 28 Sep 2024 06:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1727531184; x=1728135984; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1sN4zfuTrVKtE2y+7jsLqat92Xu1bOSH8FKZo9LAfzk=; b=P40DYlMKfyEOGrGiM6OZ/ZylFuM5Yj8Dt+Ip7VPF2sPk2tWx1rV2MAs1TbjcLoANql AQAdvReTXehTFN2xQs47bdPrStjAvDNlDdDiJ/GPoeQGzawxmCqCLnwAM9aHzWdc4c5h Hai3pRgmgoFCATsSIpMmfr2z0zLT7yBPOLHmz1P606xfP4s3V7yPhB/Ajjjrryr7S09h 5YJ47RgrVYBtJBVUTj9H5gFvcLtbGc1rt3XT+5YtU6Em2nUmlPP1NlB+wQWHDkvtQo6f +23htH4HE2W+hiYP3qI4vLg6W3Gja2FiIgrsPEf+VqtlHq1jOpXtMRGLGJ1SupJpEkAh dFcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727531184; x=1728135984; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1sN4zfuTrVKtE2y+7jsLqat92Xu1bOSH8FKZo9LAfzk=; b=K9JhykqoxIlcV/ylFT61du6GezgHB9J1NZH0RZMV5MkoLeWEHyPbRbePlHR9OU7nv2 Gdk/ovYlCe0WGWvP9ixmbkEb/3Yts2aqIgvTJfAfZlKlqu7Epjz3dUWV1QPngUxRKD/P 6dRmC2sT3Wu1Ms3qjRoZEBcD94tIF2Ot2d/m2j3hlMZzillumxOOhwSbSQrSHaBQWUPK KrUBCloux0tFjYGFiHvgg6+ES8YZ7ESYNt7ROq1ApxWL2hx9tDXHmvqR++OqIYwXHoiB La3QnZ2jzEtpBsndcubBkg95rxJVjceuQ+pxqfiyXe18W17aFVDbUeEWLPEmZWqRuRa3 9tEQ== X-Forwarded-Encrypted: i=1; AJvYcCXn1wVuxeAQzfOs3tDXWYLj3+sPWmHmigUovx5nwhNF0dcRS4vJ3uAcrM96Oi96bF4aUIUCeiSuow==@kvack.org X-Gm-Message-State: AOJu0YwSwTgCMUp+Vu3mqzs0Z7WeGeTUM1RlOO0Ot1mDCjx4dnfwb1qo noADB3AIGjmscLfy1WxvqSqJQG27C/wR+SY0Lu3TaaHZmDFmfbj1o7vq5MEz0Ww= X-Google-Smtp-Source: AGHT+IF2fojP0dtZyLIM5+nHo1k2WghChM1L/tdHDzXgdfACgOx8AXC0EqTFwlLQ7ZUQdf5ldjnuEg== X-Received: by 2002:a0c:f40c:0:b0:6c7:c8af:9447 with SMTP id 6a1803df08f44-6cb3b60991cmr85388876d6.24.1727531183658; Sat, 28 Sep 2024 06:46:23 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb3b60fa67sm19472216d6.41.2024.09.28.06.46.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Sep 2024 06:46:22 -0700 (PDT) Date: Sat, 28 Sep 2024 09:46:21 -0400 From: Johannes Weiner To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [PATCH v8 1/8] mm: Define obj_cgroup_get() if CONFIG_MEMCG is not defined. Message-ID: <20240928134621.GA957841@cmpxchg.org> References: <20240928021620.8369-1-kanchana.p.sridhar@intel.com> <20240928021620.8369-2-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240928021620.8369-2-kanchana.p.sridhar@intel.com> X-Stat-Signature: s35yo9w7s8nnsrnumzpborr79bict59j X-Rspamd-Queue-Id: B670040005 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1727531184-600264 X-HE-Meta: U2FsdGVkX18kcyInzBU5H5oyYULsCuC/YRN1G3JGiyt8LW8uCYdw9yBcLgPTOJYZ5uR2a4kHLFZkkhcd1225Vq55MxDRwWAGDh85X2PLpuZ+q7uXVK5bOnHF1mTsAZhiOwVTr1zBwTR/rJHv1yvkqIptRSu+j6ZLyUBvgMw1GY2gLPBqXy0sovO6C+55DAHYAPcm9QwGOk6xSrRqmiiK1YqE4GdaoXzhNNxgK47/ko48gn1lGflB1NGJYn63JHTMtB43/bPJaOIicOzVF3k74qjE8H0amcSQdfMCcTH40BmFwgH8rYuy+4Bzs6o43zLntfn/mjZd4DRLsIM2bJR7ZKZBqHewlbdTbaHY/G20Dgq8VekH9vvqQRKPO+9YfTp89PaWaLMKUHtwGWKt2WCj10H10iyowfZSBUrudGCVz3InCmO3f3coz3Gw7D3iW1TfLAbAr6u7sFX8/ofeLl0uNtOz0SbmrM830nEb3s8ZM1IVq/Gw5tgrt2+3twJqBj5C9Aov8Iu/5Z9MLy1FQK+0jCDF7mddv5/W8JsGu5xnI6JdwBXBQ1LiiIsXHYkSB/fxX9A4bHJUJmoKLR3KO+pNNm1Xs2gzYXY3xuKScoAGYv5pk6IxA/MNrO8ArgR1Fj5vK0J3aFamlzkdbMNGLXm88iD8TTx4GjJxpRNJKTpkeSrxGCwxsT488r8TUlsd+AoUuNFj7NvtJfvYAuiql3LO53gyciVvfnTTSF+mKbLGcauMDdd3l9TrqNIeXNq+ZNyyGs5zkn7/nABAB9jjzUoVxDk2d6aYwV0KnGLsDEjQh2HNCBRmbEMT6/gWWZisL2CHWqvqJzESfUfL3VfTQFW/LRs6BuxS3IqL8dJKUnkPBtYTFCk84hxPSNErhZq6aybqVt7NWM55VY0X1MeZcK1RO5yUUgydDOHbcgDj0fQEEt9ZKZy1O+39KUplEJL7PiADhBlcVaA8ZFYs3N1cpv9 x+4Hzm4c xy7T187YSC/7+538nF7HM/d30U/N68Fj4E1WiCV5Py3eDj1pEVco4VV1637xCSVeBx2OBsMSI7HUUDbTP18XYF715XD9Vx7z3r8ZLt0olBbxx6LLXSbAShB4yHzN0RYvWgKGVi5iuVglRFvZnU/ieG72DRUZ8/GTlny+rv9IGOp/a+Fo7toBvQFq/KNa9H3EYP51kOJP+z2PcLf7wcBADviaDOmKEutq8Id8tcN/o9KgcUMOmelW+Ml1D0Ii5xIXjnXBOMsj+shDBtvGZ7vC85ae4TYNgvoP5iO0Kx+P7lUN30WWwWMRWmXlXXMs6+FjnYRcKCVPMakXN6BH8GCEDyrFZpqGPkIFiEJu/UPNws/+RG5BRdwsSTzI1WlK+b6mxRy+4RujPmmwoIIjZKbCNQyISgTPxOQVR0CqbOXG/hfk77tRk5PtfcVYw8698d3sJxBUiA4AVjlAA2L7qL3qcaGgC0EUvpeq/Ph3ztMu/zPocwPXZE4fNz6aIzLiXib4GSuRfF9j3kXVxlv3GXQB1VrbTbD/hvC6Mj7LmwqRCbndtMnqeyGAgz9eYUkUG2pZuDxGa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000027, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 27, 2024 at 07:16:13PM -0700, Kanchana P Sridhar wrote: > This resolves an issue with obj_cgroup_get() not being defined if > CONFIG_MEMCG is not defined. > > Before this patch, we would see build errors if obj_cgroup_get() is > called from code that is agnostic of CONFIG_MEMCG. > > The zswap_store() changes for large folios in subsequent commits will > require the use of obj_cgroup_get() in zswap code that falls into this > category. > > Signed-off-by: Kanchana P Sridhar > Reviewed-by: Nhat Pham Acked-by: Johannes Weiner