From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5480DE7716D for ; Thu, 5 Dec 2024 15:20:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B8446B00F7; Thu, 5 Dec 2024 10:19:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 641986B00E5; Thu, 5 Dec 2024 10:19:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F7CF6B00B8; Thu, 5 Dec 2024 10:19:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E53A66B00A9 for ; Fri, 27 Sep 2024 01:08:19 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9431AAB43B for ; Fri, 27 Sep 2024 05:08:19 +0000 (UTC) X-FDA: 82609337118.28.4B2DF4A Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf22.hostedemail.com (Postfix) with ESMTP id 5CDCFC000B for ; Fri, 27 Sep 2024 05:08:17 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=jnV5hrdi; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf22.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727413598; a=rsa-sha256; cv=none; b=AyNXvI7XvyxSm/KowJu96Bcgh5xU/ouGj+R2UFmvRCJmUJtAmuI7y7132MlQryLURu7QyE JdVB5KlN+ZOxGH7a2UWL8T322IuQItTaodYt1dHqUnYhOE3eiR3e35aGUlSYkiIxd6dJvQ XqV8rSt0qNh7qGx92oU60WLjp8S+/gw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=jnV5hrdi; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf22.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727413598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=9CApFunvT3sS6/YT43VCSzj7JyIFMaSoyJEvAHbUpvM=; b=BA+2yXdLlUXsHd3cMfLeCmnsTQ+Wwg/p3+X1eBxZu38VXji2nAgCNQYO3UnsEk5BYYk0WG yqbLHVKXWYEJ8QGDeCfw8S8cahH+rM+QPjDVkVkhKVHffx6Td77snHl3fr3K7fYSgfpT4l P3NRjvONWqxfVMdN3CaugeUX2XNy98w= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48R41dHC004377; Fri, 27 Sep 2024 05:07:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from :to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=pp1; bh=9CApFunvT3sS6/YT43VCSzj7Jy IFMaSoyJEvAHbUpvM=; b=jnV5hrdi7DVHqUOjDvmrhKLHhLIbj6UDFH53B2wn9u Vr92oCiTp6VWyteBiVtr/FpT74/84MVbFWeDrB5YnPJDdWOp8yrPqa+1XFNCEUwo xGNQh3GlG8rBD6uVem40ozWiM4pXfPNatjFhNRpKUikIGhyJXehDiKEMwYOVQ1eh 4hKNND4eoOrhAkKyPFjAPPPJxFroXeZ/8ApQ4NTf1jE/MjegXPYAC+7BEVYK71iY 0DURNa8/39HescwAxlP7H+Oe0JuvRm62R/iNEWkfmmP31E7nCZLaObkR2ByLoR/Y 2Bm+4lM01xFwDHl6PvfkYM6kn19QEErWs/goHYlLXqTA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41snnatagj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 05:07:58 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 48R57w9Q006674; Fri, 27 Sep 2024 05:07:58 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41snnatagh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 05:07:57 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 48R0WxJ6000636; Fri, 27 Sep 2024 05:07:56 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 41t8fv35ay-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 05:07:56 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 48R57tkc52822414 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Sep 2024 05:07:55 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B0CD20043; Fri, 27 Sep 2024 05:07:55 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 75C0D20040; Fri, 27 Sep 2024 05:07:53 +0000 (GMT) Received: from ltczz402-lp1.aus.stglabs.ibm.com (unknown [9.40.194.31]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 27 Sep 2024 05:07:53 +0000 (GMT) From: Donet Tom To: Andrew Morton , Shuah Khan , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Ritesh Harjani , Kees Cook , Mark Brown , Przemek Kitszel , usama.anjum@collabora.com Subject: [PATCH] selftests/mm: Fixed incorrect buffer->mirror size in hmm2 double_map test Date: Fri, 27 Sep 2024 00:07:52 -0500 Message-ID: <20240927050752.51066-1-donettom@linux.ibm.com> X-Mailer: git-send-email 2.43.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: u3hJP0oEm6bBvR-I7cUGFJWASJe_0GDW X-Proofpoint-ORIG-GUID: lbJ2JrcLKLuXquvqnZftyDtOSMpyQfrK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-27_02,2024-09-26_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 mlxscore=0 mlxlogscore=775 spamscore=0 impostorscore=0 priorityscore=1501 phishscore=0 bulkscore=0 clxscore=1011 lowpriorityscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409270030 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5CDCFC000B X-Stat-Signature: yw3bwzry71h6cym9uu4p7kn1fa6uq5e8 X-Rspam-User: X-HE-Tag: 1727413697-847719 X-HE-Meta: U2FsdGVkX19GlitfsRTnGNR8/qWZSn0d0yhovcHTlvGeJxXh3zAVXX8/tcqQQQNtOHjJ15Sl9f4xRuJHsfG/XUHO8uoI6R70JCZ0ikNts13wjTa+BkXFQGrRrtwJ7HCCbko07pKUsmtUKvQ/j4tK+gn58mw1/f29FUCNJ6WlhgH/DWTYGvTUH2viiTUru10uoMksEtrtFxbH4vt5PjQIoIPza4Vd2A3ZGXwCBOEwmmYInYaGidP6GpYRQJ6Ni2cUa19aVSSXVIvvWbpiLYh7hSBd1Ye4yL0MJB/98M7f7Rd/5qVHF4hMU0VqgDm37Rq818NtpA9qCY8EAdJSjJQz6ah/auJrqNLTGonTj5rA6ILPsTPGha2B1Ai6rOsGu4lJjFRB5ElTJ6aJ7OadiXGh4faOShui+XTZ9B5C2SNHAjfIJEYeBxmVAQJSKXAWw55u818IjlGsmut1txLLhW6DxT7W11uYpA7/ZuGqfZnKLUgTb/ynOWOgaZ2VirQ4PR7+h5fVzfv3niKW+q1EHR0ptjGXujYTI02Nm6ImWDV4Q0mWHuE+NBYj5qBL7p6FUge/I5W3SBi6Bs9B/06hZL/MqgRSyY8ccaJQapPUq5HjNoI/jYy+0xQFUTRcEcap1S1szqLi5bt6PQfmILH7Q1PrZyhJuzZcJyp5imT5dBFeNtOI+tqu/clLqxAzdCzMUhHr6AH2GYq7f+HmY98+zgZaRAh7Szx+GU04R5cjCffv00eeUDGjwPISKxAc3PBLxDmKFpYLs5n2PWV38rp+zIZlASNi65G0HiqfZKaf+qG/Y1IdcBp6kOFJFN8T4/HS3gZQwH3oo5KuMPrvQHXNSUE9HZ7iKcPOkqloF3QaqfDZ4DZVtF7lwPZCUvs5w7bQOG/pT9u+I4dDnIqeIu5Vv1LUoNP9/8Dh2HaMCvC7XJX3hMVpQn/7NoOrPmUnv2qb/pXSO9Ih216QKzAeURaecBj Xu/TxN+Y ttDaLTPMKTSdsBgbr3pgBwM0Ha6wjjF/GeBJU8H11uBBVLnXISgWUezm19JGcEw65q2EBpXTKTeUeBh2X/Aif9pEeY7rJBrOw4XE9gOxVe0T9tFZiygYeZJTjhQK9IctpektdiENAaigXPvB1CmBiPFP1o7sA6DAShFtwAnitJJTtLiPfjAXHL/NwK9DTWr7AsEc1iDzKjEFEHqPkBHhfj+Zb8H4tIxMoI/iQw8G8xtMiWfmFKI80xYrSPOPAN5FWjzBbNhyhv9u53OVmSsW1eAepywlstK1n/Bdiy4GuP6VuHhKFsQGodB/f2UrkvYaGqitwwVdApw8ZwATFrGuOVkAACkB0MiRoHRx+x1XaF4VEHBQK4NwLegYnG+8fLuSUMvYa8llJu8pAXQPBRRD+uuUgD6JuC0vFbjCSAAfed77i4JqxN2p2fADVykuntHyxNvOL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The hmm2 double_map test was failing due to an incorrect buffer->mirror size. The buffer->mirror size was 6, while buffer->ptr size was 6 * PAGE_SIZE. The test failed because the kernel's copy_to_user function was attempting to copy a 6 * PAGE_SIZE buffer to buffer->mirror. Since the size of buffer->mirror was incorrect, copy_to_user failed. This patch corrects the buffer->mirror size to 6 * PAGE_SIZE. Test Result without this patch ============================== # RUN hmm2.hmm2_device_private.double_map ... # hmm-tests.c:1680:double_map:Expected ret (-14) == 0 (0) # double_map: Test terminated by assertion # FAIL hmm2.hmm2_device_private.double_map not ok 53 hmm2.hmm2_device_private.double_map Test Result with this patch =========================== # RUN hmm2.hmm2_device_private.double_map ... # OK hmm2.hmm2_device_private.double_map ok 53 hmm2.hmm2_device_private.double_map Signed-off-by: Donet Tom --- tools/testing/selftests/mm/hmm-tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/hmm-tests.c b/tools/testing/selftests/mm/hmm-tests.c index d2cfc9b494a0..141bf63cbe05 100644 --- a/tools/testing/selftests/mm/hmm-tests.c +++ b/tools/testing/selftests/mm/hmm-tests.c @@ -1657,7 +1657,7 @@ TEST_F(hmm2, double_map) buffer->fd = -1; buffer->size = size; - buffer->mirror = malloc(npages); + buffer->mirror = malloc(size); ASSERT_NE(buffer->mirror, NULL); /* Reserve a range of addresses. */ -- 2.43.5