From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D340CEBF80 for ; Fri, 27 Sep 2024 08:06:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB20B6B00BA; Fri, 27 Sep 2024 04:06:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3B616B00BB; Fri, 27 Sep 2024 04:06:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDC576B00BC; Fri, 27 Sep 2024 04:06:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9B1386B00BA for ; Fri, 27 Sep 2024 04:06:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5A7DE16097A for ; Fri, 27 Sep 2024 08:06:07 +0000 (UTC) X-FDA: 82609785174.28.C3AE364 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 9AA0A80018 for ; Fri, 27 Sep 2024 08:06:05 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HaAIXMic; spf=pass (imf02.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727424244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w3tgcr07l48NUpiRId4iNl4o70xksvq/UJEdOlAXpiA=; b=OMnGtLcA3Ma3jvRZZWq9PaeuSoE3waHA/EeSEQpFxrLCfkM8Ilc1rV4yyVYoTG/I7AvwcA DsE1UPXD/Xby3bMjI55MCgtXQQi76V4bgNL5m/puwoZ7pvKCgfbY2Y0apMwRtUhYhpHjSL oXYLrpmuVHNZhgGR9uT0RMgY3aYBSq0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727424244; a=rsa-sha256; cv=none; b=Mb9uTTST+H3QNCqZK2mnVXcPoRxemXnsxImvDK40JtvdEaj7unXhK9+ibq7kHoci0p4h/K vfwQBVNaJIcEjz4ty4QKF7pusmz2+TWUV5licv0dlIUcmOHlWUStU7mQG8WAqdtNjaXftJ ZsfwDtOqLQeYqDV5hV6fsvkKbTwxLSE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HaAIXMic; spf=pass (imf02.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E28A45C5A4F; Fri, 27 Sep 2024 08:06:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8945C4CEC4; Fri, 27 Sep 2024 08:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727424364; bh=KjsjOpufVwVtvtG9C4bCus2/XmKmDXOmFJWmSRq/BY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HaAIXMict1VrTe7i8TwVZ5W3EQ/WTegi8/OHOEkwPr173UnrLezn4mPejbmDGj2Va JzClZWAAEFXfx5vFVFkjx+3Bkn30tc+SssdrENLR5FslHOsVouXCdLzMO+adoH9tnc zkXNylEWRwKw5LUIOdH0peE5GHb2oq7StB/T/R1ZqX2rjLg3gyt73TQdT9CGlK1e1y +0R1PmoplUYpYy45bYv/DHBqbVebHLvqJ+Zj3yrLJO2EGsPMgBdMR6uK6DZ+/mXWG2 BnuUyJDVL64zGvygjtGlvBwmLB3O/DZn15DHVuse1YXw/gPPN/DLf8Erpw19GuMUJ6 BIWbB7FwYdy7Q== From: Christian Brauner To: David Howells Cc: Christian Brauner , Paulo Alcantara , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Markus Suvanto , Steve French , Marc Dionne Subject: Re: (subset) [PATCH 5/8] afs: Fix possible infinite loop with unresponsive servers Date: Fri, 27 Sep 2024 10:05:44 +0200 Message-ID: <20240927-raunt-gekrochen-aa4fd2c2e59b@brauner> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240923150756.902363-6-dhowells@redhat.com> References: <20240923150756.902363-1-dhowells@redhat.com> <20240923150756.902363-6-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1319; i=brauner@kernel.org; h=from:subject:message-id; bh=KjsjOpufVwVtvtG9C4bCus2/XmKmDXOmFJWmSRq/BY0=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaR9S0+55/AnN86X/6qh8Jnw2/fN3txs/vdb88Csxor51 h0HFWpKOkpZGMS4GGTFFFkc2k3C5ZbzVGw2ytSAmcPKBDKEgYtTACbCv4SR4f4hM23PS4ZOM4SW /uIJzdp91vHK3XmrQzc7J2s8lPYT0GT4Z2t0NERa9/mHUpZlb9KM7mza0TV9pafR+8KMuYvUDR4 GMAEA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9AA0A80018 X-Stat-Signature: yuhrf7raffks9emba4t63nmmkohqbkt6 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727424365-843712 X-HE-Meta: U2FsdGVkX18koNNhLEBKVKi2leyFaFy/0WSlyFygJr58ieE3EqwmNhWc7iic9SyniLrUkqmV3eh36RlDGPDSDA9NwyDJUG7g3oQhxC2jjj4sLYMmJqJUphXLfUkmSM/qu2Z7EIKYolCbVDECwTXINnXEFrWD0K8b96d8Nn0J00jVnjYO5FoA9LKOu8nv5b0wljQ5e4rWPvaP4CgMlFWXXdkxRPx1btCf1CrF+MPWhNevAEBsEVBnss/zxxIj1d2HCfxaa1yhCoW4nQ5C7Jr9JXmFJym1ttdftqagBbxvMWes8ipX+DUx7jUBScVvUA4+sJgdh5S+kI7/CqEePYU1E+JHQSOZ5ca7yJ1EFW5YfrA2YKKZaCQhL9R3y9gcRLiFonqPrKLWtbfyMcbHwO1pLlKWaxp3Um7T/MUzrZ+T5sYnYUrACgJmDw+BwJ0cXweXd2sg98LV0NOEb4LdyzW1Wk7FZg77TgWax+sYJWKHYggmQJiEGzKfGkhdbCSpe77w8WXzFVbvp5Ppx+q0O0P0Gc1AXjqlUJ+QejP3cEa6BxvipgAC8ARR2svGkWz0+QgJMtst9JnVW0X+Fg2nf0fn2d0kiMrPQjLGRhFkTVqrjK5DhqkaMDSuPattHnc4JVzXqCKagbFHZrEhDmnHVUUC/Jv6kXRyCmSScEmoGNBZnENR47MwQzcr481YS7GV41C5rL9mD0jcdK9u2FXKsUT0UX5UVWPbVBnfx3YAH0ESiISRR9ZgfohwCqUfv59Wz9rLTxgsq2yjmn/zpyv0f+3vJoh5XkZPd8371EWfhjMFb19L/j/IGA2m8jclF61Z0fCZSzto3oGdH73Phd/jRriRO5nnzAu8L33pYIaORiJ5LxpOWPLn5T5H8xqkCunRcuvRe1//TjYtZdMR3frar2Dv9Wv04Pb4xx/kABfUICPDwpM1kO1ZBm9SqTYPi7IFgIiMZcdtanQjW2xxeIcxV+C rn8EDxpQ 6/sdAJVcdhflgmdhXYGU9PptrjIV8YA0hu4LJGzBPsU29rT20k/s+diSI6d6wj6wZFW3CZl/H4LuAHkHilxffjwX6gM2FYznbkESN+8G6pUm4Zd6wIYPDgRZXU//Arg9UUN/QXRG+p4nR/busHf0Q0j0rWHwHH7F9LjH26D9rGqWXhOI76Rs4wj1aS2bnuQeCwRWoD/o3HkCFaRocxeMRezdMi1C37OtGMdwVSVot52vr8tTZqplQ9OGbTWc4JgsrDvQDJCAK0xq8kgn1EROeM93UezLiyycS+4PgqBC0HgP9d/c3T6h8LfbHyl8XBgCM1GoLCJSIjjtrrmSnrL+0j0PuUdE25Vgh+TBlZSktW+YwYW4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 23 Sep 2024 16:07:49 +0100, David Howells wrote: > A return code of 0 from afs_wait_for_one_fs_probe is an indication > that the endpoint state attached to the operation is stale and has > been superseded. In that case the iteration needs to be restarted > so that the newer probe result state gets used. > > Failure to do so can result in an tight infinite loop around the > iterate_address label, where all addresses are thought to be responsive > and have been tried, with nothing to refresh the endpoint state. > > [...] Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [5/8] afs: Fix possible infinite loop with unresponsive servers https://git.kernel.org/vfs/vfs/c/6e45740867ee