From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 584ADCEBF81 for ; Fri, 27 Sep 2024 08:08:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E03146B00B4; Fri, 27 Sep 2024 04:08:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA9566B00B7; Fri, 27 Sep 2024 04:08:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EE786B00BE; Fri, 27 Sep 2024 04:08:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 673C76B00B4 for ; Fri, 27 Sep 2024 04:08:17 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 213B91A0A9A for ; Fri, 27 Sep 2024 08:08:17 +0000 (UTC) X-FDA: 82609790634.21.99419F3 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id 6D628140013 for ; Fri, 27 Sep 2024 08:08:15 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Outd2lB0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727424396; a=rsa-sha256; cv=none; b=NgNDfZHroWNIB2LkKwg/XzyCZqNRgdNpFqrcu8sC5HPfETkpT1mhS78HExs8tmEN5BvnSt xje2v0lJScE8SDfkb0esZWJT4/Ex1MqinsxPbJ7EPnHiUsAbSjSM9bGQbgXE9oB2ajT1h0 7BBZzcBr2M+orvRXBPGOV9AhP32QfrQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Outd2lB0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727424396; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l7eXDrSzOGi3k3DnYW9RcbNV1+ltNakNRfv+mQxnasw=; b=srekFtCT7puiy8cpXsCSBNzh2LS9kFWa9Y8VohNmowqdTbVVUPmaem7QZWipGfdtLBxaw0 8+DhzuPt0JjBXpHaA1jKfErCnJtUu4M3//nJT9Dp3CpHFXlakkx5QdDhWP/DKLjCYyPUEg KXZVmSCk+jxy0AoBI6FsojmvSPA9dU0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 9A55EA452CB; Fri, 27 Sep 2024 08:08:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1C4DC4CEC4; Fri, 27 Sep 2024 08:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727424494; bh=qrr8F6mhp37/8goTelXVcSv72h5Emk8kpcyLOVTI7nQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Outd2lB01VOTLYDOGeswQwueKzlm+EOifqdxlQ4wB/8MrqP6mZtqn6n+rKIoTqc1e kiisilHVnZCIEJvalKnA3qR2YHOkwk+HzZxQYLedHYLRTpBSFEheAsUMMOVVXFYRgj oZNhoNHLcUvthQxoFMAThjmuiGgHXqnMfBJJboyDD3j6cY2fyYQxHOwaNlAfY9ESKo grEtBzrVEHlyEpt136/mYVhFyRdz36/t+JDZSXA5Mge9d5fwWXYM2cDL4KIrNMeMd8 WUGeJbN6K897pM3Cb8O2g8BA94c0wF4P33q9OSZrB7Mfqe5Ls744JoZHQWmwTx2/kE UOLO55iVty1Fw== From: Christian Brauner To: David Howells Cc: Christian Brauner , Paulo Alcantara , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Steve French , Marc Dionne Subject: Re: (subset) [PATCH 6/8] afs: Fix the setting of the server responding flag Date: Fri, 27 Sep 2024 10:07:59 +0200 Message-ID: <20240927-inklusive-erfunden-8a9df201244e@brauner> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240923150756.902363-7-dhowells@redhat.com> References: <20240923150756.902363-1-dhowells@redhat.com> <20240923150756.902363-7-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1300; i=brauner@kernel.org; h=from:subject:message-id; bh=qrr8F6mhp37/8goTelXVcSv72h5Emk8kpcyLOVTI7nQ=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaR9S3928A/vY47APBNFzaQswV4+Pw8Hlu3a9bd+cD9uO Frlc/JtRykLgxgXg6yYIotDu0m43HKeis1GmRowc1iZQIYwcHEKwETyLzMyTNTnfr5xfcZix1xr Tj7JEPepAnKn+FvmbAnf0rfRyop5DsP/gIP2Vf3Nm3a29nDoVNhIl9UaHjpdV197f2eb0M+i678 5AQ== X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6D628140013 X-Stat-Signature: wyn6qimuwzwipc5q4y7gndrkcjdcb3ms X-Rspam-User: X-HE-Tag: 1727424495-403574 X-HE-Meta: U2FsdGVkX18eiug5HkISvKv0s0Xca9Rzm3slOoRCiviaff9wFCgRtNW9EqyCx+ackHLaS6x/00vxxQe7Z3jfQ3FAI+cx+JxaWIRnARFz0zDzLkGJNOpRvaR6TulhMM955ilYvAE7y/om5EfEdGCvmu+XJIWY0J7dgyJC7j6zx3h08bvj8sDIMh8jrKYAebir2icFKey6D6yum54O6uP45KoplR9x2lHTMLSAEUbyZtXeQ4dak1FORuEcGrpcUCG3Re2px/CBcnnaqOcQ1YN1WS4wAfnsc1tGJtsgEowm8EiTD6X9TpWw1VBbNaITqYKZSZEFtEwCuG/qlmYv79bw5V9lgW/NPaRaxlg4iZwFmHk06v2sBybaSXfJeP+0b4lnuColfWT9eODGZUd2is9Gg9X9hZi2bYtyYs3CokOQOA4GyKbJQSclHJUoEGbgDobAxCxQv5BeuCY1ccgjm2sIkZXn92znQgfyifCSTiN6gqJzt7c6+4ldNL6nWm+b6mQ4W0L0Yg79yLwwfIFruIT8CriuxPePg1a920DELFeSUyo7UgoRoquRBTfDnhKQRuHghSkmkdR3iyuo/PP1/Y1jhO7Kdo+POpelyMbcGOR4BMsLtr9L05Si3gmTROFbw+chPr+o1sGdQmuL2CZ+QHOo5I7i93XVY32TgGQLqEBPpXJWSz77SFHB2ELLWK3Uq37MKbXhLkDKAdKcOtWLi0p7f0dujwjDMYJKx3qYVED6WUaWJsDMiM869/0J5YevtF5KfuIDRq/nMlXi9G/CJGfN0JCMQfYAPT7bpH/BKGbrBiR76SxU24eTWcAB8vQqSVoX7+wstDkgq72/HPQR7xqoVDDF8oo9buw0A5dBbhhaATHZ+IZJcwZUdBOgiPRxGYKVhFdRczchWGD5PFB0Yuppr+IorLoW7GtZgBXbAfOQg5iWWsFI1W9taLLuGZ42gm1V/R0TPjIVK4R9KjzJfRx uX7S3yDn z5QzDzWyKXorjMY1HqYF4ubCSzwIwc0Xg478Ha1Ta/9/1PIwYR+qFYKrCCYM3HGnKvpLIKMEnwFgOlwkRRDc58Eowlq4Yi3q9hR3V7QfgH04bAR8CQwNO1bPBYDu8gk4Gd6gLCuGlfs+7o6wO1SKu5TO+v2TbPlKIfUGXv+NuPEeIVvqfq1mWrvZdwywNAsEWYkCLVUd3oCOIROoLVdpR01KkTNEm5Tf7Oj0mCCTD5sY/2Vn9yvD3E+ReNF5UjgL8yrMB+R/O7JZjFBfnt3zBp4+ES6KY+B5zqenf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 23 Sep 2024 16:07:50 +0100, David Howells wrote: > In afs_wait_for_operation(), we set transcribe the call responded flag to > the server record that we used after doing the fileserver iteration loop - > but it's possible to exit the loop having had a response from the server > that we've discarded (e.g. it returned an abort or we started receiving > data, but the call didn't complete). > > This means that op->server might be NULL, but we don't check that before > attempting to set the server flag. > > [...] Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [6/8] afs: Fix the setting of the server responding flag https://git.kernel.org/vfs/vfs/c/830c1b2c1c28