From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1055EE7716C for ; Thu, 5 Dec 2024 15:20:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50E256B0106; Thu, 5 Dec 2024 10:19:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 15F1E6B00CD; Thu, 5 Dec 2024 10:19:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E82326B00C3; Thu, 5 Dec 2024 10:19:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 85EC26B0096 for ; Thu, 26 Sep 2024 10:50:43 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D72471618CD for ; Thu, 26 Sep 2024 14:50:42 +0000 (UTC) X-FDA: 82607175924.15.4A94BEC Received: from mail.rosalinux.ru (mail.rosalinux.ru [195.19.76.54]) by imf10.hostedemail.com (Postfix) with ESMTP id F0F9AC0006 for ; Thu, 26 Sep 2024 14:50:38 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=rosalinux.ru header.s=1D4BB666-A0F1-11EB-A1A2-F53579C7F503 header.b=gRjbrUWG; dmarc=pass (policy=quarantine) header.from=rosalinux.ru; spf=pass (imf10.hostedemail.com: domain of m.lobanov@rosalinux.ru designates 195.19.76.54 as permitted sender) smtp.mailfrom=m.lobanov@rosalinux.ru ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727362105; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=FzNUZhWdCS1OUORwDMta3qKIHBA0BUIs+eqtK3/W8Xs=; b=u5re+iyI9tGA2mgxnlE89nOmAYMsjHcqvtn6imEov0LJDdJqFCwLi+bgvtR3NFteRDBAY2 lnEzsQcuCyMYuUOHw9Ygn2iKGPYKYjDa2LlLzx9Lb06QfEQtpmnYGl+37MVwpjByFU6I38 HNA6MJqr9ssqke6I+b6DFKFYAU594VU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727362105; a=rsa-sha256; cv=none; b=hr3UbxLHXTFszb+fDMMP1ceFBAwoHZ0fv9o5BIBYMyd7Qpa9RLiq5EjXAG/011PTCe3P26 KdtXWEkOf+FKKMVrlCe4jtTj6YMn72BMmCRvMg1LwvL12F1jF5ptBUUeEpGEXmvtLTp5kf KTHESKs9cVnKLKwW8JmWpZo9wvebjIw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=rosalinux.ru header.s=1D4BB666-A0F1-11EB-A1A2-F53579C7F503 header.b=gRjbrUWG; dmarc=pass (policy=quarantine) header.from=rosalinux.ru; spf=pass (imf10.hostedemail.com: domain of m.lobanov@rosalinux.ru designates 195.19.76.54 as permitted sender) smtp.mailfrom=m.lobanov@rosalinux.ru Received: from localhost (localhost [127.0.0.1]) by mail.rosalinux.ru (Postfix) with ESMTP id 30F6FEDABFC10; Thu, 26 Sep 2024 17:50:26 +0300 (MSK) Received: from mail.rosalinux.ru ([127.0.0.1]) by localhost (mail.rosalinux.ru [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id bxDXcRfi0DwX; Thu, 26 Sep 2024 17:50:26 +0300 (MSK) Received: from localhost (localhost [127.0.0.1]) by mail.rosalinux.ru (Postfix) with ESMTP id 03F85EE677C6F; Thu, 26 Sep 2024 17:50:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rosalinux.ru 03F85EE677C6F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rosalinux.ru; s=1D4BB666-A0F1-11EB-A1A2-F53579C7F503; t=1727362226; bh=FzNUZhWdCS1OUORwDMta3qKIHBA0BUIs+eqtK3/W8Xs=; h=From:To:Date:Message-ID:MIME-Version; b=gRjbrUWGzY9Q6tpu2NfosOPMKj2+ALxbmQbCB4TXhE2H017iRopIuyNl7FaiNSxK+ GapLnSdzkx/rcIMN33SveA6EWa69ug1WtL5xvVFLaMcsurC5irFb+gzy/YuRx7pyLF Mk1swH7Q2ShvQXATL0hW5je6d43Dst6KCQCkC1mF0NI4c0qekiqTwn9AQMaKX6heg8 8IsArnAkiT8EoNolL6xIrFbaQ7eBeeVc2UwaeniIglo3HRhoIznIHqMTx0dcwL7Rop GhuRDnoSb6y0YNevWE4+gWDdqeOnertayVFMBz/doCRVQwLI2sBjlPKvOxpcKyfBxd JHe14P8oO66aQ== X-Virus-Scanned: amavisd-new at rosalinux.ru Received: from mail.rosalinux.ru ([127.0.0.1]) by localhost (mail.rosalinux.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id G6lWgT3BvZNz; Thu, 26 Sep 2024 17:50:25 +0300 (MSK) Received: from localhost.localdomain (unknown [89.169.48.235]) by mail.rosalinux.ru (Postfix) with ESMTPSA id 8D5CDEDABFC10; Thu, 26 Sep 2024 17:50:25 +0300 (MSK) From: Mikhail Lobanov To: stable@vger.kernel.org, Greg Kroah-Hartman Cc: Mikhail Lobanov , David Hildenbrand , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, Anastasia Belova Subject: [PATCH 6.1] mm/memory_hotplug: prevent accessing by index=-1 Date: Thu, 26 Sep 2024 10:49:21 -0400 Message-ID: <20240926144924.53444-1-m.lobanov@rosalinux.ru> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F0F9AC0006 X-Stat-Signature: owjz7y33a3xque7fgk9heq13ct5ah9tk X-Rspam-User: X-HE-Tag: 1727362238-202213 X-HE-Meta: U2FsdGVkX1+mlSIDq+7TeC0yTcQN4lNcUNPQ3KeRZIOeoeq0MnQJOU843XLqZVdI+8aqpkIDi0qxbfGt2WboBjXsl1CXfmitL5qzwBYyrPxctsCQKsPX1JWIMmNzFRH8eyqcx6wizy2jmhH7xUNHjRFYygK+8AlJZSgG9ZXknY2qpDlo19bf9W6yHgnw+4Nd9+HdlxvNcQDnFZrrsxu2mJrSNkELvfx9zBcY/2s62awayVJaSinD8yafguF7KbrllIc3cPNatZTyAjVbdBHIuKkakceAGEbDenBhmWLQE0Dlztz/3anh+JucwkJdYocRA/knBB8ulypE+lqFgCvcoHDAs4PWvl5WJ1BcpZNSVkyJQCybq4sbFcuFQPQn4tNPVtedh8oKAjigD9gjB+7jVqHp7ZpdGiBkooWCeQYZ5I20E++eHN1SVgQYykjJNicijfAcOpdhd+HdhOXjkrimYh6X88ZcLMbN7aWiO1ozW+QsXJRLkYcdbNSQgMOwOWCJbRi4jwkhVskOanVnIU2o4yRsgpaVf9VQxJiLCS7GkQ4i9u607Ciu0DNWDNe6KbiQzzW5S0jJVQTqyV64wpCdtyHjHQNAODXBIvVf1pdlUUCDRtx0hx1tNmWu7BrgBznU2wxHnbbm2Lix5AsKyyeg+pkTZ/Nc9Hdq61gtzM+7EvJj4VSgOB7hF8x9ZysOC9j71W6hELGvbj+g/UIsdPqbdXlzeTo6j0/ZavgFjAH77K/RjYi0en8WTVdhW+lMh3a1ESzv4OIA7AIaPqe62xfYANqs360ITit8B3qveeHeMcb2WJBQzUyiGZeDT6wufPfsEdWM8VpmqzRiHcZLhCDk+v7ZkMrKH+0KNUmpaF9kJt2M29Rnzfe2QagSnsquisPtCUyFzedv/HJZ0iA6q6tuGd8m7tasvt6e/21PKeSdGaz+M5M6wXRWaEap5+HJEAmh8todVqriu0dHrTqodZS xSf+O7Go 2MTw9Y+rUP903byqlFh422J5HUtq+HOUQYtU8EvZ4w8uwOoRZKKgtrzDC6Bo/uhcw36djOxsDhNtySliSt8cxpEcdKSe9FgnUB3xhOiCGTacr8+1o8EvnFPrJZVCZevW/7ciuN9JnPj9GFtmaH560fY6OfpkBW7h6+fEn7QYuNAZd4QbVJM6j64ZSdpZH9/0RoxxGSYWzIx6oqZpKO1+qisbAwOD0a6O/WoPi46hk1lGdp7Xi4UficZW+5Ee0t5AoPe6+/fC12hCnO8K+KYMZ4go9Cdb4uM0uykc4fIxPr8XkZm3KoGj+qsgEOL5Lymm+YT9FnuzD46s3711IX4ok71QVq+upDdNBij4eEujnMQU4ysRT2iYdCtpyw68D2E6Ab3Wa4aPQxnlLBuHRIrbLEyHlH5UMqb9cQJFrcGvgRxHVYHZ/YtAOc1uzxx+qn7bE3d3EGn/JD4mIzzC6CCsuhjcsYYU/LjWRDwbvCc8EFQVmlMDXC0nAAEPXyktH38rpEwebAF3GuBef6NegmUE4i23LpEHqibOdBKPSY5fBoUPPmv8vx8rnkLy2MSG+4zMBTcRJX5SBOr+KGtRmngVr0ux7c3a8RtZV2YT2a5TW7f7tYB+5XAy0h2WLoB9LYvtmO2bdVB86m/e9kw0Tyc+6WBAL+4lgynWZar26ikx61+TCKUpfwYK3qvVRDNwhlH4nGi5c+wvlrXC6hr0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Anastasia Belova commit 5958d35917e1296f46dfc8b8c959732efd6d8d5d upstream. nid may be equal to NUMA_NO_NODE=3D-1. Prevent accessing node_data array= by invalid index with check for nid. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: e83a437faa62 ("mm/memory_hotplug: introduce "auto-movable" online = policy") Signed-off-by: Anastasia Belova Acked-by: David Hildenbrand Acked-by: Oscar Salvador Signed-off-by: Andrew Morton Signed-off-by: Mikhail Lobanov --- mm/memory_hotplug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index dc17618bad8b..90f0cc9a298a 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -783,7 +783,6 @@ static bool auto_movable_can_online_movable(int nid, = struct memory_group *group, unsigned long kernel_early_pages, movable_pages; struct auto_movable_group_stats group_stats =3D {}; struct auto_movable_stats stats =3D {}; - pg_data_t *pgdat =3D NODE_DATA(nid); struct zone *zone; int i; =20 @@ -794,6 +793,8 @@ static bool auto_movable_can_online_movable(int nid, = struct memory_group *group, auto_movable_stats_account_zone(&stats, zone); } else { for (i =3D 0; i < MAX_NR_ZONES; i++) { + pg_data_t *pgdat =3D NODE_DATA(nid); + zone =3D pgdat->node_zones + i; if (populated_zone(zone)) auto_movable_stats_account_zone(&stats, zone); --=20 2.43.0