From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5510FCDE034 for ; Thu, 26 Sep 2024 20:25:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93EEB6B0093; Thu, 26 Sep 2024 16:25:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ED2D6B0095; Thu, 26 Sep 2024 16:25:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DBEC6B0096; Thu, 26 Sep 2024 16:25:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 609C26B0093 for ; Thu, 26 Sep 2024 16:25:39 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 00518C049E for ; Thu, 26 Sep 2024 20:25:38 +0000 (UTC) X-FDA: 82608019956.22.1DC6488 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf09.hostedemail.com (Postfix) with ESMTP id 471A6140013 for ; Thu, 26 Sep 2024 20:25:37 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Icgrvo99; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727382176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LGtbYAJKhRN5SWducMTW1bJPKACuQ+00SB3SwFX+Xfs=; b=3J7XVrbOHaLoZw9P68foKOcKUcqZ0tXuL7EgC7qYix0vbvBCFDRlQo7Lk8aLrRdZlvmDM3 gfofDIRqMEDShwiwZjJ7qBFzXoCI4AtMjvEtehFrNgJ2CtRPcIinUTtM8w/j51Py1l0KeV o8t1VBlhuuMFKGkZEFEFgJyjjyFnBuw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Icgrvo99; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727382176; a=rsa-sha256; cv=none; b=KUQwckv5USb0/bImawLFRZAY/jOLE2C9TjZxI+mSOEJmLf9YhcRRjOh5NTHO1g2br5jWVa RmarpsOyKgZYetKClb0q25Y8uFub4VPd4ZDYFVQFQOGWtr5tVC9FqiyFM15l5fOrE2JtvV dSzJMi3wfFd6XJQaddqOiBHA8vUadSw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 212BFA41CDE; Thu, 26 Sep 2024 20:25:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DEC3C4CEC5; Thu, 26 Sep 2024 20:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1727382335; bh=uo1/TibeEEJkOqpqWAtLS5x6ig9W4X8UBIhUYNoAjJc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Icgrvo992vgDctuO+wUc4EDdYcprB4eHV51xlW5Rr4kmhm6PmIjUzsU5tMB7o01ve 5gCY9EQ0u2ER/508IyH2PECvFENBZ5xy5Ds4uzwSxaH8BPvS4uQygMfQUS10CxXSFu flpfk+/CFdDB5x3zhiH0ZTAzXOQIkUxN4sXw8Fqw= Date: Thu, 26 Sep 2024 13:25:34 -0700 From: Andrew Morton To: Xiang Gao Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, gaoxiang17 Subject: Re: [PATCH] mm/cma: print total and used count in cma_alloc() Message-Id: <20240926132534.8bd3acaf379ab592770e0d1b@linux-foundation.org> In-Reply-To: <20240926120049.321514-1-gxxa03070307@gmail.com> References: <20240926120049.321514-1-gxxa03070307@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 471A6140013 X-Stat-Signature: 3fmjtbhds68wgo1cgicz7ke5pd3if94m X-Rspam-User: X-HE-Tag: 1727382337-180601 X-HE-Meta: U2FsdGVkX1+uMn5sSD3on1PTvkJXbmPjGAgFUz5Hq3HZW28QophvwrnvC2CwYEnHr38XS9xkCBnm32oBdWTLfBW84WaeBzLnFR16DvbWSy2/Qx+CxbVr7WNuoeFXWgmS/VB7vDrrrbSo378Q2MigSmumb0XBUFG3Aa70LwnpbbrcNn5dkPtWB+fEQoG+ZbaMTYB/DXZsBB/cCwwuyEKzNIS07eXH1IWEARS7XxMdeule3GchsqWwLPKR0y5fh1DgOJn5ciVWMNdnkvT7pYrGjTXeAgsOjZi29EfPOkDaNRvVY3HJ2506ENbGN00wTBGX3zu/SiDgoFSgq2x7d9ZrqmzWe32sOgpk/ldHwVt4nHQAAvESF44Of7KmGeqLTHKzeeYhnFZtR2tL+c6xVxusnALaV0Arzq8H36eNIvhgq7XPTRwf4aQj1WB9cZowFRRyP5rZaeG/DG4E7Kyw5W0J4I81/UIr0NErnHdXlcBb6gz16iKIRWQAX1szO4eOYc1Luq6kmCz/SZrAo39hOuNC4QKpJuNzSORiQmSsbEjgskESAKGzNuYvgcKP1Rivim5J8cMt3slsfRHFSyw9GlaEng8AmO40jInq0d0metuYDJYGyV+qjg8+NkKK3OyWOhGLJjFMZFLFJJJgo9znYxK64m+cHT9yGkZasMnTalz2wNgIwmeiBjOD22jeJ6tYWaJoaUTTNqcI1Zx0VKYiM32GozMFhLw6Q2GXD7DAP7RGVb9TvYgd0sZIpwMf2morhA5BDY01QEb3qoYBmG9A9rPkTgb4QKgLrN0gMMeMmYkc9z5wg00/7VysZyH2aTu4kbhX3DLt3hYxE8yTZ/+fq0tKQBWPn3YTul8X0HG/N2bh/HbapwtFke6IcUhVc8S3V/VR5d5izQDjcTfGRCVgFrUlTzUSEgImdxWMPk0rxzsGK6n+3wJqdQYcvb7i7e8asTyWjgRGrtpuG2sCVoEGkuB m2R0f/j1 5O4o6rYjFOEmm+3S/BZ1RFxwz1zSqJvsOWmClUtkPtytohlXuEyr3zwPCzJV/wgO4na79gH9uBDkOK+JOrLAfolr0fl4VdoD309U7afcCwTgIFoWwPmCBlghHmNBUqneUF2pGFZx/+GSbzO+fPRcsB1fmWAw4hwcETEJTwKEUaH40ducuxvmROBElbISwjocjtdVFDoHr8uZskiyxv+g+b3T2+Zq7I5D4IzyXyktXsJGGLRShuV4hbZbbwo28fnvAC092ybNT4TbixnB6Vyh4TDu1rtPt0NgCKd5BWxeg7GqSHOLZuqHYLuhc8+3VYl8xi76h X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 26 Sep 2024 20:00:49 +0800 Xiang Gao wrote: > before: > [ 24.407814] cma: cma_alloc(cma (____ptrval____), name: reserved, count 1, align 0) > [ 24.413397] cma: cma_alloc(cma (____ptrval____), name: reserved, count 1, align 0) > [ 24.415886] cma: cma_alloc(cma (____ptrval____), name: reserved, count 1, align 0) > > after: > [ 24.097989] cma: cma_alloc(cma (____ptrval____), name: reserved, total count 16384, used count: 64, request count 1, align 0) > [ 24.104260] cma: cma_alloc(cma (____ptrval____), name: reserved, total count 16384, used count: 65, request count 1, align 0) > [ 24.107504] cma: cma_alloc(cma (____ptrval____), name: reserved, total count 16384, used count: 66, request count 1, align 0) OK, thanks. We should explain why we're making this change! The previous version of the patch had "To better understand cma area during debugging", but that isn't very specific. Please tell us the use case - why is this information helpful? How is it used?