From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28A1BCCFA18 for ; Thu, 26 Sep 2024 03:31:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FB156B00B1; Wed, 25 Sep 2024 23:31:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A9A06B00B3; Wed, 25 Sep 2024 23:31:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FC546B00B4; Wed, 25 Sep 2024 23:31:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4F8FD6B00B1 for ; Wed, 25 Sep 2024 23:31:04 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0D8BF1A13FF for ; Thu, 26 Sep 2024 03:31:04 +0000 (UTC) X-FDA: 82605463248.29.FC1FFDE Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf05.hostedemail.com (Postfix) with ESMTP id 31722100008 for ; Thu, 26 Sep 2024 03:31:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=S+GI6aJW; spf=pass (imf05.hostedemail.com: domain of qiwuchen55@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=qiwuchen55@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727321342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KCxZTZ1euyY54qbLVhSCXA9DvC9lVSXbCKQM3aJpPaI=; b=oI3ZlsNvYT0SZcPGFsMzyjE67MR70805JoNM6LHeir17yxb9FiCXVFW+i/1toVvEyDqhna FoRWgkpJjaLyVHGwpMTkYkBkwRvE5mcTQYnlvj8J/ogEqXHtpmfhTTa9zpfAyxDMVozprr mb4Vvz9ynv68z0YIRN0gDA7WqH+386M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727321342; a=rsa-sha256; cv=none; b=Ag5YRBtqO4kQ56TbTMeM1wP/BhaqFJhlnLwmeFSrCWskxpkLccuhBAC2qHxnD7cXLzk8C+ ct1MdERoLAPue/ZSvLJ8QZ91ugAIFSVNxLz8jmmKlqou5Nm5jimPaJjLAZsEv5+fXSl5k1 By0FzPQglHK13YYVYKVU+5SZnDxQXH0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=S+GI6aJW; spf=pass (imf05.hostedemail.com: domain of qiwuchen55@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=qiwuchen55@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2db89fb53f9so408652a91.3 for ; Wed, 25 Sep 2024 20:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727321461; x=1727926261; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=KCxZTZ1euyY54qbLVhSCXA9DvC9lVSXbCKQM3aJpPaI=; b=S+GI6aJWY0UlSLtw2rlS91Q34+rhlPUf5WjwaE6bib6gLzHS0o9zCE2FWX1ckfExPS 2B4Wz+VQYlQTcrui9ojIiDi868mvw8foNEJst5kMEOOXaislNIWHR1WMERqv4UIXibU+ 3qvwx86sDBf1+4Be+3Fs4oBg5K6Si6mcAjFQJNmq8shx6cI+4LQUmCb9wqHAP8X64cvo bsB26sGdHBFYi77LciT/1N9qe1/aqgoDbQ1zDVPofENRAJSNjtt4yMmrPUrw3mFvdnct m3nYYUhi/JhCCfNDJyTz+AO/sgTnqhlrRJjs5qAXudF98g1egB9AnFxRIeTt4cA1qraY NHHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727321461; x=1727926261; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KCxZTZ1euyY54qbLVhSCXA9DvC9lVSXbCKQM3aJpPaI=; b=pab/WAMT2lRxBLKlFz10Ghhxwzul67rmfBw9r6+9OVHqXV6NXnEeoqCLBQlW0GPCZL 40NsgBdNbkVMLy0pD5p4sGbcyg2XzUbc2Rj6Y7HdJMquGP5CRcPuRCfyc9vmDxf1P7xO En7O536HTDTw7wdczHAE8qQv+T7BCrIPgnCdE5glzvyjS9BJsyLM1spOvaiJibXp+Y4/ ib37Jwq7SWZ6DIsP1yIok6cOgccAVnULeOP4Oz8+QLTFdNpCGShieArqZySLJHXbZFcZ Estg0xHZlKbwnP210qW0ciKYbUtSrJ4N/+X2LIPQSBK3kACVjh1/+oEvSzGqTgbYP3hF IPNA== X-Forwarded-Encrypted: i=1; AJvYcCXJbh7lx9vysDwnSynBI+u6EzjHQM2oaOlDet4L6JWKNOEV9h2VYxcN1rjnyghoUDPVrs76NNi6Rg==@kvack.org X-Gm-Message-State: AOJu0YxMx67CMIikwXc9v01GUnxW6UYkIn1ojHOmKR09gIUwPjjoM2fP z7sd6DhJfKQk/xhezqkE2c8tLMfp7rQKzIzwTXzY+s2YWwxHyIDI X-Google-Smtp-Source: AGHT+IGQDwBefWrAFN11jrRpwyPnqaaEUT7c3ati0zWLQssXOQSb+CN5F4cnku8kK40cd8hznu3odQ== X-Received: by 2002:a17:90a:8c98:b0:2c9:9658:d704 with SMTP id 98e67ed59e1d1-2e06b005dd5mr4161010a91.40.1727321460651; Wed, 25 Sep 2024 20:31:00 -0700 (PDT) Received: from localhost ([183.226.245.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e06e1ae753sm2228130a91.14.2024.09.25.20.30.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 20:31:00 -0700 (PDT) From: chenqiwu X-Google-Original-From: chenqiwu Date: Thu, 26 Sep 2024 11:30:45 +0800 To: Oleg Nesterov Cc: chenqiwu , corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, paulmck@kernel.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v4 1/2] panic: add option to dump task maps info in panic_print Message-ID: <20240926033045.GA3811@rlk> References: <20240924074341.37272-1-qiwu.chen@transsion.com> <20240924113322.GA7248@redhat.com> <20240925082759.GB2941@rlk> <20240925121957.GB26882@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240925121957.GB26882@redhat.com> X-Rspamd-Queue-Id: 31722100008 X-Stat-Signature: j4wyredywtqp3u7nfyr3cn43kh8j1xdz X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727321461-13818 X-HE-Meta: U2FsdGVkX19B5+q7l3uYzwqiWu0/a3W9CBa1E/lsPwnNqOp0/swPUaofCTqyXEts/79fTuExDCFmIBrRtmLdvv1jj6rEUGAOuIuLwr4A/EmK6ptiLEvr0zpBOVkUpMTg6aiC9fzaQ/luKPNIOA8viOE4522C81/14yYDEiEECwSR1QW01UlLeW6bO2bppSQ/i4ajIR+pkLeWvZCfiuBFNuylwq5q1oayKF4fGoy72nGWwhpvOnxT3wSqUMWaQrwPPvEDhMD3jAYWmHjhMSZtzFR+WhIJWs+8vtCogdiKZJpTwmHigXOb/I87rq9oAGbxojaIvXa9PwT8jxnoEt1vDTguckHp4C+Jdh1954tuviz/ASqDzE3N3hjsaQT2+X1M/1hig4ivtnNodnVZWGpeXYA4ZbbXkbGzzFMCIoxXvTswwgQVNqAZ3EeLPBSGmtVWFrvAD0Npi6Z2HyEfz+/hle5QJhd561Mku/i6+kUOGcJ8tRsULQvMsDP8gWn5fi63JgFjSj8+wPXWSubgHooL28l9vghAzn0tUtLNBe9yiy8r8F1j4T4SOkPJVLu+6t9NqUsixfokpOi3dC4nypN/fWmfAtgCPgMv3CmEp2ON78VDwusLAkibUttWG6xIF+qtlbTNIPAPbG/rxMnK5Qf/6DteDP0hqpGucVGS8dR1RUKLRIrbCwzM3QTOBzIHEhrooxvxP8TCk4D3DSGWb34AbMZpoUQ7uJ2DRxZ49TmLXStP36+/0JBXuLAli6NX9BiPLNLJT3myjLBScOWevodp4fQpmbvzJ723fQzt39I2JIMGQGo0KG7x6Oi74jzFqmr4GF6CHs2RnVj4gn2kEWn1RiAhOyUWi6yDOanefIpcTS848m592L63yvEqDrEG9M9Plgj2nsTUu9YPdSnBMjNgP14p506fyIRNpDq6usxmTYhH867WqaVdX1TUqTaL9onPcL4hl3Ma6Nk4GOWXZt0 P+o23SWf QdDug2o5/7F6BNlEKvI6SWeNfyy3rzr/1i1sHFciuZG/3I0yDEs1pu9T0mtlotWWWPZOoQ3Qh9Yc/9oS9XZUsbQgp/9gr7nyCyOmvurMUb9Fo+5vWBSAaQg3pCo1EmDqzaXxNO3kGjwERyWdvxOG0Nod2bpUa1iRLO36dbNg4C0O4gOyg5WhYeL+mE1cU6kMMl1Mk9/1IHfzeNMZlKfZHyob3ri6j8vaO5RNOzNxH+LZhQiLgCKapO+bWfH7a/QkhpIkKl7+eJngJRosEZ/UtwinLVzYLR++uaRJHbNrRdKOiT3kS/LEPzqhkP7YndTL1JjdQyUBH6WQKn25Cy5i3X4dao5kFPZz3LzupuGKWvuFBeeNLFRgNqnJsvFIGFms+NYeG2nIT8zRNIeFLEWRBTTeRth2L0c5Wl9ooju3HXfuIF5DCoZBCPd27Ult0ok6qqzHS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 25, 2024 at 02:19:58PM +0200, Oleg Nesterov wrote: > On 09/25, chenqiwu wrote: > > > > On Tue, Sep 24, 2024 at 01:33:54PM +0200, Oleg Nesterov wrote: > > > > > > > + if (path) { > > > > + name = d_path(path, name_buf, sizeof(name_buf)); > > > > + name = IS_ERR(name) ? "?" : name; > > > > > I think this is an easier way to get file path name which deals with IS_ERR(name) case. > > > perhaps this needs mangle_path() ... > > Sorry, I don't understand your reply... > I means we can dump the file path name by d_path() directly without escaping "\n" by mangle_path(). I try to test the patch in arm64 qemu, it can show the same file path name as /proc/$pid/maps. Thanks Qiwu