From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F87CCFA13 for ; Thu, 26 Sep 2024 08:26:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B9036B00B1; Thu, 26 Sep 2024 04:26:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 568C16B00B4; Thu, 26 Sep 2024 04:26:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42FE06B00B6; Thu, 26 Sep 2024 04:26:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2B70E6B00B1 for ; Thu, 26 Sep 2024 04:26:22 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B944414058E for ; Thu, 26 Sep 2024 08:26:21 +0000 (UTC) X-FDA: 82606207362.02.170786A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 06D69A000B for ; Thu, 26 Sep 2024 08:26:18 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=FB37s9Nf; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727339045; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NzBJlxxW/MYL1o2nGqNmFKjCyM1FdohUNHUX/hfrJ60=; b=v8hJsAdtzTaq0m3lMnu+Qq2Vu20GSnCYx3IITt5kuypXn8L7t0JyUoAVOWnBPbYrkKxElt 97ujQSmP4S4cIO0DSRp7ZzomBgfEszGpc45PF81TKAoZiTIMDHQsqgqgsY48S4OQRsyHPM RmsvNsUDuQIlPcjwZ2snKjLnBaKMBIE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727339045; a=rsa-sha256; cv=none; b=u2ulFHO5NCQEAaiwXlC2CqXZDfkwB/O6GkO52rtaeKFqpm9tpdq9QNfLdtKRV/BU3dTPEt LUNyaKL/wkK0vBKIHbvBI0JDvUW5GFVrRqeNLdBr9AcXzKz/+Llk/VrZfwHbLCOGrgkjuT llwMRvIw+0tpxFoZoheIi8agY5BNaFg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=FB37s9Nf; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E5C915C5EAA; Thu, 26 Sep 2024 08:26:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D95C9C4CEC5; Thu, 26 Sep 2024 08:26:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1727339177; bh=ieSjn7eGJQi1Ofr5bhV0UVau9UldQEjlxk00g/CD90c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FB37s9NfypzXVwr34K5o2rx+p2KhdhQh+xjPlclXdyLYsUVFOI2StPmEyHeUDuzbb TyIOnzjylOXqA6zQfQn5wffgtwrnt/XiYYiLd5uIJB8aLdjv2IqbHucMfc8Sv3jQPn sgNjct5HzFyi2DwUl2pXEbJWW0UmXSXkms79h1mc= Date: Thu, 26 Sep 2024 10:26:10 +0200 From: Greg KH To: Fangzheng Zhang Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tkjos@google.com, Fangzheng Zhang , Yuming Han Subject: Re: [PATCH V2 1/2] mm/slub: Add panic function when slub leaks Message-ID: <2024092602-porcupine-pacifier-a795@gregkh> References: <20240925132505.21278-1-fangzheng.zhang@unisoc.com> <20240925132505.21278-2-fangzheng.zhang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240925132505.21278-2-fangzheng.zhang@unisoc.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 06D69A000B X-Stat-Signature: k5k8ufb3gsjkgawxenzq6ei7ob9smn44 X-Rspam-User: X-HE-Tag: 1727339178-981364 X-HE-Meta: U2FsdGVkX19SObHi4xMHvaXCEZUSH90Nx2YgdkSjDSJxwp0lXuef9/5cedAz1zrgcXnVjqaAsGPwo6P59itLRl/2TbPE2pqHgYuXUDBSVJZKjjRVYxQA1JrlSymCEalep12/X1tWkrLLMG8zmC8SeO7o4mUx5Rrq7rVzNMaTkdDS2UT5pTXbOisX0o6nJipkgzN1mxSQQsCi0il77NlRxmWUrk6VCJoNss3K54AT30w4RMgwUvCJsRKCjg8NriJ9Z5Sr6iFUgfxwpz1PsbxRjdRkxMPMJLcjm+CMnXjvmcoozX1bIoSOVboZNjdRsK4d/Nga9AOLcoSkmsPBeJnX1bqCE5GZesLWC8lZALx1MkDGJn1NeenpiKel7t6Hux2Z50SmEdrnbEwn8RVoj052jclQdDsJCLcJkLrUw/Sw7xgnUhjCBwJoBSgDFpYX55PAk2jGEeIYgmPNCz8akmEX2o/OjHzypV+fszUcxf84mD8ghsasqMYvEmCXEM6IjjVSxOnf4n/anujRhAMZ4Sxu1L/1+Dv5D1dItMtlz3ERfNatXEHTwxz4K0upNvKfh6iaPtC7GoLzENue8ya60+kyoWj13FCH57hkvm3zSDTVnsvlN4/WAzVmbsG0eMEBLetuGtnR7+eLuRnqS7QayOdDrNuIvLb1UjRr7z+BMRtL8e0C3lhr1X2HAqAfO5RJrrTAO6c0QZ82vO2TwVv6JYmO6gaD0Qg6m9SEW+sQb3NOmr/Hd42Miowy+2vWudCBC82/wmOBDZ0TNDb0P1Rom9mqm8H0cMDKP2mdw4OusYDh6GXKKTnaEGxx2ob2o/bz0bcMhfeWDy1NMMliwrlkkKXncZN2ljITZtFpANeF7icz1Lcm7CAT+SvpinOPnLMeB+YyoZ9XvzhiATFJcoHcA15W0HG5z1leLOxmyYPHz3ty1b2zpsiaIytJbkYWYpsiaca2ctm/6kqFfKCr4Exsxox JCyyr5n2 bsz+QNy7NVprxZXlS9w46jZcSw5y4T+UptoxIah0/WW3L3ByOplFQ+wEUmmF2zsL84CKLrYDc6WvWd6umRbZ3x36FB0KT+wy5h/NtO/3UBTakTWzxM7JPcBqKbUOE0xQhnA9KaeL8DquC9Eh+pupdI1Hy1vNO4kyy9vJz1jnc//lOvttcmHO+DEORRSKAufDvvX/WH+qXhuMwTaWUb2ONrWiCrM+uXmkGHiNHop7nVcIjPk/MjiK1FR3nSXZDFU0gwiCes94MvS4R//Yk/0RG3R0V3KW12q8TTOFX8bMwu9eFa3+OETV8GqCq8hybiIMq3ZaZZC3eOBIzR6nDvSXEQ6gnV0YgBeUn5TCULZelAI4CsktApVEz+zEafwAG0jHjfxkfSQSkuo7mmvEZywezzwhnKQs+0JOzeXJyvzslQm3lmamT0JbCApBinXIHN5AjQQ3DnD3i1kqJ/M0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 25, 2024 at 09:25:04PM +0800, Fangzheng Zhang wrote: > Perform real-time memory usage monitoring on the slub page > allocation paths, ie, kmalloc_large_alloced and alloc_slab_page. > When the usage exceeds the set threshole value, the panic function > will be triggered. > > Signed-off-by: Fangzheng Zhang > --- > mm/Kconfig | 11 ++++++++ > mm/slub.c | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 86 insertions(+) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 09aebca1cae3..60cf72d4f0da 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -255,6 +255,17 @@ config SLUB_TINY > > If unsure, say N. > > +config SLUB_LEAK_PANIC > + bool "Trigger panic when slub leaks" > + default y Again, only use "default y" if you can not boot a machine without your option enabled. That is not the case here so please remove this line. > + help > + Detect slub leaks by monitoring its usage in real time on the page > + allocation path of the slub. When the slub occupancy exceeds the > + user-set value, it is considered that the slub is leaking at this > + time, and a panic operation will be triggered immediately. Uers > + can enable and set leak threshold by using the kernel command line > + parameters "slub.leak_panic" and "slub.leak_panic_threshold". > + > config SLAB_MERGE_DEFAULT > bool "Allow slab caches to be merged" > default y > diff --git a/mm/slub.c b/mm/slub.c > index 21f71cb6cc06..a0b514626de1 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -42,6 +42,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -218,6 +219,15 @@ DEFINE_STATIC_KEY_FALSE(slub_debug_enabled); > #endif > #endif /* CONFIG_SLUB_DEBUG */ > > +/* Internal slub_leak_panic definitions */ > +#ifdef CONFIG_SLUB_LEAK_PANIC > +#define K(x) ((x) << (PAGE_SHIFT-10)) That is a very bad macro name, can you not use something more descriptive? > +static bool __read_mostly slub_leak_panic_enabled; > +static unsigned int __read_mostly slub_leak_panic_threshold; > +static long max_slab_count, temp_slab_count; > +#endif Also, again, please remove #ifdef from .c files as asked for before. thanks, greg k-h