From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 143BCC369A8 for ; Wed, 25 Sep 2024 08:10:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 830C76B007B; Wed, 25 Sep 2024 04:10:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B9126B0082; Wed, 25 Sep 2024 04:10:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 659896B0083; Wed, 25 Sep 2024 04:10:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4391F6B007B for ; Wed, 25 Sep 2024 04:10:29 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B53AF1604CF for ; Wed, 25 Sep 2024 08:10:28 +0000 (UTC) X-FDA: 82602538536.30.2FAE80D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id EF8411C0007 for ; Wed, 25 Sep 2024 08:10:25 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="vb/wc29v"; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf21.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727251810; a=rsa-sha256; cv=none; b=lpEtFqLoIBO0y9bstyY7PG/GQm3KJ5FO/RL7VNgM31jFcuBoVwvAcnENLpxRoCJ1e1plhJ 3FLBuz+Sv0Mz1OCIK1cjv/vHya/GTSrctCbNYapnFWya91EtF+AVcWOaRn5RKvq+fRzpW3 rTyFNDzNGDOD5vyh4Vny35ktUzE61rs= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="vb/wc29v"; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf21.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727251810; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9/ZAZ64nzvhnqmg3V5Ri6AKU8S57Tdfw1Iv1ib1e060=; b=WXiDffcIKuiTSkHKNzDJHXXuxIiLFTsMoIe/64qjQjMYIL8U2CCpHIAzUnelp5cBU3Sd8I zxER+le3TAg1wPkhkO0JYzfWo5s02aqXmnbTQF5/73XkpJ2jVsPeohzWc7Z+Yd0IzEmHWR 6FPzKIAvXt7VfHpgj4tjkEDIgTXLLAk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E24185C0533; Wed, 25 Sep 2024 08:10:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A254BC4CEC3; Wed, 25 Sep 2024 08:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1727251824; bh=3UeFz9qhVYZ+msdty2CcdnWbTrHFD37IngKHjDdyUxU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vb/wc29vkbLSgiYt6jqcUMFFfmKBzzNsXq413PvO74HvAFk30MApVgkmfgC9QTq+6 fuYgFpTsLYvBYZu5IJuyq4wBjZS3JwJYtmWExMB423VtFgS3X0hGgIIR61xiibZa72 hR6GXWVb5GtO/LVwZpuuZA8iD7pxYbfoBbm2rU8c= Date: Wed, 25 Sep 2024 10:10:20 +0200 From: Greg KH To: Fangzheng Zhang Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tkjos@google.com, Fangzheng Zhang , Yuming Han Subject: Re: [PATCH 1/2] mm/slub: Add panic function when slub leaks Message-ID: <2024092556-tribunal-next-84ce@gregkh> References: <20240925032256.1782-1-fangzheng.zhang@unisoc.com> <20240925032256.1782-2-fangzheng.zhang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240925032256.1782-2-fangzheng.zhang@unisoc.com> X-Rspam-User: X-Stat-Signature: 5xrj1gs3bisj15cxdwyx6oc5cecufqj4 X-Rspamd-Queue-Id: EF8411C0007 X-Rspamd-Server: rspam02 X-HE-Tag: 1727251825-640977 X-HE-Meta: U2FsdGVkX19MjHyKfo2sJhN3x8jTq8nsQGZPJSq59Bmx14CWDQMoLvl7BVc7skoxjHmj47oScS/hxjUlfl6JE2FYY0u9z56J4xD//sZiDFATN0K2SBNuVsB0n5CdoJdE4qJQSfJNBbBYsxCjg4z4fKdymQeiz5SN6KcVMSg9blam9f6X9sjdwL1wabAAEHqu8RNv9y/PCR3EOyvXB/SKui1WWTl7Hwpqg0FGPRhDD0+A+/gGdE4JqzIDVc5iImgNxjY7vc+8z7hd2Z3+wDcEBSyGgsRfgdnPObcB+BtI+lvhR8M8co9rE6QJtcMbmsq+iINoH1YK+FU9/FnWrHdALHksbvGqn6EDlzT8pGMA6PWg7SHxV5Q6Ar/sTgNnqw0FtUi9qzghjaMaDHXN3ifgTIHIor/6U4zOcp3sVZUDcsfCSDKBvXL93d0LKX6X9GVVdqzjTEAjcIs+CAIKKPf0aRTs07PgeQ1hJXOigaQV/lSQX6Ixpcheomz0TG7wip1iOnCsblJHPbqP/i61o6N2CmMfyXIuPkCxGiNCDGsnCSW6g8zG10Hhchj5AEW5aElGvgKiRX4xqH9e3rqn7vB/RzheODAo3hvbJu25e4zCtgrqZFAMZ8rSo2mPnwMoQC9+B+gJ1Ud0noX7PiMlN74R2zTOA/86hVbLhGst8qxZjSXI2vNVS1M5nBojtH5Ot8IJV2CIZ2xW8ZIkxlX8/yZ9eg0gREOba7cHOad0Wuhrzq1McY6YDkdBp/d3K04LHoiGIX2zc+QmdJd8Ec6tYLAMviaiqtV18BKzoLkiDTklAgQIRP/N1PzZxRfKYgzdgU1/AEz4CY7ANzVMn9Sqk/g8zhV4YKfh6FyaRnDXTrfQXwZYHiHNloYBdFBGmlm0uYw1ZbVsHqYPAB3dA/EVi4YRmUUHQ2S/48u/E4JYHL2b/O0toH+YPubeHAiKNOm782hx106g6yTI1Qr3OF/HO1W anU8YhRF oWVTP+PH/qx0GoqtI5kv7A3lsL8EUHfNZXoXwDuCqV19kfgZw0pfuJR/4a0bbE1jqEfvyzFkNxHGj6pe7mXPN6Sp8lIwKYJ722aYHeJy0Hu7GMKGj0+2SFQ52DV/aPrQpSjt+xeLcSlPIXDdwK5DXPhLABbNlqSJ3X7SLoZTMy5xN9X4Nv5To2NRCqvpnOvDEaeLlCfly2Rgnra+M1xkQC0isHYK6EskfdHRnTNb4j8ixr6yXEYCk3WVn2FT18+09MKxwNo5uBBcYsIEBzx0MDIGiQiI8Nvh+ByKfWG2ZK2Ay+Ib1on8xHz5zLjQRIzwvP2lDA80s7xEkl/eHEzQlLITHzm1lrYGoSaFjcYEcqXdLN91TnZw9Sdm24dzw87V2/ZaurhMSyBjbbClEMEJ4VuCtbkaBgWwEminJG0xl9I01iI+pnDduQMWSS1GreLMd9SUOQM3XY9pnaFM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 25, 2024 at 11:22:55AM +0800, Fangzheng Zhang wrote: > Perform real-time memory usage monitoring on the slub page > allocation paths, ie, kmalloc_large_alloced and alloc_slab_page. > When the usage exceeds the set threshole value, the panic function > will be triggered. > > Signed-off-by: Fangzheng Zhang > --- > mm/Kconfig | 11 ++++++++ > mm/slub.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 87 insertions(+) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 09aebca1cae3..60cf72d4f0da 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -255,6 +255,17 @@ config SLUB_TINY > > If unsure, say N. > > +config SLUB_LEAK_PANIC > + bool "Trigger panic when slub leaks" > + default y "default y" is only there if the feature is required to boot the machine properly. That's not the case here, sorry. thanks, greg k-h