From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 473CCC369A8 for ; Wed, 25 Sep 2024 08:10:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D12906B0083; Wed, 25 Sep 2024 04:10:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9B526B0085; Wed, 25 Sep 2024 04:10:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B42016B0088; Wed, 25 Sep 2024 04:10:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 90CFE6B0083 for ; Wed, 25 Sep 2024 04:10:57 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 42C7B1C6244 for ; Wed, 25 Sep 2024 08:10:57 +0000 (UTC) X-FDA: 82602539754.04.2AF0672 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf15.hostedemail.com (Postfix) with ESMTP id AB123A0004 for ; Wed, 25 Sep 2024 08:10:55 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=nqUtiHKG; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727251794; a=rsa-sha256; cv=none; b=vIVoHIiCPS5NCzyKdzg0CfsZOGKr0SA8tWgbygZkYd7+Mn/BtMB4mH9BIgtZDamC+aDyiW Xz4oV3STFPGdJzRiejTkqzGGva79/PhttXbSHV2ulRe0hTp1yXW1/yWQI3dX2qfdFkYVcH riyudZbIx2dT4f7oeDHQ2HBpeApiBBc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=nqUtiHKG; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727251794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nV+QLHJMgBOHVnbf0MIR1PpE2w4rk2Gwm8T3T39ViZ8=; b=g8uFrKhfgxNwYVAKxRH/QKZYmejenYF/7QxcAUNIu9dkp7eOi9k51WpTICkiOKPPdR8/lz c0YCFaEY50GpADZvD5CMVBsX9y8AuFrSlwkkfUmwVas+lxHJ/ne/iv5F7TRSJvTKoaEKI3 yBCYzUUmAhqSYi9EyWshpW1wgdmJQ2A= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C57CBA43C62; Wed, 25 Sep 2024 08:10:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 044D6C4CEC3; Wed, 25 Sep 2024 08:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1727251854; bh=UzK291mxXxbkbGh766qf/zEd99wtKZEiO0xk+CZ/uh8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nqUtiHKGIYRKEszWIETKHucQ1UCh5d3MVzEDwS2iZrR/UIaxIggYQWrfnpPm8TRZG /m4gZd1jPWaP7jMaA2LZ0kXVrziZupv81rWSfQBN4EwpK6ywpeY7i+ALy2bjouMKRc nYfaUIKL3jHSXte+aMFPs5RoQ0JCAQyxRPbIFKTA= Date: Wed, 25 Sep 2024 10:10:51 +0200 From: Greg KH To: Fangzheng Zhang Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tkjos@google.com, Fangzheng Zhang , Yuming Han Subject: Re: [PATCH 1/2] mm/slub: Add panic function when slub leaks Message-ID: <2024092528-primp-ogle-23c4@gregkh> References: <20240925032256.1782-1-fangzheng.zhang@unisoc.com> <20240925032256.1782-2-fangzheng.zhang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240925032256.1782-2-fangzheng.zhang@unisoc.com> X-Stat-Signature: 8tzc6cktn9ecepe3pnz9snztnm4cw97o X-Rspamd-Queue-Id: AB123A0004 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1727251855-12066 X-HE-Meta: U2FsdGVkX18MyBKDCq8L2WESd3O8mB5W8KCk987ZDM4tVAdGShL1G5hOMJodz0l8qW7QDek9sIXwVl3mIlEzSG3aCAeTC8TI5E26NVivti/hwBdnOLDQs/Ec46K8jablbWThP6SkSLbeSradwmsfLhxi4XRTdTHhtXzRDwqebFEgCIPfjIHZ+ifvgRgLuRFwnuoJR+E1aNmcaKraZiPXqwtr9TmoW+m++z0A92KZJajO80vRuexeqF9zTXzSi69TonPM8szkteuabNwbuqRu7NkxCsYfUwG1tmard++OeEbFtRZu3vJLAeQFtgtLhuHBBx7RlmBKWxrDv9iMlmyqFIk5JvXCj1wl9xZts0/as8Gr7l3fB7By4Q+4Xxw3pwHQfAoMWqmbgHC2583184CF/a2ZjIddFeXw/tFaKBMk2rVhe4TabV4kr28i4wjOHLq0o12JC9q354YAwj03T7D4qCt4eHTdCwEXqeHP1xmnH+Kyin49dZZP7J47mvHnRcFSriVsl1qB6n7zOEXkwD04pw/bXTB7EwEWsDKZMqhfvsoFvuis9xpTkzdjSx9SiW4qPOZeIFS2ctjZ4g+Syt7vOV54UFsBnb2fH68BaJ5ZTAVfEcwGivBId/Gw/jwX8giDlyuqX7aUGBgtCAZ3gfWcjBybz97BvZZ6VZZrrnOpjwMU3yd3HNNNd9CBgiKpH1tI9qxcnD1Yv+gUPiMKng8S5wIYv4iquNFiWOHEpQnOyGo6NNVdgh8/0liP9cZTpoBtypsIbXKXGx50ZG/wn52zZDJtU4Jfqbk6i0H67/BchSDxWVSwzoyThFE/n6bgF3/DvDIPAj72WbN+c/h41RNWNa56xhxd/pLuTBVwXe+8AB/S1QedL3NOStnCAVwuWIMtjUDqqv6QzJOgzr4ECbkFAu0M1epG3h56DzCU/IeevQdV7OpTJmoK288Q9azqHGgKaLQCfRFL7RfbC96+N4D P2jClaTs Z2Q7LBkVmdAsZvGeG72FQW+TMvXxblE6r3qg2WDmHPoDQNRdVdpH64aXcTyZ15o0WZz9yOCgGtEdmlgzHHrLwYxaalYx67pu6fHV3H+Y1f4j8RgLRgK6N1nEkaKYmgtXW1/6oSheMg9/MJOeRlaKLexOB5VfWi2Cn5hgF5rOWSG9LfMfcRj1atDHOc7SweWL2FdGaxYQQ6a+O5isl4oFca2FQZ4kphp2JFeWYQpXS23z3K1L7bYciW0YIwGEDcMnHzkdsFQuSq/KW8zUjQUnNBWAR2AgB/UAaCImNgrMJ72cebi8VD+ObIDW2cnigv6E60yAcE8TnpGjk3PeXNiEpqHR3SaGJjtO+V+XUp0t0QlVpHd2qsZBcIa4BrYZ2vDEMZKrKuo04nqLiwWiqm+5dvbsnR1gvzixGR9R7OcpGiZdllaHqXSZK0jMUQLbz8omKFulc411hAzZYAJanfjESXJPCmNlXmsiZXn7AyptuOUFsLf8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 25, 2024 at 11:22:55AM +0800, Fangzheng Zhang wrote: > Perform real-time memory usage monitoring on the slub page > allocation paths, ie, kmalloc_large_alloced and alloc_slab_page. > When the usage exceeds the set threshole value, the panic function > will be triggered. > > Signed-off-by: Fangzheng Zhang > --- > mm/Kconfig | 11 ++++++++ > mm/slub.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 87 insertions(+) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 09aebca1cae3..60cf72d4f0da 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -255,6 +255,17 @@ config SLUB_TINY > > If unsure, say N. > > +config SLUB_LEAK_PANIC > + bool "Trigger panic when slub leaks" > + default y > + help > + Detect slub leaks by monitoring its usage in real time on the page > + allocation path of the slub. When the slub occupancy exceeds the > + user-set value, it is considered that the slub is leaking at this > + time, and a panic operation will be triggered immediately. Uers > + can enable and set leak threshold by using the kernel command line > + parameters "slub.leak_panic" and "slub.leak_panic_threshold". > + > config SLAB_MERGE_DEFAULT > bool "Allow slab caches to be merged" > default y > diff --git a/mm/slub.c b/mm/slub.c > index 21f71cb6cc06..91049f87ab98 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -42,6 +42,9 @@ > #include > #include > #include > +#ifdef CONFIG_SLUB_LEAK_PANIC > +#include > +#endif Please redo this to not require #ifdef in .c files, otherwise it gets very unmaintainable over time. thanks, greg k-h