From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6485BCF9C6F for ; Wed, 25 Sep 2024 14:11:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF6476B00AD; Wed, 25 Sep 2024 10:11:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA7656B00AE; Wed, 25 Sep 2024 10:11:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A95996B00AF; Wed, 25 Sep 2024 10:11:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8982F6B00AD for ; Wed, 25 Sep 2024 10:11:08 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 16EC5120D21 for ; Wed, 25 Sep 2024 14:11:08 +0000 (UTC) X-FDA: 82603447416.21.655A013 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf17.hostedemail.com (Postfix) with ESMTP id 0A2274000D for ; Wed, 25 Sep 2024 14:11:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="bNaXJ/Kp"; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.181 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727273306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0HqqYimt1QxZeVkOQJVU//HMfOibhD9+jQu/EZc2E3E=; b=Ka8UsjfddgYMx0TZGbJr95qegoqtaU386ri6auAeRm5FRiOnLOymai2lYiD0lQyt5tnIT+ kSBlzEJ5puidMras3qfFc7ITXG5+pmmNJoOa5mTKWyjw1ZB2nLnpRm28+RU0epxAsyk5Yz Am1zm5j2rOVD6IU47JaK+fFaQMtYZTA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="bNaXJ/Kp"; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.181 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727273306; a=rsa-sha256; cv=none; b=yo9rFyPtUG3M1s4dVLOHRMMSEHIPXjO/GXr6KQhuVVmY+HWYhOfXJT9GfPYLXsmh5yO9+I PHOgmJVLEjqoxiONEeLu+hAN4P1DkC+qdRNPRoymCgl9oT+avmuiv6ED68xnChoGThwpha oBuI3Wf1Ev3AUjzQo1oPKesiH82K6QI= Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-45815723c87so8315761cf.0 for ; Wed, 25 Sep 2024 07:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1727273465; x=1727878265; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0HqqYimt1QxZeVkOQJVU//HMfOibhD9+jQu/EZc2E3E=; b=bNaXJ/Kpr/jklrVBfv6ZbECpNuFLAJfNpgXTm5UsG0leB8rLaiOgG/L7lI03A9ctqY 92ve6PbdpP9OjSc+C73S83MowTot3DuFTBAqyE0B6TkjebacuETeFwvvAsX0cRnrcvH0 WMUjD2b9MajAAPvRkBi0eTYbvdefdLdCJ4lItg326g2TI1j+0MQJzzAjzNiSthlYgI33 TVlY2mworCdkJlHGRyHBz/QhWwglI7+CMcH0xvL1mRsev3u528hZoQ2sl/RCnnU2MBXX 3dhY2y7ZvZLb9Ven+41VLq9nn/3sFuVG5kX8qnEFl/qyb50TZSIsQve8bmzdwF/jC0i6 PfjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727273465; x=1727878265; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0HqqYimt1QxZeVkOQJVU//HMfOibhD9+jQu/EZc2E3E=; b=Ci1Zn2Po2OXGQfeGo2Q8TtNvYubOLtxtX9cGLUhzmivs3P9nFMCEKGzP37ZDTSEViU j5+335btLsGhwDFcQ37zAGkm8A07cFRyZnC0WwqC5snXfimlBz4vhn8z14HiEl3GId/E 4tvWoYRIy45aJIZQaO5uFzXQCrpMRTnXHGu18xPC2fWpr0Ty8EFMOl3UH8FB0oGmnoiv U+F03LeH11u7akKtLobvM1QNcz6PX2eWlZvB8c8C8paLNk64D66xqMFkfz9+10swUIr/ U61Yi03Tqhq4lMePkxKRcvvAjhxqAXDhxJNWZ+xgx6ipC3+q0UPLGZA+u9xOodgvZz2z ypag== X-Forwarded-Encrypted: i=1; AJvYcCV0XeMnHiatvzFwAWr3m7/3eTDMshzwDObAd64ABR8pROh9acf22LjUAy3/gO6lXqJcfVKbe5Tejg==@kvack.org X-Gm-Message-State: AOJu0YwzpOi0fbka7angH6PrQ4ER1E5yNTnR25WSB917Nzjh4FkKN6tg Ovj+3Niujd+QTPtKxOd1ysXIR9uQUqRfNg/JVshIm0OeSipT8LMzh7xRB29wpgA= X-Google-Smtp-Source: AGHT+IEuFnOI+QoqaIzFOoubbDZyeNUkTSvIM7YU7oUFKsxL5yCIUFokpICLD4x4Uhi8lw04gcfKJQ== X-Received: by 2002:ac8:6bc9:0:b0:45b:c5fc:502b with SMTP id d75a77b69052e-45bc5fc5271mr22616421cf.17.1727273464788; Wed, 25 Sep 2024 07:11:04 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45b525953e9sm16585421cf.43.2024.09.25.07.11.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 07:11:04 -0700 (PDT) Date: Wed, 25 Sep 2024 10:11:00 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: "Sridhar, Kanchana P" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "shakeel.butt@linux.dev" , "ryan.roberts@arm.com" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "Zou, Nanhai" , "Feghali, Wajdi K" , "Gopal, Vinodh" Subject: Re: [PATCH v7 4/8] mm: zswap: Refactor code to delete stored offsets in case of errors. Message-ID: <20240925141100.GC875661@cmpxchg.org> References: <20240924011709.7037-1-kanchana.p.sridhar@intel.com> <20240924011709.7037-5-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0A2274000D X-Stat-Signature: h33wpohj1iqjzqa9h1gn9rkmtcpxi8zk X-Rspam-User: X-HE-Tag: 1727273465-665924 X-HE-Meta: U2FsdGVkX1/PkQ2dXBIYW8fDBP+/kD98wVWOeb4chL6cytkR/Cu0sQwCb5I0NqEc+gcD8z4oCLgYlYuDDkkoe00G1n3bG425crISjp3plHy/DI3a3bxZVXUF7bJKj9niCs2nc1XVOlrjAMXHCGQcyRMINf3XFXkX3dUsFXwrqhXXYdOyxNc8Av/bsMcRWvl5pwJdKvpXvW3NrrEBlXh6sHjCv1ZFn/SSDgsuIDNwgF9JW0NfvC5UTqjJyWCjeR1XHEFeTXfgZwoRR9FuPTKtQW8KjXULAyy+KVYMBiouLGoc2Ac5OalKlfQky6QRo16G66lcWwrPHI7vsVNzUnnU7ljLjP8pkzYWDBs95JHx/Mnc3v+iwKIxfeCghdK+7UBn6DvvQJ2d69UiToExPMJVy2Fn9CEyjVhObNGGb5fCOyzZDhZCQcfvAXZT4pXpz8PX19TcIJaStStFdytPItiPvBmljMabydNHT6GaQZE1+fr56rpvotrGBs+nlVJxAUMrzoJ+TGBoKYMYg2XHgDUstQGyDYQm6vtNdowAQhGhrugTcpPveY6dF8PWD1NddZMOA4F1oHV/YgVSRQjxS6movKrWhg0pegpuLNwJZkRrKaNTjprZDplGq0MeKcK24b6CCtF7PGnkRhZdFCf0W7IKMLfwjaMQox/g43ud7kRY9yHCB5K8LyrgJdZ2Alj38H+3PwcwE5K+aaZYT4rdO/vs4kXmc/iHDcT19ZZWF07kHDwuk7zeQJsJm68FhWxTRNYA0fHsX5l5H9R+x/9AeuQr/iH5ioHNHZrFqxFg4DhPaTX024Ow13ZNG71aDNeg1NaggQsxaANsMqF4XG2gLz7AywbsWuWakSQCNh2FsVNrUiP9SLOKFsJcZmewBGIhLxZ0SvjdL80ZVnmb/xVqOb9YrhZ0PfwukvYZcgQyH+8gvQDFp2wYopw4kXygw2iWScX69zRjEhmOX11KOZGEjU8 VFUNvJrE 3NetItx/4XYqaoIEX6pMsG2ybQ4Dj8X2QEQkNdZuaa+T5cOswedCUy6c3t/ut01srJaniA6ClHj5H3tGwM4lZ5Y+io2mrpWEA9zRNjMfgU4GqoOxZfTA4QrkJ4Tfwpnp/bcpwHT+Ue9GMLyKxWXHgPQiZ+aJ6mRGpfJ249lWhcJlQH5Cma1admvnSDxpj6Atg5+gG2ifKVCypHK2ODT42iZab3Yts0/ZycBlLBme0VTbP7L+b8QrNXpkrdem+lULmBlAJun/UAIN3BZm5qiByGrwjcIrQstXD3xJPBAl+7A7w4R5iaSDNAaE3cOLA2BwPYy2z61wEiRebfDp9DpUQC1mD43vskptQxwefhkJSSIiae4uNRtRRHNh01+XEMU5ufiR3R6WxPyNkiUwnD12QrSJh/MsThn8fiu4nwJe3S00sT9wWNbTsTu78D91DBfsmAyVdiOj/RjnrASO9TuVUFOWAAwJ7Lq4SdGz/b/FxQZTj//5qppt6+Jg0OZVL3kdD1n+5JLeGGP7JUcyQ3YqIfaF6tO7G6oV/AirXgp5EpeAyCCY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 05:43:22PM -0700, Yosry Ahmed wrote: > What I meant is "zswap_tree_delete(struct xarray *tree, pgoff_t > offset)", and loop and call this in zswap_store(). This would be > consistent on looping and calling zswap_store_page(). > > But we can keep the helper as-is actually and just rename it to > zswap_tree_delete() and move the loop inside. No strong preference. Both helpers seem unnecesary. zswap_tree_store() is not called in a loop directly. It's called from zswap_store_page(), which is essentially what zswap_store() is now, and that was fine with the open-coded insert. zswap_tree_delete() just hides what's going on. zswap_store() has the for-loop to store the subpages, so it makes sense it has the for loop for unwinding on rejection as well. This makes it easier on the reader to match up attempt and unwind. Please just drop both.