From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C262C369D9 for ; Wed, 25 Sep 2024 12:20:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 930DB6B008C; Wed, 25 Sep 2024 08:20:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BA246B009C; Wed, 25 Sep 2024 08:20:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 734506B009D; Wed, 25 Sep 2024 08:20:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 56CC66B008C for ; Wed, 25 Sep 2024 08:20:23 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E7895160D11 for ; Wed, 25 Sep 2024 12:20:22 +0000 (UTC) X-FDA: 82603168284.06.4C4F756 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id EA628100005 for ; Wed, 25 Sep 2024 12:20:20 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EHUhZWI2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727266723; a=rsa-sha256; cv=none; b=cA0sK8kA/KBBvXUOUiSIEcy4cBkh93ciqfaTZvXxIddMgZHbIsdhkhjlZtj2IV8vxN5uHw Mt11qLJD2JdSPgFBsJH0qh1RWJuz2MxsSjbd2gEDzPbIxY1a3WHulms3Fv7egLlAHDLw8t cUUjX0fJlzfEq2UPwLqkOIvvqxGmDvE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EHUhZWI2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727266723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iTJx4RvwFxfTOCwvhdIaY07N/0J58vt6GfX0pwiHMqk=; b=RTbtdvCsD8TougfOyv92s4ipyvzeePFc1SQavSvhzGvYlECdWS8+S28g7NyyJGat1ODDhA /JQD+B68UQgmyuHiHHQvLAlRcFFd2lYX/3ZltrWuaQjHcA2j/5z+mv24dmwY7dTan62+vq aIGXp5hP5qWXCgEXwMdgGFmQElQzphc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727266820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iTJx4RvwFxfTOCwvhdIaY07N/0J58vt6GfX0pwiHMqk=; b=EHUhZWI2BOS3Bb6XBRdZZcvSaQKFZB+UV40B4G63jeUMrUyZonKR8bnyvNBRzL47JuY/ch gjADTT5uqPV+1EhMh6c/oQ9z2fAEQ9MPvYfySGDY3IzCpq1CgWbZXIRoO5W4c1Gr9uCzby dVGK4NENDc1ykt6VUYnHza+xBI6AOLI= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-UjlCmDMoPYWUw4laE9LiUg-1; Wed, 25 Sep 2024 08:20:17 -0400 X-MC-Unique: UjlCmDMoPYWUw4laE9LiUg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A959B19367BC; Wed, 25 Sep 2024 12:20:15 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.225.67]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 491A41956048; Wed, 25 Sep 2024 12:20:11 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 25 Sep 2024 14:20:02 +0200 (CEST) Date: Wed, 25 Sep 2024 14:19:58 +0200 From: Oleg Nesterov To: chenqiwu Cc: corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, paulmck@kernel.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v4 1/2] panic: add option to dump task maps info in panic_print Message-ID: <20240925121957.GB26882@redhat.com> References: <20240924074341.37272-1-qiwu.chen@transsion.com> <20240924113322.GA7248@redhat.com> <20240925082759.GB2941@rlk> MIME-Version: 1.0 In-Reply-To: <20240925082759.GB2941@rlk> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EA628100005 X-Stat-Signature: r3sjddob1kxdnsc5449b8uumjf1g8q39 X-Rspam-User: X-HE-Tag: 1727266820-982435 X-HE-Meta: U2FsdGVkX1+F9Dk+uOQ7pK4YBd2zMioqeIuwsuROOleP6wbiiNWO91QhI7siHQrmmKeGGWjQRO5iBXJ1JcW1Z47hbp/eVl+VJAGKRxI0Ael2TM+E+dvJ0UBwcuPC7wO9ag0piEystc3CJbVzUGTVByqhYudf71R5pmnyGNoIFahI0fjVvAPLeNKeh4wotC9+WFquG31ysm+CGEq9TaBFM0Xmz22PgKwyVZGCp1AbjAmYk31iBtSFfhurSQ/wyLZLqcVOngB4b4dD7l8jybVBaONm7fxEKc4OmHGaxS1/embHDHKaQZGsdjSPRefqkz4Tvhut2LS19u/MdDK6+CWF5Vv+yNPXPseNIBvFj9E3PxN+Hxy8Sqrsg5dEaC0Zk2Dq8ddBka9Rj1oCItFDZTBh+xkA5mg0AjFHP2aD88tV3TYdtXdVKl99dJ6c8niH5h6NnSY8zXlERLD9UEmGPYWaC+YfSz7Z2hB0cTIkkV8RaEUilcHzdViMK/2UpeJwJs48obbM8+bleZpNa9F5f4MBHiHIL9Z6XpOPQhnS2DKUcZ9CYDCUU9TBS4n7FSFp2t2EuciyWi83H0majbQpiH7Md1/NNEJX3MrWTuYmz/7dENNlb1WYSOnLDICsMwVonnzHQQZaUu9yaXMwX8j2QEEVYB0rVvGHH23Gc/Nzb2RHkqu0ChK2aVaxzUCiiBmHHtS+MNtF6OecCtLlN9WBDuvLxDHW0WQdJ6Inx/fdiP1TDRnTAy0oMND60KZYZRgBgcTpY6XA9Zay92HGa1AoE1DxPhM5dVpN6YKWbPk4Lpdf5e1nJhTZMtQH7Uc4xRCjgPBx/Ab/IdzRD5ZwCLlRBtp3NaJp5U1bxEwD39yTixJ1/hPzpa7Bmad+nopgltaudbc3mNnLJpNWvfhOZJleGADONms42pffrkfRi6i9OdlMHJrUrH3tIZgn4eGFUfy0T4brQY25fJMag3X89lGXCM4 0mnPCN59 pyBhydTvgMSPdgcVCXNcXr0nAEQX0Dwye0KFhGD+ZeKvWi23G5FrslqqWh3LXmvkZudNXmlL5NGFl7yqGquxGMkSRJNY92i5Bc7IdDRWKGjBAC3wc6AFm1rDMsesCZiIBIReXxuFlC64My9QDG/8zFp5AOMsaG+x3tKe/ZawoaN2h5UdCdo7xxHUREiuX88I8mxMFN1g1ZV/SstUKsZHP54A3MBAwus7YJ25yB3L1MOGEnf2kxG2TDtnC5CW0RfuARDoN3krnopdlvZ/OALCHN8U4Kc7aCHaB00z/B14VWn2b2Rci8U0RTOHaIZazDHYery52tes2j9xeqggEjkRgAkguDwP8Aoicb9LmUS4bK0cDF70IyVq/gpOIGwm4SsaK2HmDhQJX+2j18DS9oQNJob/paDrMforksxXyIJDmcSdR0qo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09/25, chenqiwu wrote: > > On Tue, Sep 24, 2024 at 01:33:54PM +0200, Oleg Nesterov wrote: > > > > > + if (path) { > > > + name = d_path(path, name_buf, sizeof(name_buf)); > > > + name = IS_ERR(name) ? "?" : name; > > > I think this is an easier way to get file path name which deals with IS_ERR(name) case. > > perhaps this needs mangle_path() ... Sorry, I don't understand your reply... Oleg.