From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B03C369C8 for ; Wed, 25 Sep 2024 10:31:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 082B46B008A; Wed, 25 Sep 2024 06:31:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 032BD6B008C; Wed, 25 Sep 2024 06:31:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E63776B0092; Wed, 25 Sep 2024 06:31:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CA0176B008A for ; Wed, 25 Sep 2024 06:31:26 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7188EA01D2 for ; Wed, 25 Sep 2024 10:31:26 +0000 (UTC) X-FDA: 82602893772.17.4CBC18A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf21.hostedemail.com (Postfix) with ESMTP id D8F2F1C000D for ; Wed, 25 Sep 2024 10:31:23 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=U7cRb2uC; spf=pass (imf21.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727260223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cTW+pF/WV93ivfzeK06XW/Qx7uLYqRa9AejrWV4IA9Y=; b=2g1O7T9Glca8ynieZXLWmKkdR19iZW+BkRikiMHd7rIPM+rH4Mo0KFWRH6CqNMiyj0M2pS 2D6BuEHDyhLQpkJt933bFG1d382lykGAAOrF8gxJB1m8fA47xRKKG8YJA9I5p2/dbb3HBo rHmVEMeNXyq1aA8OlsPN/RIearcerOk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=U7cRb2uC; spf=pass (imf21.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727260223; a=rsa-sha256; cv=none; b=Y8X2n+2suPyO7JBm5qsmgWwExAW6FXBgxIN1ixTwU/iOdLus8TJyZiCctg4QV6onbA2xD8 xYgpVhUJAjz5kNpHz76fScuOEtsEr6fDezW37PbnlQySt8x0R1qHCYezKEN7g7sqkR7ER5 GEEk6nb0eKjfGlUZt1/hbTo+lro1BTA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 134B7A43EA6; Wed, 25 Sep 2024 10:31:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D09AC4CEC3; Wed, 25 Sep 2024 10:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727260282; bh=azYpPCRc7Fpbb2pqhBjEq/yVygWme8hOTL1tIFJNaK0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U7cRb2uCSSGYlrTYOMEkLkLJVOvOsQCMhJxNZE4VBoyjE7Gq9o6SrUMyXirimlK0E McSps++Q2aGwn4KdkOIuSMCsy3CbLPaeiyfRhm/l01iDsfhIhlIPhnbfFUZFeYGsKJ aKZKMFqtRCSipuRw/1WbpImuw9tKxoyA/LAiu+FUsU6K+65c0JDfa5Bwd2UnBcyd5j 3QnFPplvGm09sqRiYq5x5mC5kji/QEtY0ec6n7UoL2uLBp6C8Iy2TEB0wSIVUkMeVP uy1dTuxxY8VG6XbzT6GVhe1lO/x4nUkht3sJu2EhRJWrPe4wYn0i5oqac34vFn3Rad ktd405WzhKKSA== Date: Wed, 25 Sep 2024 13:31:18 +0300 From: Leon Romanovsky To: Eduard Zingerman , David Howells , Christian Brauner Cc: Manu Bretelle , asmadeus@codewreck.org, ceph-devel@vger.kernel.org, christian@brauner.io, ericvh@kernel.org, hsiangkao@linux.alibaba.com, idryomov@gmail.com, jlayton@kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, marc.dionne@auristor.com, netdev@vger.kernel.org, netfs@lists.linux.dev, pc@manguebit.com, smfrench@gmail.com, sprasad@microsoft.com, tom@talpey.com, v9fs@lists.linux.dev, willy@infradead.org Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading Message-ID: <20240925103118.GE967758@unreal> References: <20240923183432.1876750-1-chantr4@gmail.com> <20240814203850.2240469-20-dhowells@redhat.com> <1279816.1727220013@warthog.procyon.org.uk> <4b5621958a758da830c1cf09c6f6893aed371f9d.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4b5621958a758da830c1cf09c6f6893aed371f9d.camel@gmail.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: D8F2F1C000D X-Stat-Signature: 4petrdbm1phrp9a7nexw9b7ffoy8fwoh X-HE-Tag: 1727260283-781364 X-HE-Meta: U2FsdGVkX1+JmYdJVEHWiTz/7BObT/kPQRz731wHJRB1PCAtcQ79PYNEMZSnHLdDxodA1LCmyM2djIR+mmNkV8o+KdIo+guU+MvKIlIQ6ZGzDvy5V0/fC56LD/LuJMhXQ5gUYh2xVVnERasl9vTu06D5WgMbEo3mtDXKuUsyzLWIUc7l+QBvHlKzcSL62tBzjtfKaBnpGzhChZjVSMAM6Xtxz22ts+K5LH/GX2pm4f2cHjlFgcM8spA1gIJXbvgwFzj/uxjJ3LofQSbuu7FRLkONduP6m1a+jvGJ46zsj3DLkBwnlakOY3Sd1EVRjV11D76gALA3lvvXWcOdBx2MVsu2CSg6i2ep0gbbLerrsQqjjg4hNmDxLpSWzvA/xTWQa25W06ByhdZQa1JnMMFEz1gzsT0CxMwVeoOLkwmB1yCQedNrRA6yRvXx8eRBTgDO4bmoUYnd/7hG5EUF5eaPxDzVMCUpMIlIzP0/k4tGtlQiyd920ZitsEyJCF3T4jRv0o+sae8Iv6chYMYh6jcTmgNqOeFDzIOiAOXpPKexRdIZ6+0S+raymfokqLQpOIq5zJ2kdgNbSDdqiGYLm+xdokOOFkbQXb+jWYQYkEK9RNze5UP3YEP3wKOwnQWsrqassySJ7odFAQqOt9lIrsSuYMm2yAQ0dvxPN0nK4aqr/k6WGIDQf7jxLZcTsRIv5ekFjoYPxhFNk62yzfOC3vhiMzSyXNNOBP0lYFLgAnVoac7zX1FGq4vDlOuXGo0uJ5Gyor6RJoGD/rFnUic59zOfxY5vrt0MEHmYZISLOMNSUtZ4YhPDtz8EQ1SUDUeDnylSj/i6/IuGXCh63qa66Fxmxr7NSq1RJ8foDOq+2M7jO0DKS7bGUNcuEYGuV5w7y7knAyVl9DxBkm17fxOjrUz0KJfa79iWv1phNG904zDKUj8m+pfS7jxipYshxIenOZjyciL1vy3YRiDcqPK29GV qbz1BxmE KfD50T1ssfVbzrfh3caFrojTLnUzTGZoFncKYZxcCpLcn85fl1bmED2DUFlXs37g4SYjTefjsbp7+ZPfWb30Fbk3f0pLuCm1kmzVOS2tfhRxRUfO2hZKpRpGxbjvn9D/WSlDoDfsJxiFRMxjO7ojrdETY/hsTtAxlab0tAwtfdiv910hwRIurFurKWzpso8r4/+Gr0QHoE+pevQmBhMN041LKn4M9piN5WbUipce68EJ9fpYycPZ/uqfkS06XaU6BbxEIayWN8lr734WKIpH6CLisyEXSszMDa1w6SE2OJzAo3x8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 05:01:13PM -0700, Eduard Zingerman wrote: > On Wed, 2024-09-25 at 00:20 +0100, David Howells wrote: > > Could you try the attached? It may help, though this fixes a bug in the > > write-side, not the read-side. > > > > Hi David, > > I tried this patch on top of bpf-next but behaviour seems unchanged, > dmesg is at [1]. > > [1] https://gist.github.com/eddyz87/ce45f90453980af6a5fadeb652e109f3 BTW, I'm hitting the same issue over Linus's tree now, but unfortunately there is no WA in my case as I don't have "cache=mmap" in rootflags. https://lore.kernel.org/all/20240924094809.GA1182241@unreal/#t It came to Linus with Christian Brauner's pull request. https://lore.kernel.org/all/20240913-vfs-netfs-39ef6f974061@brauner/ Thanks > > Thanks, > Eduard > > [...] > >