From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D718C369A8 for ; Wed, 25 Sep 2024 08:28:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7FA46B0083; Wed, 25 Sep 2024 04:28:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2FBA6B0085; Wed, 25 Sep 2024 04:28:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD0DE6B0088; Wed, 25 Sep 2024 04:28:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ABDBE6B0083 for ; Wed, 25 Sep 2024 04:28:05 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 567E2140180 for ; Wed, 25 Sep 2024 08:28:05 +0000 (UTC) X-FDA: 82602582930.18.46781AB Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by imf27.hostedemail.com (Postfix) with ESMTP id 68E8840010 for ; Wed, 25 Sep 2024 08:28:03 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m8Dllj3q; spf=pass (imf27.hostedemail.com: domain of qiwuchen55@gmail.com designates 209.85.167.182 as permitted sender) smtp.mailfrom=qiwuchen55@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727252763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2MYj0BFyxSovkaR7A6xY2XxO0bUPs/NjD1nFL7mhK60=; b=t5IjfSj4u+Xpz87DSRF1bf8aE92KAKCLLiy4B9WRgLxTpo6EUYGuyoeo66DlLfAe6tY5PX 4uAZ4X1Apxw/TOW3/zK+bHwPr1a1ZGDYcermXy0kZufKYMenVhHW10SehHleN8WN3ZTY4N WJv7Qxgw+TmnpNsEzTbGdOScYMcmGNI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727252763; a=rsa-sha256; cv=none; b=IBWG0ESfbw1bQyNPGv6k6IR/p2L46dQt6z1lbYsfyAYh1SlhwX1VXjE48pf8/ep2kKfB6u r9H2cgfXRQQIgrdq/vqSCyJZXxYbkDkSgHgzu09YC5mPBeTq8hR3CYKtZoV0Z3DKW2pyHt AJ6EKfLoAaTbpdjZK1qa+igIWnChB5E= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m8Dllj3q; spf=pass (imf27.hostedemail.com: domain of qiwuchen55@gmail.com designates 209.85.167.182 as permitted sender) smtp.mailfrom=qiwuchen55@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3e045525719so3722755b6e.2 for ; Wed, 25 Sep 2024 01:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727252882; x=1727857682; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=2MYj0BFyxSovkaR7A6xY2XxO0bUPs/NjD1nFL7mhK60=; b=m8Dllj3qcxa9EvzQNR1/V/hZWCymGBzn5z1K7OCtEVnizheJNCZ/XdS72Y2/VFDVp+ 3Crn9b1PNycBdvUiHJwklIj9SpwpeM8IaUjaJmbvfJYu6uMpi9ayzORuSuKcIXoFZ8vS yOAqAuiNjT/zQEf/UHrFT3yhsdgqxITQSIFIshGD3I/HgbqKqxnl7F2FO/AmlmI21QWv ntAN9JZoIkqql765udzuP2NBzr0uZbTFsIOHtzCg4WB+uoazcNyNzFin4C9uPtgSS9dc pnCrrhTzpLST9eBdGIIl89CKSaVecuWVtLc+MZWu1dyAmwtrId/XZr1BCViPq4rCvadh PdJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727252882; x=1727857682; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2MYj0BFyxSovkaR7A6xY2XxO0bUPs/NjD1nFL7mhK60=; b=kFtExb9UEmKwCpar7HCeouiOwmloX6jx5AUSjsviQdfT46P+DGRdZaKUGBMaZJt1Ss aslxtbo9/gOnOfuFVWC6NqDcZChjuaOShXk6n4pvVUn58F2aV3fhnoBmXiz1+TriNFcJ zNhknDjC4trA3k9PBGskASku495pSkzwUzruG0CbTuSmQpwi1ynJpoB6FHWGDcSy4lxw ha5Dnd13OllqSCwy9TCZBlitpVYG6qW2pNl/l4/FWbRRAv4Tr3mmIOWwCzteIUw2QKmK CRvMBleuFBYPNzJ1FHoExfqyt56CVonwF13g8kJIlvQxLu+eSq95RPiOvnLL/s8SpeoG fwYQ== X-Forwarded-Encrypted: i=1; AJvYcCWDPXnLc6iJei56wc2yunCevkmR9jFthMpCrzFXIJSeTiy6+N0tvlu0bsNRAFTTi8jvj+y0qNr2eA==@kvack.org X-Gm-Message-State: AOJu0Yw2NrIy+p243zIUos0cC8g+y80hiGbg/+n9FXWV+IS4UoyXjQmV FMfqMLQo65cU6IIiuPX1qfqaVfes3Y3FWNAgd79AkBQNu8bxZwyS X-Google-Smtp-Source: AGHT+IGgJbM6Fn6q5vroZqSbVqRZGRNq0IvIzjVE0zJdpYVwVw64Mu86PhYWJn2LFxh7GpvX2x2iuA== X-Received: by 2002:a05:6808:1b14:b0:3db:3303:834c with SMTP id 5614622812f47-3e29b809350mr1539389b6e.39.1727252882339; Wed, 25 Sep 2024 01:28:02 -0700 (PDT) Received: from localhost ([183.226.245.34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e6b7c307a1sm2252223a12.14.2024.09.25.01.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 01:28:01 -0700 (PDT) From: chenqiwu X-Google-Original-From: chenqiwu Date: Wed, 25 Sep 2024 16:27:59 +0800 To: Oleg Nesterov Cc: "qiwu.chen" , corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, paulmck@kernel.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v4 1/2] panic: add option to dump task maps info in panic_print Message-ID: <20240925082759.GB2941@rlk> References: <20240924074341.37272-1-qiwu.chen@transsion.com> <20240924113322.GA7248@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240924113322.GA7248@redhat.com> X-Stat-Signature: pwmx7jw35aa3emqpobrickfucp83wuib X-Rspamd-Queue-Id: 68E8840010 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727252883-752174 X-HE-Meta: U2FsdGVkX19miD4GwlQdo0nyki/s0Doi7cXNXIxOELvg7rT/HnGVc5abJ6bhT7X9nrN8NlMWEzBn9uQsz+1v2n5B1pZRUDnO1HDz/QVHif7cOGfvn0jAsTpUEvlgHrxqDFuPEGqzYKrTryQ0AqsU/dZ1fT7u4glY6t7229kx8kYhAFzm3JRKuBb6BR3FimFwBKbkSTJJB5g3bug8T+DF6F4u9WGWW8pZsf9VzIw8UTs2nZzvPndJcQN/IWKcAQVQ27Sg5tJSy9o8kRKo7d42lOOZCVH3KdVDbXLf8TXZqXIgk3YNNSGUDqnke3PxL5qYMOh68Hwo6EJ8AeoH7c0CdT3d9TufrjGCttjCpeiy4+c1zgan1p0JemSgDolm2B0ylo2hrdsgb4QsxTeW4cQBWwYEC+g4ibPaas00ems78PyzN+jlIfhItcjzjXmwTnkaQepbpp+8hTpzSOY7ln4tn9RKXeGaCtk8AJAdWJRq8+s4h+EzAKMRlcdVa6XsRtMlTAb6DrBk3KrERxVKpYi31oSXc9+U2PYKV4EtU5HV2NDHQaF+8X4MsdlkGf6eikJaYsqCG7hYUZ8CCkwIK7wBpZ2ITzCa9rBMDkb2IzHGMGAvnUCVYdVHk/LctHaexbDGUTNaWRfoBy/N7aBztMhdkTonRqIG1hkWQD0ywqOPxjCRPW6i597sROxcb0d6NP+fgNZyW5qVNWTd51z3hMk0i57W4VblnnqzCkBRXEfsmOMCjfapwq96tc+ps2K1E9D2LPJOz6700r6xNv2PGtj80ccOztxiMeuELyU/LlshM9rUdGOeNWiUNjLxUUZdl+GUh/8Lk/M9UyoKQXjXmZ06/6kTS8+M/SpfOnvMsEWeThJf65v5UysPdlLa0jEZKSd+3KyH9csAQa+RgaBZutLj1kdU5lj7QXxhdHYV13oVivujGiNaMay+eWWEwVcuhMRIeC0VJQE0IIqUKSzTa+6 wnFITP4w P2Zs2TZM/Y0aPPj2gZIdhksZuG31AKqHwF69pGRPMUWrAodlWLijWeydHRAytp0PNlbluHOrpQvpCLTnnQ+DEN5V8iDsOBoFk5K+oyQpHtPeiXAvq9UKTduNPvPNAB26VA0uB6CNod74MfJHNlUKXvnBvVzVG+0FaYvGO047RIQuJ+qwEEvIhxB0z2ZvBkbvbEnSZ7ib7b/L/ZDzIrXu3DqaqIKe5PmxhTW5r7Nxo7JbPej4RZajXx3wQc98K00x/KlacvRPnNlwtTsH80MJg/ED8t1zVpaxWiFQIxDXlygK4Lhhr93e8cEIIoVqIickbLF5+HW1ALm1EfCNFVJqp5eih8XcCCspIzhYbIf+JpUwWwm5nenO4YGbV7nFeuiT56z/hZeCIMSisn2insDMU3k2gyS3c2qh/bRDHz1mOCNxldOA8LL947rT/UdnBspi0V9eX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000124, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 01:33:54PM +0200, Oleg Nesterov wrote: > > You didn't move get_vma_name() from fs/proc/task_mmu.c, so it also depends > on CONFIG_PROC_FS. > Sure, thanks for your advice. it should be moved to mm tree without CONFIG_PROC_FS dependence. > > + if (path) { > > + name = d_path(path, name_buf, sizeof(name_buf)); > > + name = IS_ERR(name) ? "?" : name; > I think this is an easier way to get file path name which deals with IS_ERR(name) case. > perhaps this needs mangle_path() ... > > > + } else if (name || name_fmt) { > > + snprintf(name_buf, sizeof(name_buf), name_fmt ?: "%s", name); > > + name = name_buf; > > + } > This refers to the code section of do_procmap_query(). > Why not > > } else if (name_fmt) { > snprintf(name_buf, sizeof(name_buf), name_fmt, name); > name = name_buf; > } > ? > Sure, this is a better way to deal with name_fmt case. > > + if (name) > > + pr_info("%08lx-%08lx %c%c%c%c %08llx %s\n", > > + vma->vm_start, vma->vm_end, > > + flags & VM_READ ? 'r' : '-', > > + flags & VM_WRITE ? 'w' : '-', > > + flags & VM_EXEC ? 'x' : '-', > > + flags & VM_MAYSHARE ? 's' : 'p', > > + pgoff, name); > > I don't really understand why you skip vma if !name... > Well, the vma without name seems no sense for debugging, skipping it can reduce the maps space. But the disadvantage is debuggers cannot get full maps of task, perhaps we shouldn't skip it. Thanks Qiwu