From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B8C5CF9C6C for ; Wed, 25 Sep 2024 03:54:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AFA86B0089; Tue, 24 Sep 2024 23:54:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 85FD46B008C; Tue, 24 Sep 2024 23:54:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 701706B0092; Tue, 24 Sep 2024 23:54:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4EEFF6B0089 for ; Tue, 24 Sep 2024 23:54:50 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AEEBE1C6126 for ; Wed, 25 Sep 2024 03:54:49 +0000 (UTC) X-FDA: 82601894298.21.F04BEF0 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf13.hostedemail.com (Postfix) with ESMTP id C856120003 for ; Wed, 25 Sep 2024 03:54:47 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Hsq3Nkq9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of qiwuchen55@gmail.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=qiwuchen55@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727236472; a=rsa-sha256; cv=none; b=tj3DcGmlxNbHvh0oREmVTNtqwRQHycwK/gsfPCLnKcPQ50TiMMN4dpCfdL13S9W61c39WX Ng9RvnjgXdWTbtdUbcnrpgcGEoFwwTYnpN+0T5Gb4MMWyEX87bHb2hG2JC4QjVClRI3lTn F9N/zJZJ8PrMh819JBH6CU/FpPmlcrc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Hsq3Nkq9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of qiwuchen55@gmail.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=qiwuchen55@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727236472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QwY19019EFRjU3LmiFbhaONNL620/dAJwYqX4p46DKY=; b=CKLg+siMjUfj8k///JaLJuq9oNGNk8EPfI9nVbj/VfKYJ2icGFvbu+7PWhBj1NJArRPunE UApWSbeJ+FMpcnWoRs+DUXQER2Vo7VvXtLUThMH8ifkfbKdOmsRMrvLK+9pfNmnzdnMUOA mDbQ8KtIbPzo+SF9wRCW9P3Rabf1xM4= Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-71798a15ce5so362827b3a.0 for ; Tue, 24 Sep 2024 20:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727236486; x=1727841286; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=QwY19019EFRjU3LmiFbhaONNL620/dAJwYqX4p46DKY=; b=Hsq3Nkq936bdH1bY4Ioiu2qkxSZSrBNC2/VzwiCLyVEaXu+ej+t+VigLxOEvaLaEbu kQVudXI/afSBKZ+02a7cYmPSvtRF2LvtD6ApXg/I9zLTzYwx9RY0bqhKpAqiUoQ0cwbJ pmf/xexoLITV7hXrcCt5rQTDDJCBA4FkNLfBheCLkt5A3gX21Ip9e4Uo0HRg4fnYK4wv MyDanxlwSLrqe+VwZ+1KqUcD8sfmfNfcwmHfB/2VOPsHrFhFl/DokJv7JbJGEWWcQwV2 fdHI2pU3FfKBzic52U48JqwuX2YB8/O0MpJP18HHCFH6e+S8+EJtVOmlO2bghr/HirMU KGTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727236486; x=1727841286; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QwY19019EFRjU3LmiFbhaONNL620/dAJwYqX4p46DKY=; b=gUlnRl77cHz6SyIqdb4xQ1F6xoBFdiiOnvNWrNA4mgVPRdfGk+QU6mVBXWlDjnC+/6 B3EB2OmIgd0uWHuTyOfmrBsCjMQDUbSzMfRglsOg8ZhW5YyvX9QdeYuPj4/thSyRETFf PRNdkBReewl6EDbRD+RDle6HgTAiaLrLRM7XWGZHws/pOfmhV8XnYXKbwH7XF0RLvqT9 I4fLamg1pqZwa2jwOSywjfk5OKq022EnGOa6nU37ujj/DkzvK8cAx/ZnNksm5eU9dbvc GGzq7pkqe9BfidXRKe1Y/5yNrb2ugxtIHANIeZRLHw/gyreIFe+Q8ye1hrZUb+RHCDpd f3Jg== X-Forwarded-Encrypted: i=1; AJvYcCVofKxuyPGzD+vzP2XiPVfbWFN52LoBfX+AtvhpFLkz48teilaa6c9LFMX+hTdim2g5wS3n3Nenuw==@kvack.org X-Gm-Message-State: AOJu0Yym6AuEkIU9w5V31ZJjD4WJE5HuYJ3yIpG9KFSZ70nBWm9rj8+g IlgKQz584adqqem1ErW2BmktGeKrQnPAfBDGXm+iOTE/h2zhm9hR X-Google-Smtp-Source: AGHT+IHoszYzZR6FaOBuROwQNPUghuIvxepmZftX62ol0oPeA3CYEtPbyagy0d3q92dFlJQXXpOaag== X-Received: by 2002:a05:6a20:b58b:b0:1d3:294e:6502 with SMTP id adf61e73a8af0-1d4bed0b3d4mr2042853637.3.1727236485859; Tue, 24 Sep 2024 20:54:45 -0700 (PDT) Received: from localhost ([183.226.245.34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e6b7c73085sm1887334a12.59.2024.09.24.20.54.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2024 20:54:45 -0700 (PDT) From: chenqiwu X-Google-Original-From: chenqiwu Date: Wed, 25 Sep 2024 11:54:40 +0800 To: Oleg Nesterov Cc: "qiwu.chen" , corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, paulmck@kernel.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v4 2/2] arm64: show signal info for global init Message-ID: <20240925035440.GA2941@rlk> References: <20240924074341.37272-1-qiwu.chen@transsion.com> <20240924074341.37272-2-qiwu.chen@transsion.com> <20240924183634.GB17395@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240924183634.GB17395@redhat.com> X-Rspam-User: X-Stat-Signature: q4n6wqmc8x3kyaqrz9r4xwjmh94njzfa X-Rspamd-Queue-Id: C856120003 X-Rspamd-Server: rspam02 X-HE-Tag: 1727236487-871313 X-HE-Meta: U2FsdGVkX1+QkLE1VASY3KpEjZyorA/31/Yi/HmiRQLz69JBUZxBpDdRMh5lH0Qat/lDuNy3C7V5oZmb+nGxIYuh/0J3d4cv8TL6HRLJS37emtya4tOlZgKb4lm4BouWoatHKvtIJGH4jvKs8chOj6x2lahr696NK4vZOJF/TQEvgQFo6JlYefqtTgezthqeqNItgIhds/CynkCqoVcG8kfW+mkQPHi/+UWNHv8f1ClKHXbuc6lpPTFnvV60catMfbHtW2qHTWeqQmvmmKdkgO8twcFeOUK5io+efAbE1X1VqfjK8Uwggchc+in4D4ecnFQkGyaZxiNVJKycFANc4dcYMQ3c1yGl0bQTjUx8u8tskfC/s7yFIgFRtsCUVEfiLFLFVZDZj9+PovPFrSUeUo4nU78zHWL4WijPM28w8YYUYkKeZX2XMe8KmSMOpvgcW2+0uvyPpjdQlPsrJ8QJOggjJ0gpcfWuMZjFG/qkgyOCnNVHR6Q45AQ3ONKL8MkaJifcVNC3thGuGNk4FbRaYVO8NFuaVyHZIn6s1VSyza8x3jnA79QWK7tLVlP/3DR4UFx5geq/GEOXjzQNgfuIhSKuCEHgx+CVSIEj/jY6NeOGSvNh0grkxcLxPssMy89fQQFrzIiMJdnGuHEuqh+i+egS6cE1BjOuaFVswz3xJ8juAJdRuNE+hV5Zj3dQWKopk5n0hffOfKjuytSzgF6gwHFrswvE5BbAba4YWw7v6vqMUvlhxIAog8peHtGNjZzDobfrXJpvnfMlhPbOSaoaDpNi43kmIFZD7Pf5ASFdt/xrFH/syaMptenN+E7uPQsac9i5j9Y4U/oQCnwAGbDbdEH/gp7ITPbOV9voLKI+dfMDvQX8J5igDVDyFFL/FdvI9teDSj041WwrBXTtXgyutcWeQarfH+iIb6Jdw6sKr4wDxocDQlkyD4rBLLt7g3QSgeYtQv6HgSLeltiWxsg 6WWI9FWP b54YE8LzqO5qzAzC7+qyf9y079ZNa+B1Fe/gDv3yS9y5e41DeZI5XIHlqpVlr3O4UsjiARcHrdPMm/R46FUHKBypVWqGMW5WiJAQsjekDdQp7FNMMUD/gvYFeKXdkl9XUPWuAfmfik1CXFARRcbbo9UTKCeFyut7F20SFmoSC8EUtOYFvL4wZ28/mhT5ytOZq28ec1cHf8OJ8p/gO+4tRJnwxF0nsM/4xAetLgvQz/qaOxnMVN+nSH72O5D7J87XYpKADYt5KvyNpEmi0+Qqbv2rI29injW5v5hUMt0Io2jeXN5h9AHmYCGCaLoHwLHeovvpHWQ9+slutiQzEPo70jG7pabn05Ad/0f/pbdjlsQwICe3XCPn1nXCZOGxS+Gm1A+EiYg3DGiyTDIk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.004127, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 08:36:35PM +0200, Oleg Nesterov wrote: > > So what does this patch try to do? Note that unhandled_signal(tsk) returns true > if is_global_init(tsk). > > So it seems that this patch just tries to bypass the show_unhandled_signals and > __ratelimit() checks? Or what? > Yes, this patch just try to bypass the show_unhandled_signals and __ratelimit() checks for the global init. > > OTOH. The is_global_init() check in unhandled_signal() (which predates the git > history) doesn't look right to me. If init has a handler for, say, SIGSEGV, why > should the kernel complain? I need to recheck this logic... > I think the orignal logic is the signal sent to the global init is regarded as unhandled becuase it has SIGNAL_UNKILLABLE feature. Thanks Qiwu