From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8E4DC369B1 for ; Wed, 25 Sep 2024 09:29:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 312B86B0083; Wed, 25 Sep 2024 05:29:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 298446B0085; Wed, 25 Sep 2024 05:29:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 139836B0088; Wed, 25 Sep 2024 05:29:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E7F456B0083 for ; Wed, 25 Sep 2024 05:29:18 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 61BA51A09E3 for ; Wed, 25 Sep 2024 09:29:18 +0000 (UTC) X-FDA: 82602737196.05.2F5B836 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 9CB791C0006 for ; Wed, 25 Sep 2024 09:29:16 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=e68pSZL2; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727256521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S/WuKh+QT/JW1/qZULpdYnzGglC5okLselQYxGWevtE=; b=kEkeaE/6DRkPhIMPL2Y9nG2D3kOZabXagnUO7LtG0tGoT8yvdBk1LtQbWHgwl2weglMZkz 6/hi7wKoayRw4g5AXjUR4R++ykqyo/WrIf5+xaE5H0GaS7CtU/54HC1oBWGmxaTGjFfN2j ZWAIDq+HiMzqht3elq1prHsQarBdPzs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=e68pSZL2; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727256521; a=rsa-sha256; cv=none; b=0R5FGm4Osck3tzg+EhpE5E3MWw4wz5HXPmTCRU79aJjKWMZrYYLYvmgrEh8LfOB1Fdw7J/ UgSJR1V+DA2tiR0sZ6FGMxASXbC80ONhRswr2yMieCiAw2jAdHoFy+LBFA/j+Ia61I+4NR q4yPGEWvMZRnhdu4YyhhUnMDBlXGifU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 86BBE5C5A5F; Wed, 25 Sep 2024 09:29:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0ED7FC4CEC3; Wed, 25 Sep 2024 09:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1727256555; bh=eMhbrFVorCUcB+bdzryCwpTOvnjXWyhp4ukLuhEbuEA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e68pSZL2oz+VPNyWp2fvN5Xn47uaRol62aicXRCKBSPGNcHxfd42hB8So0AjowS/2 xTHNnCqHsZ3H9aVXXt/VWoIICM2PzhW2hTZDjXUJk0PSuqUJRfNq3HHjLmQETt3XdW laulko/THHBPi+f8LM87Np1qq8we87lYaLQ3wew8= Date: Wed, 25 Sep 2024 02:29:14 -0700 From: Andrew Morton To: liuye Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmscan: Fix hard LOCKUP in function isolate_lru_folios Message-Id: <20240925022914.7c4033c9bb1206ad149ba69e@linux-foundation.org> In-Reply-To: <565bae19-889e-57df-42ff-70728cfb818c@kylinos.cn> References: <20240814091825.27262-1-liuye@kylinos.cn> <20240924172205.5068e86430873b09b75f8538@linux-foundation.org> <565bae19-889e-57df-42ff-70728cfb818c@kylinos.cn> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: hii1byxoiw3r9s9ussu35fp8ugosidi3 X-Rspamd-Queue-Id: 9CB791C0006 X-Rspamd-Server: rspam11 X-HE-Tag: 1727256556-718809 X-HE-Meta: U2FsdGVkX19vndtqihwF3s6Jt8+rMKaob5htBVuw6xFwuznKhYxvl+Xoc2J7eEKMNDq/pRoAChc5TbmopSoQXfBo8bjxHWuLWBJt9F3MBHQrNK1aaJapFYaYtyESR0cGUzUebi73ivccSm0KGpeD1j+D95ymDRd623xLHXxaLYKecxt4HhmsKFeUYN1/pOpN0hhhYbJ25y/kqh4spd0xQ/uhbPNOt+wE4AibgSqtac50RJLSn2odYprLzpKc8W2PgZgRZwp2BcC5vecQpVAZ3Jc1+SKNmLf2FYS4DK7pt6GTKAXskEQw+EBa030MfBbN1bUKW534LjdisF5Up+0enCrsiFPkioSlIv0NJC+1Vd2iykrtEcos7CSehHxIW4C2fURWFHLGpBNiinemmLnRubRqlnaTNUYJXWA7H1nYNIXFbaUxrduRRxRXv0vE0oU9lM+guzSwS3jLkm3GdbGi+4KufXhQntzsjQGswdjodddCuRS2ZvVOQ3KCi9v1X9y9REqSEW4X4+M9s6CAnBZPsf56evlhej81r3UDslm7I7+1PyYlDvLqaz9h/Rj1cvwOPFJhYOmYFIc7JDWXSgBbbAm1lRDdLiPcHKam6+OzAhk9Wps+HgEZNd0b28DvvWhPgXW3D8yeU2BwoIU0tAGkqVhlnICYjh/U+9eZxBPk/smG6ATgfbre9ZGEqc4l4fTRRe+gWSe38LYjxAxdDJnAeR8EUwzcMmQpjaZkZPSaoPQI7RQOk3L8pj+4Xp5WCp7oOZch0KxepPtMOTExX9WhWMhB15RdT3O9EyhkcZwvbQOPARYSkEJfeKiiTMK8FlkW2s7k/z80xJoqWYJpZ7+VtEHeF2tcZ87OceAZ+xtixTYuXDyym71Ny0PMm4ekOEz0uK5BoyGuoFwujIOyaWZ0R1OPe93VCYhJuZODuZpebW/2Abyrqrh/CrmmeQVIP8ZByOp+Tjlp3RCjTPihDeA lxVL+Q7J s8kMjoQTgT/3pq00J5RLj/kUn6Td745NgH60LNRzHNp2uTEunfotoxV18niIWszEWdTmvQUdG8zLpASE1VQYaCeqQ0em40/fyEGpIkVH35cM6KVJBmSfom0cUU4V5r7pLH0B/FoyweVwPL7g5b5SynOyT2FS7MpYH1EiIxZvmpUiY3/QVhpiGBKyc0UOWDDgysfS6+pr0SJQFgh8D9JJN+VeReqXxoflrYTWsQ0oOFrc7ytMJN0O2s+IOBJmlmxSQGWToRwRQr9++JGbzVJvpwz8hFRnHdVry2KwgCx3fJ6+WXMyJpVNZ9fXG7ztaKPfhqLYN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 25 Sep 2024 16:37:14 +0800 liuye wrote: > > > On 2024/9/25 上午8:22, Andrew Morton wrote: > > On Wed, 14 Aug 2024 17:18:25 +0800 liuye wrote: > > > >> @@ -1669,10 +1670,12 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, > >> nr_pages = folio_nr_pages(folio); > >> total_scan += nr_pages; > >> > >> - if (folio_zonenum(folio) > sc->reclaim_idx || > >> - skip_cma(folio, sc)) { > >> + /* Using max_nr_skipped to prevent hard LOCKUP*/ > >> + if ((max_nr_skipped < SWAP_CLUSTER_MAX_SKIPPED) && > >> + (folio_zonenum(folio) > sc->reclaim_idx || skip_cma(folio, sc))) { > >> nr_skipped[folio_zonenum(folio)] += nr_pages; > >> move_to = &folios_skipped; > >> + max_nr_skipped++; > >> goto move; > > > > This hunk is not applicable to current mainline. > > > > Please see the PATCH v2 in link [1], and the related discussion in link [2]. > Then please explain why it is not applicable,thank you. What I mean is that the patch doesn't apply. Current mainline has if (folio_zonenum(folio) > sc->reclaim_idx) { nr_skipped[folio_zonenum(folio)] += nr_pages; move_to = &folios_skipped; goto move; }