From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5729CF9C69 for ; Wed, 25 Sep 2024 01:03:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D5D46B008A; Tue, 24 Sep 2024 21:03:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 485636B008C; Tue, 24 Sep 2024 21:03:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34EDD6B0092; Tue, 24 Sep 2024 21:03:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0FF7A6B008A for ; Tue, 24 Sep 2024 21:03:12 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B2BC21A0652 for ; Wed, 25 Sep 2024 01:03:11 +0000 (UTC) X-FDA: 82601461782.21.210D604 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf07.hostedemail.com (Postfix) with ESMTP id BAAEF40010 for ; Wed, 25 Sep 2024 01:03:09 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YsyadZE7; spf=pass (imf07.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727226070; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h6s247HfbbevWqqQut8C2PU3zhdqe/QGL+UApOoKHSQ=; b=XeMSijqdaJD3Yot8vM6veQpYOZxNrLCotV7jR5O9LsNI+Ae+atlk7QXWTh9wV4RihGcQ1e EW1k6/ThWgDEy9OOi6T9IPonkx6uuwCDJtbm1jNqTUGVzgYoPjVsmqhfH2VqXOxA7cR9hW uU4ynVCp/WLerBmH+im6t9XMJZMgMMw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727226070; a=rsa-sha256; cv=none; b=CeuaLJqScQfzN4UHaUzlIkC9oflKIMlYc/ogAczkwcsCyNfKptbAMu7o8diKULBOW652Le +i2WkHg0qoFOoFQy1stnUu3nqsvlmSI5H81+khtLx9pQvhkJK/xhav2KxNGNsVzhleQXqM diLA+QA/uhlcJfxdMgx4n1qmtYw0s1A= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YsyadZE7; spf=pass (imf07.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-53655b9bbcdso7390355e87.2 for ; Tue, 24 Sep 2024 18:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727226188; x=1727830988; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=h6s247HfbbevWqqQut8C2PU3zhdqe/QGL+UApOoKHSQ=; b=YsyadZE7ePmnJDmntZLhj5OHAPJWPjP5B0xBlx81BkCuwqlh/XAfGGGwsGKQekg85A aezvYjSEYCGJU8ue8WekWNzRv7D9eNZmCV+uLS8E7QS5yD91beje511q3qBsGbAnY2/V VahuvgtwEEcHFz8QLmnNR7ZiEVFEcgckeUYex6+uurCxKZjdPgH0Dag7X7bK89AibEjG nPdVoGXmAH2jBpS738tFLOepFZmD7QqwGqR9+b6zlE+Ow4+e2AAg3RMr1DXUJY3MYnlO uwUl80r5yJ9Po3jMjCO7m7S6r0/ZLjYzWa3KfsnFZr2s6G4XKYeWlu7L9vGhYFtwxZ4N +58w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727226188; x=1727830988; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=h6s247HfbbevWqqQut8C2PU3zhdqe/QGL+UApOoKHSQ=; b=Z2e6/DKmYOV7Yz4ZvJKUJ93SB+QTjdphlQbd3cadwngj6xra902y9NQ9CMG0iaImFD Iy5ZH2Jp3XRKLubCgcQGxzufKICYuuCI7G2fye8MnDJdIhmbjz8uaIR1sqUgaUDr1V8F 2P/0IKl8RHOB4ToToYn3qbQ6KY+xmiWhZLJDRiG0qIvK3PVy7AsloBRtEutEGUJxhCzC /UEIyekAGVi1FH8m1aYf2dV4pd6wE2tINiJEEWum9w9QpdtORFi+DNKXolBsMU/zSl6l XLUrr13R9prWUFnx5aomtj0IGqLhEiMbkCf5iAvap150yqOVrI38ZgpmaCftLFf/I6l9 YyBw== X-Forwarded-Encrypted: i=1; AJvYcCXHwCNTo4DNKy53EEKyxil7PC+uOlyWnkbGKVS7NQ0LFmLUok72PYYt+7frWoBQaiLRENZ9SMEjyw==@kvack.org X-Gm-Message-State: AOJu0YyWktIG+Sjc+aMi6JehXAbvJhJ3LnpV2SZi5ylwwv7+4c2H9q1X cQSdagfyRjwX27S+HDsYkpHlLHhN+vN4/W9V/6QaGABlPiZ+8jdd X-Google-Smtp-Source: AGHT+IFG5PB+uwceKl2nGBygOAb78KmAgkJRDlGTdYazbttSF1owiXtGhCvZKbhNRnCf9OZZnODNag== X-Received: by 2002:a05:6512:3a8b:b0:52e:fd75:f060 with SMTP id 2adb3069b0e04-538800b2725mr350666e87.61.1727226187602; Tue, 24 Sep 2024 18:03:07 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9392f340a0sm151287266b.38.2024.09.24.18.03.05 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Sep 2024 18:03:05 -0700 (PDT) Date: Wed, 25 Sep 2024 01:03:05 +0000 From: Wei Yang To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, Wei Yang , maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 0/4] cleanup maple_alloc related functions Message-ID: <20240925010305.bwosd6c57svzgwe7@master> Reply-To: Wei Yang References: <20240924123954.18933-1-richard.weiyang@gmail.com> <7103f5eb-0891-489e-a012-277d217dcf34@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7103f5eb-0891-489e-a012-277d217dcf34@lucifer.local> User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: 5gtx7wuytx9j1nn9czzkyq4pcfw7m8rd X-Rspamd-Queue-Id: BAAEF40010 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727226189-294272 X-HE-Meta: U2FsdGVkX18vNLB8o7UVivjkj7KPbrLpFM+zfSLO7fej0FirFceDqLRVo1fiNY8yY2IKNtd+yeO6PRamLJJv2bwQAVYhXm9/hB7Q38q3tZEJZoiKhS9+h6Su86D6fFk2Xdi5YwaG8uxL/Pga3qVgaS6aC2rlTVRfElGEBx4ACViwEWsyldTfCqtmFnHK+ctUFL9arOgt5mJfjQwaCsDO1vipae2pM09TjZCEM7EKBm7Sb8VJAA0p/YG5bezPpCggvcwxY7P1PSzauzRbQ1fK9G6onxvNt839UJz/txT1AsLa68FwGEtW72pL1HLmEloUgSdyCu1SmQxxkbcJBmj3mAuw770fgMP2hKKqwfq143QuGKvREs6Rer6t/curlnAgOuOA/ZN4Ck8ecaHAQJFJun8/xF2g24fabDyb/3EopYBAG52noifdJxgN4/f2vluBGS1B3a6RhMERE4GPlrjrvY1ESDnaGJOqk4zi4JoEKZRd9DbKWZdnObeAd5T9tExDh+JrA6JsVipQFqvfavUA0p+1spJ9jHrPbI2uCwHJOSzUgFYq5CZ14Jq5eHhgspqHb5bp9NgwgbCgHY2h9prpnqw2y2i1Ge8ujgK79cyLoGnTssRWd6dcQlQ0B6RKEBssy5n6WrbEM5IjvY71gXkrFWvrQTy28Ge9Uy2liZotq4lJhOQs3Bb1CmJU0lG3vroy7IuclcJEb7k+GCLLwgjVYy/bk9A0P1/abZptibeN2hLHFiTfr2riV0qZYUUGweMtqQ3SWSz5H/ATl37W3yP4XcUdRrqoWWK32En8I+/xK9DhKW6UttDdJ3BjqUT+T2TJKtKbt1BXoZ0N1lWBnSoYTAv/W52NenwWfYehxNyRXiXPmez+LBPBUKjptGqKCneIwpiYlt13eofOtPGyTHKZOz4Pd2duRraUv38FnAB39sdt8GnszlrGCl9bNDLyTHJsGHwwH+eikVITvJTDtqL +uvkdNSS KCdQWtg2L52K9SPlJwrHRSEP9WEHtVdUF6NKbMOvTIm83AKlIWpEMgONuG6YCYlls8LPRJiW24nIPQgCqhqL7Ms0aolgdPkuQW5Igds8wDTouaubZWD2I0o592bNOye7m0bvOABuVi5dzyL1G3wTYbiyKQV6niRVwakLwgyc7+r8mK5PcCbTOP3IzTAqoIghWIbFUJZGC4iXHHSUQi2sGue3axS83L9GQS6mnnRf32cHaudmUXZ+U5cSfb+PofFvzcIEGqCFDbW3v6uhwXEHqDf1w+h1Otivs6hI275Il1UEt/Qvt9lnifbhPXHmnNvlmCC1nKh5Je7MgMepvsd64qic7IqOAeNfvh9jaUZrM0yicWwkIrsQcw70RIwFEaxs7uAW2fuXI0JJ3lPU/kD9wLcVZZe579DCRsa/GOjRUgk+jXhLoCoB43BIu7UjHCoc+jKjTHMmC9vondLtB9HONACvvDFgWkvPcZlExsTzLS5YaZRUlR1tBgchly6F2/xooL6kcqKB1DYcX+KRsQjbl/5OmUuAOR06hYLu6cxbFSnLZD74Dy+szqxpjA6v1GUfGZ4Yp74YSZwC5cwfKPXcZKkoCI5CvrwWAnoWx+B1nM7bOgV0GzD3b4H+M2U8f+vYAVJs0eELNyGJ6mqnhVSYhxWlmlRV3kYbA0fit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 04:03:35PM +0100, Lorenzo Stoakes wrote: >On Tue, Sep 24, 2024 at 12:39:50PM GMT, Wei Yang wrote: >> Patch 1/2: some fields of the maple_alloc is not necessary to change, so we >> can skip some operations >> Patch 3: a valid alloc check could be hide in current code, so we don't need >> to do a separate check >> Patch 4: found on rare case where allocation would fail even has enough >> memory >> >> Wei Yang (4): >> maple_tree: clear request_count for new allocated one >> maple_tree: total is not changed for nomem_one case >> maple_tree: simplify mas_push_node() >> maple_tree: fix potential allocation failure even has memory >> >> lib/maple_tree.c | 26 ++++++++++++-------------- >> 1 file changed, 12 insertions(+), 14 deletions(-) >> >> -- >> 2.34.1 >> >> > >Andrew - Liam is away at the moment - could we hold off on taking this >series to unstable until he's back and had a chance to review please? > >It may be best to avoid taking maple tree changes other than urgent bug >fixes or the like until his return also. > >Wei - please hold off on series like this until Liam's had a chance to >reply to this thread. Thanks! Sure, let me know when it is ok. BTW, I don't see Andrew has taken it in unstable. Do I miss the mail? -- Wei Yang Help you, Help me