From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B247CF9C71 for ; Wed, 25 Sep 2024 00:37:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1169C6B008C; Tue, 24 Sep 2024 20:37:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C74F6B0092; Tue, 24 Sep 2024 20:37:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA9736B0095; Tue, 24 Sep 2024 20:37:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CA7B86B008C for ; Tue, 24 Sep 2024 20:37:27 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4DCBAABEB0 for ; Wed, 25 Sep 2024 00:37:27 +0000 (UTC) X-FDA: 82601396934.19.A089628 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf17.hostedemail.com (Postfix) with ESMTP id 6542640008 for ; Wed, 25 Sep 2024 00:37:25 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Y/pQBZml"; spf=pass (imf17.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727224486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qi+Ew/rpwQdNekWtvCMQfio8DRksEPNbxq/gVYTc9Bc=; b=lU+8AXKG5DPkqreADIOOGI6u0jIAWr6Elrirm/1+tb4eBz44Nl+N9Bb+A2p+jV9nCUQF+z 5GLh21hryhoPXW8rdseUFFgO8ec0dnaMcGoJWAR2iitDv8XzYuKQMbscHZIbmD/nj5Ssie KSLo5+c3/dWl0Ojjz0kTosd64sECkHw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Y/pQBZml"; spf=pass (imf17.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727224486; a=rsa-sha256; cv=none; b=77t1UdAxeQTM0Rqx0/V9+BU77/m5eyi3IT5Ikwetpl9SnHllpoHLsWPO3K6aPla/YuMQo+ dmekEwP+jKoM5+KxKcHEf6mHYs/sRefJRsJSLHLpojlrNaDTURBMqXD4KMuaxgv2FbFDi7 VLEI3xKfxmUiJSRB4uz7Q3rm1uh3DFY= Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2da55ea8163so4053931a91.1 for ; Tue, 24 Sep 2024 17:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727224644; x=1727829444; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=qi+Ew/rpwQdNekWtvCMQfio8DRksEPNbxq/gVYTc9Bc=; b=Y/pQBZmlwcAExvnqjqJZFySHrIRf41PoKazfCLY0BYX6/5yTg5VSQjUZzFmTrXQnQX thRGwdrhZaTg77t2xB1WvPT67QEVjVNTYr1ZmO7aUi5aJ2M0Hi9U+5Wt7dUcd4+ys0P+ 2uC0nRCjws79ETXN/O3pquC3LkjY9LazZtTiA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727224644; x=1727829444; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qi+Ew/rpwQdNekWtvCMQfio8DRksEPNbxq/gVYTc9Bc=; b=xH2ufTYAYls0V0XBNnzGdHtXTQ5le4K0EXcq3pRUzoM5CZ4LT9YsJw/RPZMc5NYtJa /orG9qawFPzY7G/y4+epjptIO3CNP8bbE7kA3sQBP1crqckVifscbyTuZpIGGAvjJCGu oyq+ysUs2D/27fTmZcrxqfSYR5iy+WhmN5DqxEULqn3dRPjygX/1U7V7nxv9Y+i8I/QE yE3wfac71yMY3HOGgZBagbA4OgWwlttHKr9KukkmY+apODP4cLw/MthjdRcf0ngWR/5a G+ATbPAtrkD7vDHELyDFF1gdqArvnrZHanvci3NQHv9XC2n2DkIaOcFDXW+imqI47yMr hdlw== X-Forwarded-Encrypted: i=1; AJvYcCU6DhLlOTuvSKNITE+VS6eSaP9tqyzpdehfRqIOWHRVfbufPFBrdisjVvbNy+/DsXoQS0mqQAGxYA==@kvack.org X-Gm-Message-State: AOJu0YyiGul89hXrCOm+sc8nZrZQeq/JxsBgyIJTunT9Sdd4aYiuKuVF tc7Qjzmgy5CAw6P1woXRuLopqNYwFkFtzmRaTWtljKewe5Rt9GBVBVvp+YUcHg== X-Google-Smtp-Source: AGHT+IGHpbtyH6wG5q8wpr8glm0LmNDVojnlHAVCXzzabVBkw4UaRXRI6IpMn0gx/0I09JmQAN/eSw== X-Received: by 2002:a17:90a:cb97:b0:2d3:d398:3c1e with SMTP id 98e67ed59e1d1-2e06afd7775mr1014848a91.36.1727224644075; Tue, 24 Sep 2024 17:37:24 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:234f:c061:7929:9747]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e058a0899fsm1409293a91.0.2024.09.24.17.37.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2024 17:37:23 -0700 (PDT) Date: Wed, 25 Sep 2024 09:37:18 +0900 From: Sergey Senozhatsky To: Chris Li Cc: Venkat Rao Bagalkote , Sergey Senozhatsky , Andrew Morton , Andrey Skvortsov , Minchan Kim , Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, stable@vger.kernel.org, Sachin Sant , linux-mm Subject: Re: [PATCH v3] zram: don't free statically defined names Message-ID: <20240925003718.GA11458@google.com> References: <20240923164843.1117010-1-andrej.skvortzov@gmail.com> <20240924014241.GH38742@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6542640008 X-Stat-Signature: i13qzk87izp1imp99oniw4jyd8wwkjsi X-Rspam-User: X-HE-Tag: 1727224645-210188 X-HE-Meta: U2FsdGVkX1/BpSwJV14pNufxw8nQi/D3z961S1BIvwixJI4JrPhT+N3m3PNGlKReTVn7vuSBFAJc7OrIV7A8Xl4mb0BoS4F4lKItQtYh8rgYorfcF7rVITn9fc9p8N/RoukZJ9ZL5Oo4lzaVVREjL82G6pIjazwG0OKryr5yJ0TlcPBvJA4w4qjrPz9sRUw6J6UHBAF+sylsjYqjmGpfeXmnrHpObkGQmXQquWfiE4qEcZyv73YDHZtdbbA8XM7hEpYntW2rfuVbxqEFOiQpuewST813BhcO4BQzXBtu7ww2H9oM+COSGVEAid/1YiTF6kT/wV7Ku1HoFCNEk9qU1XhfYPRD84DEfMN9v771gw12lgtV67dNosKUVcJ90yjaQmllAR0kZrN4stLY4Ed8AWxhA4NGKH1sRoMFZ3msXR8m1TZWYnXWTWbn21fFncsJsrH952IRUSu85eWVyhJuQAqj8eD1L4fYeYqDuLA6inGzNmtSWfYEbKgbya6aJF9ytaXZfnanY2Q8q8PgoqZUydYQVPUzyAEkFPbu7Zpzn870GCHOmtIT5Zms0N/nzfNzMWaBn5QGv3YuSCRo6lMvtUs0r/6re/TxT4kF2LZxjx1glGoqd4fwWR6YGEqfvTUM3XvDvMNoR3nIyXpBJJwx3PsOLTh8H91RYkDEaw+e9CV96qpuqXyXzlCuWYtZE9UMFx3YQOo/8o4cHJMtIXAHk9mwKgc7GMoV/m1jTxG40bAiC2Lnk0XHRAwB5dd6ZZhYZ41fCBNkghqtPnywxCqEWdsyutjUu9O2IjNil8B0rTh+ILh1UPCVEfQ6wZWYOuqMl8wxzLSxXo8Z3QRzPHXHHaHuqXjpb3NL1iNZPjzXn5Xv6CFd/cTY33pTVbCQyP/fAjforRAX7WDctEw5Lz52atowJRfQshQZUWjgum1CDp+PnYrx1/Dz4Ip94dyXBzx9VPJ69KW+uX7w+PYIVB5 uZoHzZJu dmNUgW0xunrRpdzasG5QUj1o+G6Byn3DImjrKNuNRcjQwlq32IbpDkBCko0X4AY+UDr3auVARcIgTFYiqAJvvDI7Q6ViypTWyqyJyKkvvaeWdawKM6ccOXTa/y+Je0RwVocbPYOw+i1H2wgoJPcU2sZDRD/w3cjgIkGhtzw0n3azW7wJ/itZgaGIaeLfTJB4zkLkPBnJOW+a/juuQfzQg/GX/riuBjzDTADTFC9zyr0sN9guAaCKGL/9tt/14VtoU2YzX5zU/Eqv+GqHJlT/9uzBad8ctOg0UpIU1rh8aEF1gZ2/p1n1BPw1fqusEwoG+PaCSJFTftnb7NY/yi0miip28RiKKa/huKf1GfaxKJ6FBo9szreMpjx3YRgFiuN93TsOV48ri7U2ofzhS2zUGq5kyuYoWsOqozjjg3DInTQfiZI4NMrZHd2VPnV1IUdVaA2euZBKUCDT5O/Yq7ckoCFz+vEgms3+gwPgE X-Bogosity: Ham, tests=bogofilter, spamicity=0.001102, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/09/24 11:29), Chris Li wrote: > On Tue, Sep 24, 2024 at 8:56 AM Chris Li wrote: [..] > Given the merge window is closing. I suggest just reverting this > change. As it is the fix also causing regression in the swap stress > test for me. It is possible that is my test setup issue, but reverting > sounds the safe bet. The patch in question is just a kfree() call that is only executed during zram reset and that fixes tiny memory leaks when zram is configured with alternative (re-compression) streams. I cannot imagine how that can have any impact on runtime, that makes no sense to me, I'm not sure that revert is justified here.