From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F5F0CF9C69 for ; Tue, 24 Sep 2024 20:13:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D24846B0098; Tue, 24 Sep 2024 16:13:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD4FD6B00AD; Tue, 24 Sep 2024 16:13:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9D096B00AE; Tue, 24 Sep 2024 16:13:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 993396B0098 for ; Tue, 24 Sep 2024 16:13:58 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5424D803B9 for ; Tue, 24 Sep 2024 20:13:58 +0000 (UTC) X-FDA: 82600732956.16.ECA201F Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf06.hostedemail.com (Postfix) with ESMTP id 6A886180006 for ; Tue, 24 Sep 2024 20:13:56 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=m0iv3Lbw; spf=none (imf06.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727208717; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0ZDIZphHaZQWBEelz0NI1LbACsabpfkNya5R+pJ2qNA=; b=U29zHzNUqGK34Qlq92BQXljpojwvsaAAA/D/arPc1faNV57ehNR9GyXWMoxSp2QD7/e14f HNhwM82x0/JxMEWtUVOw7sxWHqiLYrRURtPCwcD1kkqHrhQhs24R0d4jYrAGSIH56/ujCe dJ9s/IDA/jJQ3nanOPIwuFNILvPijF4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727208717; a=rsa-sha256; cv=none; b=ayf1NHqBswMx7QyoQZJfSi9vpbIv+8q6TNqT/ifqb1hM4CgzEzr8xpq+hdbSNPIsGT7VPk uHUnOJkb06CCkt1LgHK/mhN5Dm11tLsFXca68Lv89WEt1fIb3pLDB230jgV69hxbl1PdnM P32fu156v/xFcVTBDzwLvSmf0yz+9dI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=m0iv3Lbw; spf=none (imf06.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0ZDIZphHaZQWBEelz0NI1LbACsabpfkNya5R+pJ2qNA=; b=m0iv3LbwZ39btACpe8yrEQy4hM bbraWzShHNPMvB9jlsjdYgCKFrZ+3XPtPUKDBtqXkfyTRzcOYnv99R2b3trFfXxbQN1N/yubo2Z6c gCJ9QXAzPAxGr9XX+MpPn1+dbhWSXFvTvZgvdxNNZ5i4bmdnQIcLYMouO45MeaIiQB7EqKN0mnhns VR3H1Q1+05EgaFW+2b7gOfDPqhYUuF77XJSWRnCVy8TBr1i7ty7NcYZg0ra7Ys+CVTyoCPPgIk2Hb BtY+sg5C6Xh2MT2xJlwPmBccxTGwAV65Ym1djNgqcSAatJSi36f/FGFhA1K7YJWpaSxHE86s++bKX dQn+F0Zw==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98 #2 (Red Hat Linux)) id 1stBuy-0000000FDtT-2k0f; Tue, 24 Sep 2024 20:13:52 +0000 Date: Tue, 24 Sep 2024 21:13:52 +0100 From: Al Viro To: Lorenzo Stoakes Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH] mm: refactor mm_access() to not return NULL Message-ID: <20240924201352.GF3550746@ZenIV> References: <20240924201023.193135-1-lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240924201023.193135-1-lorenzo.stoakes@oracle.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6A886180006 X-Stat-Signature: 7acw3wise5spn1xuwufys9syik5gwm95 X-HE-Tag: 1727208836-707986 X-HE-Meta: U2FsdGVkX1/rjSVESZLfZjuSfZ+Brg5RReYo9UaxuxK2J5kKYpFdpLMf8gerNRB9K38JXNqax3k0aiYwh3H9UzGHgyGDg3vTQ9eTuVvSz1X13WCGcJlPq1mjPCO66SJJCY4iyeCVGvvBeUsz57EpkYZIJ6YByOsaxB5gsxVG4Jf6HjUsTfQsjsGfnf2p6zVu8V8U6/uZve6Q1HxprrLoAkkUZmOvWgFJfbHTlmyXwy43vsw7trULq3FWMELZVpM1w1GsQM6qzfzKDjr7+VgY2KeZTyZzoTLgZ6E4hskW0Dh5WvUsWLqT2RUuOZeZ85q9yAI99sS0jFPoi8Ae70kXVeYiZEC9I3RX0rHt2+C5Pt6afVNlquYmpP3buKfq3MgeJuL+5nIHT0QiyB1f4LmLmFnCswpsoB9HF45sPVo1QbCyUJySVQLktQfdTP7X4Gp4zASwiSwX0sv9kZmyacdfvheZKjvgqDGYr/An4au38UAwB3qdww+clAZrfM8L10orFWUAxziXyHSNQKsIshcPDRc2khbkYZkBIUtGHOIqmFBpSnU144884vcsG6XZLDDVZB0Dqd79LQQMV8GegFFinkI6jmHys5pb2WfowYMo33NXkfzww76m0vPAUqoSn63msas2dgnvMnTIwTxzehLor/c/cArhcL4gVABu2hjhVvEwVx4v0QjHPzmLLmDdXxu6QuQ4mVlVlG5NtxNoITkyq0lvLaoHPq/r7R0jzYValadO54ZOV30HZr+lLdrBxtgZRPhAQ2KMBeAdTrHgJ7+fvZ4DZzi43JJqA3nnMvR6Av8Lcr5V4bj4UVhbuOKUDFzRN20DseFmwpc+PaFDvqabL1DEf2gJI3zmys9KY8ifpbQffUeqYQCFz/kNx094esnXeml4edrduuYM71xfx8mUAbQw6pSPLFpZoOmiJROUKctJl1HU3Q2ifXvY+t7B3N4T7PQlqcE0iTplKc9+gZc 3uPUDr0g nczhA0XDz5icCM45Uba84YsQXu8Kc3LQxUnVrLSTfuOEt8cztSB5d6ZMh/t+9lz18nCV9Tp8MyEl+BkCHJAX1UsV7NnQK9OZ8pH+WwtpIIjCUFSH7JD5q0efAtU70QuZYALpGGW77yUiGIX7Exo8dLv0Q/JOCmgJuDD8mz6cxRxr7A1VnkMsmp94uDVoPCgiXM/dx5FnvSqC7VNNm13hCffTjmNkDViQTSK5xgij49Pt4IYDXGdLTvOan6I/5nXpaP1eGh7gkVTRa3KCO5bsS/mU+tZtlfAEO7qXOLAqYBpUtYDU/HorpwQL3GN51WNMs6/CsPFHC2/8ASIb5oLWEF6NiNuE6Vrr9fK6RTIYnMcTqDXLHfDysUqq5IYbgyG3ewz2LGCRBxUWCKuTpELPRkqzWkglGdO8zBNL7A6LwVclPlCPIJBmhFTsdHUkVFOUvhYEdBjMwR1NhatP5RYP8DhPkMFxN6DD98K4f5u3isF6wmss= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000041, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 09:10:23PM +0100, Lorenzo Stoakes wrote: > + if (IS_ERR(mm)) > + return PTR_ERR(mm) == -ESRCH ? NULL : mm; Pet peeve: what's wrong with mm == ERR_PTR(-ESRCH)?