From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE4BBCF9C69 for ; Tue, 24 Sep 2024 18:47:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 513CC6B00AF; Tue, 24 Sep 2024 14:47:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C3456B00B0; Tue, 24 Sep 2024 14:47:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B1EB6B00B1; Tue, 24 Sep 2024 14:47:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1DCFA6B00AF for ; Tue, 24 Sep 2024 14:47:26 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C17CC80324 for ; Tue, 24 Sep 2024 18:47:25 +0000 (UTC) X-FDA: 82600514850.23.3127E46 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 0ECF7140021 for ; Tue, 24 Sep 2024 18:47:23 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AP5SaqOb; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727203556; a=rsa-sha256; cv=none; b=Zx3AcYgNQCcLcEzlNxAyGGS4C6+bXzzm6XDAjMwq88OabS/WiSgxWgNuERJeREZj2OXmR2 EarzIDX/LpKvCe9rLzXbjayEzm8/w7fSE8V4vY1jjEh2eKfilS+wpknZqCOARLZjSKdon9 jVSruKrRaz9GOj2+e5IJnIL1A+uB2TA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AP5SaqOb; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727203556; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p3+BS+MRnQwhNIGbtVe9oac6l6UU5HQ4uGBgLcCqo9o=; b=tjb7j32Es2ljiah5T5ZT/zKvNRo5I9Bfy+UO+7brXKO4LffLafD6vXXJERMT09fiEW9Rho uy/6hwvX6D9NryTWriJSwlCOVi9Pt3RWZil9n7R5qHc5XXPM12lwDXf9pVSVLRL4NncSYR J3KDVZEbGZF6BNTInPGDgu2390j6Ehw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 284AB5C5CC7; Tue, 24 Sep 2024 18:47:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4541C4CEC4; Tue, 24 Sep 2024 18:47:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727203642; bh=I3xlCxCgRrlgcGeWrdThprr/PtPPIOpTGHY52oR0aX0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AP5SaqObdxk8329qse9ot1zeEYmDkYzoBbJyY9H75XKFBlGv9Q3soJarnbacBkcql XgG32wn4OlQY0qF2n3nLWJiGJLbv1TQc8K2Nwv8MLNkaKbWL7r7C3jBXiXtzFR8pSf j7UcKDzV38fkCnCK+GswlS9yomcg14zXG9dHbAz6N4S00ujDBP5dgeLd0f+ly3c6p/ VZ5siPNXjmpV8yBZd3yi3zVp8Z4vxnwAez+m8T3mT47e8gRnyGZmxVF+7MYYzuoLN9 iR4m+zd1xf2GoyoZu1Q3uhbFtBf8jzW7ccnWz14lj+/IECv2jbf8FUoE1GqYOBGirO h+71i/2/oDCpQ== From: SeongJae Park To: David Hunter Cc: SeongJae Park , Shuah Khan , Allison Henderson , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, javier.carrasco.cruz@gmail.com Subject: Re: [PATCH v1 1/1] selftests: set executable bit Date: Tue, 24 Sep 2024 11:47:18 -0700 Message-ID: <20240924184719.686727-1-sj@kernel.org> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20240924175500.17212-1-david.hunter.linux@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0ECF7140021 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 9h5yzn8b9jymqfujn1zpe6ocjjoquidk X-HE-Tag: 1727203643-130874 X-HE-Meta: U2FsdGVkX19ps8E1Zb0LzoibekmPzqqcYVpFdgEBuPZUxTSJTqfcrCkDC1jTN9pqhD2rY5mKUjsQDZTl9pCCZBWWBH+egHvthmoLuuDOyaz4hinCdPXbFlPqQYBeFl9PXusIiGv8RibZW3HfQUpLlSfTLGIZ+5ppXIA5QEmOh6yg43uty6zKU/d5nYA35BJgAQ+2k6GwnNR0KzIW/kot4BBlmLZlakYnPM7i9LdRmTx4RMrm9p4e/K3c+wzAYseQcPc5002JdnTnVhzfyssQ8J0gRmd+75FnGN41li9gp21FeJGGlP5ngwoW/rJ4wdm1ArS9k9cpRP7qiD+wkDuEA37kVl10nnN7HiD/se+ghB6mhvr3PCLbKzg7Vi+XhW8/O99SfBmDpkcrQVyzM9i0crmJuYrYaH6mDGs+MDBIE/sDhqJ6SzujarPnIjoh74dlh5690MRB/9fLcS9ae1m0/JLlYJfelfQXX3Vfy/tO6uFAKA07Db9p1ue8+tOxVGW7srSifEBdeoVENfSpEjIN9iquCN7E12tedZlRpEFUv2MPsq5XAZyt3AtT0lBuQiGMU/wH0oBK6T/Qgh5YBHMIhpV97x8W7by3qkrHuWRW7kDv8gKh8JxUd9X1zOOe/SWZ0daFnZOdhy581Jpj/4Z+X3ELlDPBCdiw3T1wFb7AW6+fUGCnqduFJSwZ1cBGw8NoQbmOBCPV+WMLbGZHvq2PXtk7hKj7vnMU9d2a+AWdV6pRle9L+gEckgK8PskKSWSqSMHUcCRwKU9sTp1827u9Qk5Ci8JKQbIgeN+vOoMyp3kHnmhGuF0mT+vIm/zrNwj1EMdvEUPUna3A/yPAZFa7ZpfOrb1shXWXTEkYW82KX/yAp2NQtQ4ZYK1fGfjQnmalktpu2loe/5trnsr4shB79EwYYgp6fFFhckCjJE381yatQ6JVqrzPMtn53Nd1C87Z+iknFwnbdXdXOCA9VQc RkE/zftr mNyCWAJYqz902eLsAPPrHrgOU17vdxme4GorZjEqVbGMKZjSaN12PGmMJwyEGaOMWaBUt4eWj6NxHH9s2pJ+1X6AzeJZSivGRPAUuiL5KRbOqhhN0rK2vGHvAXu1sYftExq1ECYr8IJT0AOuu3r66XDFNYl1qRyuUjrSTtC16RrALKZpoK0jIoJLkaXJHIiiLgcQQyF4nilzPy+raFWyAz5nHV981AL3brlstfsjj5OSM74buokh5lHA7en9xqMDulRpcht9/AM7Yq2W0N/ynI1udji604EbaoinN0Um5+XBJVVR0Yh4WaDndVImLcraOmWcxOc2OrSq0AZTukvlI4MGNqXN8dvEsQeh1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, On Tue, 24 Sep 2024 13:54:57 -0400 David Hunter wrote: > Turn on the executable bit for the following script files. These scripts > are set to TEST_PROGS in their respective Makefiles, but currently, when > these tests are run, a warning occurs: > > # Warning: is not executable Thank you so much for finding this issue and sending this nice fix! > > Signed-off-by: David Hunter > --- > tools/testing/selftests/damon/damon_nr_regions.py | 0 > tools/testing/selftests/damon/damos_apply_interval.py | 0 > tools/testing/selftests/damon/damos_quota.py | 0 > tools/testing/selftests/damon/damos_quota_goal.py | 0 > tools/testing/selftests/damon/damos_tried_regions.py | 0 > tools/testing/selftests/damon/debugfs_target_ids_pid_leak.sh | 0 > .../damon/debugfs_target_ids_read_before_terminate_race.sh | 0 > .../selftests/damon/sysfs_update_schemes_tried_regions_hang.py | 0 > .../damon/sysfs_update_schemes_tried_regions_wss_estimation.py | 0 > tools/testing/selftests/net/rds/test.py | 0 > 10 files changed, 0 insertions(+), 0 deletions(-) > mode change 100644 => 100755 tools/testing/selftests/damon/damon_nr_regions.py > mode change 100644 => 100755 tools/testing/selftests/damon/damos_apply_interval.py > mode change 100644 => 100755 tools/testing/selftests/damon/damos_quota.py > mode change 100644 => 100755 tools/testing/selftests/damon/damos_quota_goal.py > mode change 100644 => 100755 tools/testing/selftests/damon/damos_tried_regions.py > mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids_pid_leak.sh > mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.sh > mode change 100644 => 100755 tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_hang.py > mode change 100644 => 100755 tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_wss_estimation.py > mode change 100644 => 100755 tools/testing/selftests/net/rds/test.py However, a very similar fix has already posted [1] and merged [2] into the mainline. So, apparently there was a trivial race. I'm looking forward to your next patches for DAMON, though! [1] https://lore.kernel.org/20240827030336.7930-4-sj@kernel.org [2] https://github.com/torvalds/linux/commit/8c211412c5dffd090eaea5ee033cd729f8e5f873 Thanks, SJ [...]