From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A19C3CF9C71 for ; Wed, 25 Sep 2024 00:22:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4F866B0092; Tue, 24 Sep 2024 20:22:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFFA26B0095; Tue, 24 Sep 2024 20:22:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC77E6B0098; Tue, 24 Sep 2024 20:22:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ACD756B0092 for ; Tue, 24 Sep 2024 20:22:10 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 57EF4C05F8 for ; Wed, 25 Sep 2024 00:22:10 +0000 (UTC) X-FDA: 82601358420.07.3986380 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf18.hostedemail.com (Postfix) with ESMTP id B46BB1C0013 for ; Wed, 25 Sep 2024 00:22:07 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ncoczn7Q; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727223609; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B3yhvBKUScyFxzbiWsewz839fBShVEbHbZfYacnGUZs=; b=KSGy2d9If2byPr0bNr8PL1j7P4Eyl2v3wfC24X8CRyBUKg61mZqJRblB7e/+pVe1loipYj stz7x4BE+DVrshM580qPTKKcbPaNugojoolRxULa7ehTgwUw5/9aUsRrqKIvtv4Jp0GdMP 64l8yU0SXFntkglkdspODwbPHhdrP+A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727223609; a=rsa-sha256; cv=none; b=oKCvzyAV0IifM1dTH9Y7/ZzB96lz2cV8bXbl2t7WfEk2cLTgJJIK6lIgUdyAhxnBPb6XqL DykspgNcROPlFoNt9jxypOKhLJrEOtFBSJw7+vJompeGJuPQWYTopW7gEVQWsae5l1wGnm egLywsmgBI3jRlj1EQjtLvbN0cU3Ee0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ncoczn7Q; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id CDA50A42997; Wed, 25 Sep 2024 00:21:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66369C4CEC4; Wed, 25 Sep 2024 00:22:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1727223726; bh=86N1BHrLc+oKQUnSbaTTDKMnP1B4/VW9d87f4a/noM8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ncoczn7QiVu2Ohyg8gx2deBCr+8KX6tpun3s4tBCBlv+QOo3z69pM3q6DpYilGb21 qDscpMbsT6EHeIj7DIrSynCq0hRnG8VDQkI38Ipi6+vqYu6Pk7DnQceLLmcpaGrpjH G4Cb8pvu9Zk9RAJv0QTNpRqtn/KKPlkFUtpTPU+I= Date: Tue, 24 Sep 2024 17:22:05 -0700 From: Andrew Morton To: liuye Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmscan: Fix hard LOCKUP in function isolate_lru_folios Message-Id: <20240924172205.5068e86430873b09b75f8538@linux-foundation.org> In-Reply-To: <20240814091825.27262-1-liuye@kylinos.cn> References: <20240814091825.27262-1-liuye@kylinos.cn> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B46BB1C0013 X-Stat-Signature: 96663f6818awgwi4z7tt8x3yj88i799n X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727223727-891121 X-HE-Meta: U2FsdGVkX1/quIASBLzfuKcFSnl54YBPxjQvr7WLhh5Wd5CJnITxNdzpoguRXpG1tlLo0CWzEK0PcsEKYqCkDfO6E+cw8mHWdPUxvTSW+3B5LSgm8oYadD2MNlh5s1Stdyv7Jjr7uaC+SSeV4nupQqVIc9IhXPelTST2dmFSHvNzk8e5ZMIxCrWzDt5ovSfFIAtjagSjgtuQEbItWIxguXPcdczxRa4gFiGL7782gyRfSe56lHgcsM82TSQUUpOm08s0O+Yq3cmoxgN5St/BBFgY/bJo2AnCg1X2x/Cpm/xz48+/pmKN5S1CjeJsGlyZW0QBk7rAsoHZN0+oCKK9N1RC9ufF1qsg7ZcS7EUXntceTayIoubEPC+OC6GcSJ1Cs8SU6K68ZXe8n0duUQ7yRcSS9GiMfCkQKTMABT44qg7LYBaQrBsI7A+M5mBRPVj73OhhqaukXQ4wFf/acyzKCg+9kt105lr3EgItvEi+GJPjpIL+OxuL/HgH3DqexVB/mNKluu7KtgDSnNi9e2xq1bcz1eh59ZrUSRME3H2ufshecbnIw8idONX0VL6Ced668Yxj5b6BtB5YJPE70N2JpA4frcIbL9+j0mClwWVE+MkEm53X8+Ntu3s1Tr/9IqcFuK6M8670Ww9drOdJdJR5BAgLgIpjekc3KnBM0O8q75XsiGG8+HcrHi07ZI6TU+uH1afgYegNk4MwfspE6vyux3fj5CjItAAH4z8RgOcXKa3eorxVAxVGmL0e5tt9c7uonucvXfGt69HrGMGZ4e6nC81X4TBbvVXi+6wphLA1EDOkrV8YI9LINXv4lyjwc4p08yL+8W/0ja8C8Y9sJyKg6lAN0Gv2YzzRJ37LxToUMPa/y96Fbb6pO9HBVcrIj6i9CI/9LxV0DQOM63ktN/7HDI8EasRfLYfU0iLAZdva+0BW5MkSCi4Q+rXePEDemBjhVZNOM1OftbO0xcotsqz pWENcC1f QGzcj2/zanEmFC+fAU2QpxUVTDKL/0PepSr0gQOiTbB4Ump1j3e3yD8safSrmVnTvJby/8yPXJsLcxdJBcsjlckVDT9Z5FQWTkp1hdLIRqHgZV5vqzBp52ksVvGs6C2yLC9ey0RHe9pU0FK23yil8fY6UdpfflEvCJt5yqqtyHusjExALNUOZY+7LH35uBf0VpvXYLvCE4Mj8iMwHxu33uGo3Z3x47w/b0keEwZrqhIji7HjpGpc1UyEXbHN4LCOFCumdI+LgVneKtiW5OMQUdVG+AB6ZXaOb086Cc0yVkEO3gm4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 14 Aug 2024 17:18:25 +0800 liuye wrote: > @@ -1669,10 +1670,12 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, > nr_pages = folio_nr_pages(folio); > total_scan += nr_pages; > > - if (folio_zonenum(folio) > sc->reclaim_idx || > - skip_cma(folio, sc)) { > + /* Using max_nr_skipped to prevent hard LOCKUP*/ > + if ((max_nr_skipped < SWAP_CLUSTER_MAX_SKIPPED) && > + (folio_zonenum(folio) > sc->reclaim_idx || skip_cma(folio, sc))) { > nr_skipped[folio_zonenum(folio)] += nr_pages; > move_to = &folios_skipped; > + max_nr_skipped++; > goto move; This hunk is not applicable to current mainline.