[PATCH] mm: kfence: fix elapsed time for allocated/freed track

[PATCH] mm: kfence: fix elapsed time for allocated/freed track

[qiwu.chen]

Fix elapsed time for the allocated/freed track introduced
by commit 62e73fd85d7bf.

Fixes: 62e73fd85d7bf ("mm: kfence: print the elapsed time for allocated/freed track")
Signed-off-by: qiwu.chen <qiwu.chen@transsion.com>
---
 mm/kfence/report.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/kfence/report.c b/mm/kfence/report.c
index 451991a3a8f2..6370c5207d1a 100644
--- a/mm/kfence/report.c
+++ b/mm/kfence/report.c
@@ -109,7 +109,7 @@ static void kfence_print_stack(struct seq_file *seq, const struct kfence_metadat
 	const struct kfence_track *track = show_alloc ? &meta->alloc_track : &meta->free_track;
 	u64 ts_sec = track->ts_nsec;
 	unsigned long rem_nsec = do_div(ts_sec, NSEC_PER_SEC);
-	u64 interval_nsec = local_clock() - meta->alloc_track.ts_nsec;
+	u64 interval_nsec = local_clock() - track->ts_nsec;
 	unsigned long rem_interval_nsec = do_div(interval_nsec, NSEC_PER_SEC);
 
 	/* Timestamp matches printk timestamp format. */
-- 
2.25.1

Re: [PATCH] mm: kfence: fix elapsed time for allocated/freed track

[Marco Elver]

On Tue, 24 Sept 2024 at 10:50, qiwu.chen <qiwuchen55@gmail.com> wrote:
>
> Fix elapsed time for the allocated/freed track introduced
> by commit 62e73fd85d7bf.
>
> Fixes: 62e73fd85d7bf ("mm: kfence: print the elapsed time for allocated/freed track")
> Signed-off-by: qiwu.chen <qiwu.chen@transsion.com>

Good catch...

Reviewed-by: Marco Elver <elver@google.com>

> ---
>  mm/kfence/report.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kfence/report.c b/mm/kfence/report.c
> index 451991a3a8f2..6370c5207d1a 100644
> --- a/mm/kfence/report.c
> +++ b/mm/kfence/report.c
> @@ -109,7 +109,7 @@ static void kfence_print_stack(struct seq_file *seq, const struct kfence_metadat
>         const struct kfence_track *track = show_alloc ? &meta->alloc_track : &meta->free_track;
>         u64 ts_sec = track->ts_nsec;
>         unsigned long rem_nsec = do_div(ts_sec, NSEC_PER_SEC);
> -       u64 interval_nsec = local_clock() - meta->alloc_track.ts_nsec;
> +       u64 interval_nsec = local_clock() - track->ts_nsec;
>         unsigned long rem_interval_nsec = do_div(interval_nsec, NSEC_PER_SEC);
>
>         /* Timestamp matches printk timestamp format. */
> --
> 2.25.1
>