From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B6B2CF9C6B for ; Tue, 24 Sep 2024 06:15:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD4606B009C; Tue, 24 Sep 2024 02:15:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A82F86B00A7; Tue, 24 Sep 2024 02:15:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FD716B00A8; Tue, 24 Sep 2024 02:15:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6D9B06B009C for ; Tue, 24 Sep 2024 02:15:06 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E8A72A17B2 for ; Tue, 24 Sep 2024 06:15:05 +0000 (UTC) X-FDA: 82598618970.12.A4CBDF8 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf20.hostedemail.com (Postfix) with ESMTP id 1AD221C0008 for ; Tue, 24 Sep 2024 06:15:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EwWFa99W; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.48 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727158407; a=rsa-sha256; cv=none; b=dgDHz7lTuC04rMrt+d0UeXoNRajWkU7qJ6hiKBB6udY0b4ZAM/velA58jSkncwhJ1pG4nG Ck2R166Dle8WBoEQ2ZqRN4EEf5GE7Kqy5ubfjsgHYFeAENRm32JXHQb6BjM7zM911ga3tX U8YQipXuzv68wQ27BzrS7Hp5YOSebuw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EwWFa99W; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.48 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727158407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M/cIbiowMQaZoW1B5fHApBkUYwv504pPWS+xmmpAlNg=; b=8B+P/DgulSvMND+Wp/t7fFEFNmbtg3UfAACRSw74ltJsXfrt1qqphq5lEiptC7hkdK/54c A7MRm/BRafNT323faPbnkqE1PSrtrKUmOepoNTJXroczo0YIysKK8PUV5mQJImTgTiYWED LM2FfZl0YjBBZlBe1AWTYYlmvL0De00= Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2d8815ef6d2so4062979a91.0 for ; Mon, 23 Sep 2024 23:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727158502; x=1727763302; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=M/cIbiowMQaZoW1B5fHApBkUYwv504pPWS+xmmpAlNg=; b=EwWFa99W9YD9kwoMIPcT46M+v+HyA+vdDxSfvqR3BkfbqlDlJ6mn+kK/yJt4WDiM/t mxzp2r2iAO55ep/9Lh7r0s7ePVrzx5ZhDuT4xjcy3/KQxVVX8ffhQrR0FQwdF12G5Td9 RubUPPmwZyc8OtF2QbV8vr4UC59zaJ+V8R6Cw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727158502; x=1727763302; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M/cIbiowMQaZoW1B5fHApBkUYwv504pPWS+xmmpAlNg=; b=wA41zLDl6as9JzK1I6YUcUf1tfnQcTGsNyqAKTAby7OKEnYERRj1GY5OOX4Pe0jj7d fpxcM01DO8FBwLv0ahfv7wFk53OZVnHK2LlEFzcW5AzNA0Qgbb5Fm7zCKWC2pP5QLnqs fHBTPVbYLQYUuomqHZ8cePyAnUYx2OWkR+/saFA9CJUqzLBd3tbimJPhGaO7lBzQcDZv 6HnRbTAoRAzj9Bbz1KaQz4Ki8HboW6lU4HadrYHmE5ixaWMmTQCp41sK6U3z6iREiVGr whqwIoZ37lTHnmbtgw/orqWUu64nsuJRMii1/BfHddYujVWOpYD8vS+9xM2/B4QsKBcw qV5A== X-Gm-Message-State: AOJu0Yx1rhqRCT5GytLyd6sIy3AgXMDFcYvJznLKttJWKdcKxveBadGC 6VlbQTygu2/V50cyJxeYOV/Wc9IAf4T0IP6KS0FUMROCisfJsVenOPc4Gdqkj2D1AinN01y77I8 = X-Google-Smtp-Source: AGHT+IG3Q2wXTPV4cxmrpOoEx3KVRKDe5Gw67YmcTI+UzH3u/ksEVTI+nitdbcgUd86AZw+SMUcTBg== X-Received: by 2002:a17:90a:fa95:b0:2da:5863:6f88 with SMTP id 98e67ed59e1d1-2dd7f40efdbmr18430824a91.11.1727158502543; Mon, 23 Sep 2024 23:15:02 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:93d1:1107:fd24:adf0]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e058f782e2sm649000a91.32.2024.09.23.23.15.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2024 23:15:01 -0700 (PDT) Date: Tue, 24 Sep 2024 15:14:57 +0900 From: Sergey Senozhatsky To: linux-mm@kvack.org Cc: Andrew Morton , Christophe JAILLET , Andrey Skvortsov , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCHv2] mm: do not export const kfree and kstrdup variants Message-ID: <20240924061457.GO38742@google.com> References: <20240924050937.697118-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240924050937.697118-1-senozhatsky@chromium.org> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1AD221C0008 X-Stat-Signature: 8p5w1myc6q7fgzrj8qfwczr8xqnofyk4 X-Rspam-User: X-HE-Tag: 1727158503-810473 X-HE-Meta: U2FsdGVkX1+kjE5JQiUB+8CzW++kuQLE62UXI8cXUpQuUVIsrKCu0fpblNqrSh6cY/v8swn4//9oec6t/0FM/HUqmZF5FC1wCx2aNlOI6eJMy+38JFl2a6VDo9vGIfbP+uDuKcWf0oRwKflinqgRhWmWL7Zi+dT6F/RpRSh0uqCOkUMJMs0g6aGGeHADVWQJCBBb5bOWd2YVxoL8DW1AdyUpHCqiB6WO3Zrk8VAVqbAlFq6SpWI8CFi1tJ3zNa9UM1R1GlIAon/Hddrxg6iwXmoUcbZEcIG7wGcXMnEMrLVYzONT148LKtQwbiS3eRWzQSnVyX+WYlO2mFCvpSCQtT80waskFEmsgykJyjsFkhwDgt5df7Rx73bGKdMdr8/XZa1RSql47VuzCIR0yoQuvxduj/4KuxyzSqdtapIfEGUwOOfs468tsvKyPu2tzwIWE37KFwlLYTcPqEuJFw9DB9XO5+CxL9kpxO5du5qm5kDGiobSly7Jdg1eOWBKRlo1AkwjLKvrMc7IEvo4f0JKkq4rHQe9yQr7xpngvoJAGVIfg+r8KQ2vo0f8ZPzUoPMadcwr/zoFaEofC84H2fSvOO9RNZwTcCOi7SxG4ruVuQOLQtZQ8tberGyKEy9vBBphNtJK6Enufi0OOoy/9+QWEp+Hfv7ADdgWOA1Z2+vudcJo9qbdG/cIc9/iBY0BBmO8CUy1z777kFAuTwCk+EtdJ2MBDIkBeXbeKkMOKQJcjq37CMvQkuvsrPfnH5oC1vZBckphu/42CsB7ouB/GGLRedIBAxt/A4SVZHG9/jerho52acSW4AqoCOiz37fFJDe0KqTpfLjsH3z0gRYM5lQGux/eRQ411Jly+znHIIJBfc6wpatPf1UBgCT9hQbp3eArS/wqEkRhzWBIWSiHaae2OZZfdSSVv8yOgfJATv/81LRttuON43eL9QcdLsgZnMeGWrr8hXtSCshzBUznrvH PXWorlrT VDYx4afiu9t47KrenzMZssm6g7Mk16tHViwnexmABxOM+7CNwnjRrKLclkWCPZwLzdUCaa3XXGoAKcI4l/hQ3hQCpBKN45CyY+RhOpLYN9ej576DHxMNlmnNOTGRkjKKJOVtYR6xUcSKgkocQTwIf3W5cmXuTIBiaAF2tp5IDqkOHVHCcDgvEc1nHaW9Qw6SU0UF+foUA4q61EXIQj5oKcBEJi7FEtcdaBVMKyveYyIi7A+FKVjegrqf2uKzZKI6RmRpjH2g780sLmlOPLim0csJmz+f1w18UiGugKcZ/N767At4YjtM40cl2WSARXlb56APxkw7Tx9Fb7iJwlJn2HEzpljyMM8ovFjH2jS+NhokOZe2oMYMiIljvmQh7l92FVXqZdxeg0qbPlB5VRrXtLyCmvoty157ZmbwcA41AWDTcm1qW/dov7qHesw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000127, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/09/24 14:08), Sergey Senozhatsky wrote: > Both kfree_const() and kstrdup_const() use __start_rodata > and __end_rodata, which do not work for modules. This is > especially important for kfree_const(). Stop exporting > these functions, as they cannot be used in the modules. Just for linux-mm visibility, consider this patch RFC, more discussions on this at [1] and [2] [1] https://lore.kernel.org/linux-kernel/20240924054151.GL38742@google.com [2] https://lore.kernel.org/linux-kernel/20240924054951.GM38742@google.com