From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7175CF9C72 for ; Tue, 24 Sep 2024 05:08:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40ADC6B0085; Tue, 24 Sep 2024 01:08:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BA256B0088; Tue, 24 Sep 2024 01:08:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 282506B0089; Tue, 24 Sep 2024 01:08:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0A2436B0085 for ; Tue, 24 Sep 2024 01:08:35 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A6EB11417FB for ; Tue, 24 Sep 2024 05:08:34 +0000 (UTC) X-FDA: 82598451348.17.3D4FBBA Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf04.hostedemail.com (Postfix) with ESMTP id C9AB74000B for ; Tue, 24 Sep 2024 05:08:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="mLp/cmXQ"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf04.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.49 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727154416; a=rsa-sha256; cv=none; b=guiSvH8IVGCIzciUyXu+MDRi8Wiqu0qjJv4v+BjhszN/aape3roxI8rv+cqIKwBN2QWXZG EoQzThGAqfMEpWQ8UFVHoAt/BxI8RK162OYJE5UAAJOF3VkTGKcpzTJQaCQHvq3/ygpjvM W19AWn/GHYa2Al4RnzVzPufMq5DUSnQ= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="mLp/cmXQ"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf04.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.49 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727154416; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T5MHNXC48yAvUD19hWxguon66WOWFP3QfJz/MDtRd9k=; b=AbnwJDZLnIseHaSMLZj5RK2+/c+joic2WhLLCwCRu6t/2PHJEj5uWvllaDNGR01nxsAUkm dJuPFqdxB5ELbDDgT+cHY2mSUQrNydPOya64niSIfi9EG++xxRN02kcVfpZFEuqQq3zRUH +Y7+O/FyELdjzHRuh9sGmOX5Wm6v7+w= Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2d86f713557so3323758a91.2 for ; Mon, 23 Sep 2024 22:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727154511; x=1727759311; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T5MHNXC48yAvUD19hWxguon66WOWFP3QfJz/MDtRd9k=; b=mLp/cmXQIl4KQFsYD8WDZ+ep93IjIWame6XKsy/nNEa1BEPF5HZTckc+3/vKqE/eZO nCmsN4HRa7l3jpE6skeSn/p1+C6c0LJITmf42D76aECnOXOQZxFw96JASWi03r0amPVP m1C3uBhjP64TYvqBQCRcU1KSbZ9a4JAnQnKMA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727154511; x=1727759311; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T5MHNXC48yAvUD19hWxguon66WOWFP3QfJz/MDtRd9k=; b=i4wxi8w2pgf3xlgbp1DgtVxj0nsE6FpzoGWiUT41KiyQdZBnhl9w6f8P2roa3uiOvM 8wtV6tZPOJiLLlzAfuytVA9wkUCy1/KDM114XjxcN10otBxi2LBbkzIF+JbvO534ZiS1 vE+bhwbMUAwNI+WmsOJz1LZ5ENC4+Y7e+ZWc9l4mw0jeaGoStTaCvmg8d4QRNlgtm/0r G5mGqdMHArCuBwh2Yo/+7knvv7JHV/1FRksrvhRU34dxIzAC2PHqtIzzMQDRPmWPoN7N XHBUE9mY6zuzWxVU7EAYktshDImCxcoEbDvSz/ywFkK6ULp/IHSrkRWqcsKf//+iTUpf 9nvQ== X-Forwarded-Encrypted: i=1; AJvYcCWfbUKskDr4lBbFq9d+BiRcyZzVDUB67yvGkNq3xno4jRoxu0u/9Rg+NFbLl7Hfwb4kPZCG5BJYYA==@kvack.org X-Gm-Message-State: AOJu0YxbVLKv1XqD1qhhEkDAtuQM5pAy3WGl8f49nzLMyeYvcuR43UpU Jy1UQQpW+nOf7Nk3MeYDFLdjpcMfS9j6I+K+8QLBwtIdht1F0viUita4M0aPAA== X-Google-Smtp-Source: AGHT+IEUQCKq2YvocXT3vjh1QvF28Z4378Dk8hrmVQ+3NgqUNYvbKV8EmP1Gm27lAJcZAGAzo5qtxw== X-Received: by 2002:a17:90a:8401:b0:2c9:e24d:bbaa with SMTP id 98e67ed59e1d1-2dd80c960ddmr16672219a91.27.1727154511383; Mon, 23 Sep 2024 22:08:31 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:93d1:1107:fd24:adf0]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2dd6ef9354csm10297994a91.50.2024.09.23.22.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2024 22:08:31 -0700 (PDT) Date: Tue, 24 Sep 2024 14:08:27 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: Andrew Morton , Andrzej Hajda , Christophe JAILLET , Andrey Skvortsov , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: do not export const kfree and kstrdup variants Message-ID: <20240924050827.GA676153@google.com> References: <20240924050351.675925-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240924050351.675925-1-senozhatsky@chromium.org> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C9AB74000B X-Stat-Signature: 35fbdy1fij7wzkm348rwhxm1spz57eyk X-Rspam-User: X-HE-Tag: 1727154512-393788 X-HE-Meta: U2FsdGVkX1+VczZlzAysLOY8JBBiBjzVawo6MYV7ZKGHZA04giyJoPe9kYGktD48yZHW2V+x4nn/RjnLKYPO3hrvINylSnlm2VEjoUQPvqMKP6rfrlza2sAj/hh2awlnggcDEQ4ToYQ0zj46BdM34fqb5MOqJdXHLR4dYzxbarl9879N9m8yEQbbjZ/uxYJXwtxjX7KTEezBySoXISdmaQuAxAW0/DkAURKxgjfMigN8Wz9ck0KwaY7MD+u/RofJv0CGsUnrpX0e/EfanLP1SE9x941l/lCZspGfQB9xnpQ1GKCIa0nDB8P3WWDuSoYGUpml+xVyTVsmG1CMv64Pn5bfNTC6igNYWF6jbDLiwvQ+RCKcx8VOtRRqjCvu9FaFyJVxykH8W5sEcJfNRD0oDhefmelYavINgYUaXjcetBsSi0QBDdk6zW3PR73rgkJyk3vK0uT6flHTy6NYuQik5qTcBxg08mGLSBN0jhoPiLwphrQ7V9dtLfccJPzng1UAfwMGsxHGim6GRUMwjS4ZrdQp1Rlkdfuz/H3ZCcikuBtwmLz7YrI+ChCIkGGgf+HtiWNLGCIqYXs23s1ClSqYveE/Akhe2X6QlHFVaQ8NxciH+W68G3CJHZtkEVPX6ODqv4Irhvgr0PPAeEYfgyZPkCbl1BT1caEa/a42OySyaPvy1zYf/fw4SNNjCUAMFoUTyD/pMppPEC3dsHTayGR8VaR5Id+0TwCEaRM+o5H5hJhndXB/U6I2uqdIu4YCfToolxrb+8n0W9E3pRBvBa4Y/UysZAHMlzv6ADcNecnyT2kNupwL8ByhsE8ZR4+LK+Z6BGhi2oyuAVQdChP44vwkm+jQ/LVwH3uM7k6hmoDmOYa5preQARkodoCaQrCiMbAKzGBT2hsDPyc2ln4PkbXqV7MLUJkQuKNL8JOc7NctuwXe2celvfg3HJGQ1GB0HyvjnWzp2g2CIFGYx/hPk0H t1qaMWXZ jkvghIlZoxdLkK2kauh5rRpoyLqeCT4A33nE3s/x+TFGJJ+Vbo/3TTdJYY0rGuZySZMTiugTZqCDMPVJlfKkXHcUsAprXmg70KUu/b7B7WPUYMGEt8u3M8ytKu3GNuLG3LRnEE0yjXRTXwgXEKBzzQyf8sD/TIijXPrFRsqsMax+qGZUHVgIJj9J7alXl3PS0mU8GQ3rX7B1XLkMqWO9irfQcPjTaavXj+Gfg3nVeWfqC+b2Y+2W9t7DXJ6lF/zZQ4YVp72ZQqAQurDDPfmimgH8QMeFaY03bQ0yJjgEzIzGIuHch8YU7bo3uqrq2N4DarJBl22pMY6Z1UKf7mcfaLeFu6qWYu6gO+x1RNnzXS2ALN4TFVZ1QJqYjG0sPIqe9OqORgjHUvycRECx17LFK93K6xS7Dv7IxN5tA5LP+j5iaJHo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000725, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/09/24 14:03), Sergey Senozhatsky wrote: > Both kfree_const() and kstrdup_const() use __start_rodata > and __end_rodata, which do not work for modules. This is > especially important for kfree_const(). Stop exporting > these functions, as they cannot be used in the modules. ... and of course I forgot to commit the kstrdup_const() part. Let me resend.