* [PATCH v2] selftests/damon/access_memory_even: remove unused variables
@ 2024-09-24 2:14 Ba Jing
2024-09-24 4:08 ` SeongJae Park
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ba Jing @ 2024-09-24 2:14 UTC (permalink / raw)
To: sj; +Cc: shuah, damon, linux-mm, linux-kselftest, linux-kernel, Ba Jing
By reading the code, I found these variables are never
referenced in the code. Just remove them.
Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
---
Notes:
v1: https://lore.kernel.org/all/20240903034300.10443-1-bajing@cmss.chinamobile.com/
v2: Modify the commit subject and commit log.
tools/testing/selftests/damon/access_memory_even.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c
index 3be121487432..a9f4e9aaf3a9 100644
--- a/tools/testing/selftests/damon/access_memory_even.c
+++ b/tools/testing/selftests/damon/access_memory_even.c
@@ -14,10 +14,8 @@
int main(int argc, char *argv[])
{
char **regions;
- clock_t start_clock;
int nr_regions;
int sz_region;
- int access_time_ms;
int i;
if (argc != 3) {
--
2.33.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] selftests/damon/access_memory_even: remove unused variables
2024-09-24 2:14 [PATCH v2] selftests/damon/access_memory_even: remove unused variables Ba Jing
@ 2024-09-24 4:08 ` SeongJae Park
2024-09-29 22:00 ` SeongJae Park
2024-09-24 4:14 ` Dev Jain
2024-09-25 17:38 ` Shuah Khan
2 siblings, 1 reply; 5+ messages in thread
From: SeongJae Park @ 2024-09-24 4:08 UTC (permalink / raw)
To: Ba Jing
Cc: SeongJae Park, shuah, damon, linux-mm, linux-kselftest, linux-kernel
Hi Ba,
Thank you for revising this patch following my comment.
On Tue, 24 Sep 2024 10:14:26 +0800 Ba Jing <bajing@cmss.chinamobile.com> wrote:
> By reading the code, I found these variables are never
> referenced in the code. Just remove them.
>
> Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
> ---
> Notes:
> v1: https://lore.kernel.org/all/20240903034300.10443-1-bajing@cmss.chinamobile.com/
>
> v2: Modify the commit subject and commit log.
>
> tools/testing/selftests/damon/access_memory_even.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c
> index 3be121487432..a9f4e9aaf3a9 100644
> --- a/tools/testing/selftests/damon/access_memory_even.c
> +++ b/tools/testing/selftests/damon/access_memory_even.c
> @@ -14,10 +14,8 @@
> int main(int argc, char *argv[])
> {
> char **regions;
> - clock_t start_clock;
> int nr_regions;
> int sz_region;
> - int access_time_ms;
> int i;
>
> if (argc != 3) {
> --
> 2.33.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] selftests/damon/access_memory_even: remove unused variables
2024-09-24 2:14 [PATCH v2] selftests/damon/access_memory_even: remove unused variables Ba Jing
2024-09-24 4:08 ` SeongJae Park
@ 2024-09-24 4:14 ` Dev Jain
2024-09-25 17:38 ` Shuah Khan
2 siblings, 0 replies; 5+ messages in thread
From: Dev Jain @ 2024-09-24 4:14 UTC (permalink / raw)
To: Ba Jing, sj; +Cc: shuah, damon, linux-mm, linux-kselftest, linux-kernel
On 9/24/24 07:44, Ba Jing wrote:
> By reading the code, I found these variables are never
> referenced in the code. Just remove them.
>
> Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
Reviewed-by: Dev Jain <dev.jain@arm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] selftests/damon/access_memory_even: remove unused variables
2024-09-24 2:14 [PATCH v2] selftests/damon/access_memory_even: remove unused variables Ba Jing
2024-09-24 4:08 ` SeongJae Park
2024-09-24 4:14 ` Dev Jain
@ 2024-09-25 17:38 ` Shuah Khan
2 siblings, 0 replies; 5+ messages in thread
From: Shuah Khan @ 2024-09-25 17:38 UTC (permalink / raw)
To: Ba Jing, sj
Cc: shuah, damon, linux-mm, linux-kselftest, linux-kernel, Shuah Khan
On 9/23/24 20:14, Ba Jing wrote:
> By reading the code, I found these variables are never
> referenced in the code. Just remove them.
>
> Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
> ---
> Notes:
> v1: https://lore.kernel.org/all/20240903034300.10443-1-bajing@cmss.chinamobile.com/
>
> v2: Modify the commit subject and commit log.
Thank you.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] selftests/damon/access_memory_even: remove unused variables
2024-09-24 4:08 ` SeongJae Park
@ 2024-09-29 22:00 ` SeongJae Park
0 siblings, 0 replies; 5+ messages in thread
From: SeongJae Park @ 2024-09-29 22:00 UTC (permalink / raw)
To: Andrew Morton
Cc: sj, Ba Jing, shuah, damon, linux-mm, linux-kselftest, linux-kernel
From: sj@kernel.org
On Mon, 23 Sep 2024 21:08:45 -0700 SeongJae Park <sj@kernel.org> wrote:
> Hi Ba,
>
>
> Thank you for revising this patch following my comment.
>
> On Tue, 24 Sep 2024 10:14:26 +0800 Ba Jing <bajing@cmss.chinamobile.com> wrote:
>
> > By reading the code, I found these variables are never
> > referenced in the code. Just remove them.
> >
> > Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
>
> Reviewed-by: SeongJae Park <sj@kernel.org>
Andrew, could you please add this patch to relevant mm trees?
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-29 22:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-24 2:14 [PATCH v2] selftests/damon/access_memory_even: remove unused variables Ba Jing
2024-09-24 4:08 ` SeongJae Park
2024-09-29 22:00 ` SeongJae Park
2024-09-24 4:14 ` Dev Jain
2024-09-25 17:38 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox