From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5928BCF9C6F for ; Mon, 23 Sep 2024 18:35:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D5616B007B; Mon, 23 Sep 2024 14:35:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95EAA6B0083; Mon, 23 Sep 2024 14:35:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D8496B0085; Mon, 23 Sep 2024 14:35:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5C10D6B007B for ; Mon, 23 Sep 2024 14:35:04 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 053821A0F18 for ; Mon, 23 Sep 2024 18:35:04 +0000 (UTC) X-FDA: 82596854928.18.B132FB1 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by imf15.hostedemail.com (Postfix) with ESMTP id 327A6A0004 for ; Mon, 23 Sep 2024 18:35:02 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZydCEOec; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of chantr4@gmail.com designates 209.85.210.47 as permitted sender) smtp.mailfrom=chantr4@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727116406; a=rsa-sha256; cv=none; b=XZubR3ZelZds1/CyAnURU2Tr4RHDTNa2kxxlasQMJ59Xux+jUyf7tpEDXY0khGTjYuk0wr yqZ8anY0325v3hB7M43cM5b/2xqoFEIuXBWGzd6Ixk31bu3gjH8SrUUyTbefBBgpMxluSF gWzlTvItKbWA72SVyej++5hgeVH0keA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZydCEOec; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of chantr4@gmail.com designates 209.85.210.47 as permitted sender) smtp.mailfrom=chantr4@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727116406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IU1aoQ8nAToYML3G712UX67gK+ebjEKMmSqhwWIOXRU=; b=MRS52D7T2PzZWDpitiSQi04sj7qsBGcQkK2oXiYkk00C7pHbLXNQbfbQf20DLMwwhKMCTX f2nbPe2a0KZq9R6tIsdmd3MXEzHmTSscIpzY5PfUeDSCRv9ay4xX3d+nyNzA79zYrH4fKt ghbNXt/K2EU1E6fhhpFZHY619FSzsO0= Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-710d9b33303so3495138a34.3 for ; Mon, 23 Sep 2024 11:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727116501; x=1727721301; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IU1aoQ8nAToYML3G712UX67gK+ebjEKMmSqhwWIOXRU=; b=ZydCEOecmqMD0S0zzNltKOaA774BZxm3nDppabCXfdtqdmBXFBXnu2CSwCtfIx8Gtz FFIRf32iTNEoJL1eKE2NFTz2RDwPZ5yFYvPcGathBqRhFl+iKSlKseSurkLyE0fGP5AH YOJlSJ5E0KN9szz5umXotXTrLuWCvf8sYNLgaElOnOA1OJ+qH3HQIMaSAYs2FVSfxyb5 iXw9SGi83ZAsr78Jxqs8CSNFn/e8ePKUpkkMvvWes9psPo/vkPmcdoW7vQLphPTEQTjU JiHAZ8vv+Lqpz2iSjStDVRrW45e7rt2xeQtM2WrGCwwiP5sNR9u2LN/xOZpspgxePdr8 +HzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727116501; x=1727721301; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IU1aoQ8nAToYML3G712UX67gK+ebjEKMmSqhwWIOXRU=; b=h1L27zfKAzRVr9DIyr01w/g7DvvDEvJjAt+dhIzhcdKwnNHwNduu1qXVRbzOlckU5t hcwG/VcbMYqBIQDve1abATluMm8itfJktPO/4rAlAJ4j3CuOI7a/UGxD2BZ176DsrYE/ Fg22N5ZdcKtNAYkVPITRqrnAJK5oUfapNV8AKcmKl9WoIgDxQkWKaIgBKHK0jvoYMOys Y2ILcXtRrR2ujmZ8s3rh3E0b2XknOBm/PCd2a2ud6MFgn5GFsa2DtOr/OBJcnmEj6bzh OypzDkgvglEtNKz7VwB3J9fhGmlpuFMJuiGZpLI8tiR5eLiwtsXIVtq5GFfb9J9MLG21 Pu+g== X-Forwarded-Encrypted: i=1; AJvYcCXVrbAIBo/R+TJIHfRYf8AKxpHJkGEfrzT+ypB5apGGK6VPH4O+V1OczHCLlATgaOEL8qCfSu97fw==@kvack.org X-Gm-Message-State: AOJu0Ywfa9kmm7hg6gdB/jOiR5rRZD18wK0OgK7l+yayUstlLZ4P6AqI grhpQIDu0w8arMM854pYMbETMwSSP6dRbD6eBk8z+4/QnuhmbNCY X-Google-Smtp-Source: AGHT+IFvgEYijirg/eXLBYiD5dxcd0Zmc+d70nalPrLG/FqXhYvz1aSQ8Ig7QbHNJjxjsN+QDuXf8g== X-Received: by 2002:a05:6830:3891:b0:703:6076:a47 with SMTP id 46e09a7af769-71393533f16mr8751528a34.23.1727116501003; Mon, 23 Sep 2024 11:35:01 -0700 (PDT) Received: from localhost (fwdproxy-vll-115.fbsv.net. [2a03:2880:12ff:73::face:b00c]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5e3b0d94409sm3611397eaf.18.2024.09.23.11.34.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2024 11:34:59 -0700 (PDT) From: Manu Bretelle To: dhowells@redhat.com Cc: asmadeus@codewreck.org, ceph-devel@vger.kernel.org, christian@brauner.io, ericvh@kernel.org, hsiangkao@linux.alibaba.com, idryomov@gmail.com, jlayton@kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, marc.dionne@auristor.com, netdev@vger.kernel.org, netfs@lists.linux.dev, pc@manguebit.com, smfrench@gmail.com, sprasad@microsoft.com, tom@talpey.com, v9fs@lists.linux.dev, willy@infradead.org, eddyz87@gmail.com Subject: [PATCH v2 19/25] netfs: Speed up buffered reading Date: Mon, 23 Sep 2024 11:34:32 -0700 Message-ID: <20240923183432.1876750-1-chantr4@gmail.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20240814203850.2240469-20-dhowells@redhat.com> References: <20240814203850.2240469-20-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 327A6A0004 X-Stat-Signature: u6385myzxd3jz5x6rw7d77gh7x3tubx7 X-Rspam-User: X-HE-Tag: 1727116502-644266 X-HE-Meta: U2FsdGVkX19+hMmNttOUv0tGOWTagh6vnMbj+EHize6uRqfm16AzB+2VLzCV5jEam8m8ih5CP3H3B/WeV7T9CW45F2rPt8j3Mhp1p+10dBbdDFHIzCOVaullGox+NJCvsg8alRBEILo/UMBuxKdUTpNjEaODPJkK84eGfdF/diYpthDRBxKRJFXE+SNB2z9huWdGB5hsSRREIyYR37l4TuYsxYSiT9838qHvxNCQ3txPoNRf9sIsnyoDgs6CZGZ7pPTK4LJj31Aqv3BgVQNCNLiFWjHxsDWn58kqsoM9cOPYpgyKwzeUSvvn30qLtMK7blEmtGtxfdplVJL2UnmhXiPZzHJnaxems57fxAcytxwk7hZDUkpjZSDvOGskCTkluqZNqohoGPUY6sw4Hc84BLbl4wSj+8Fk0Kuf6Opi5+MwITpzG14Rf3PhR9hj2uVEy/o5w8d5x7zLQqxAJaEIIF9O6+1cM3TZ4MB5OcVTOmQEAtXI9KjEZcCAbuSKWfc6UUPQo71oPyBLoSdj5CtTlK64lSISSKXhKWLcPeS1C14pihQl9Z+SRFjTRwQjZwRAWF92eHFrqnLHwl6wbMHwEv6s2tHvxn+AA3hu5SGWJAvvxArjT90AA+IbQFk9Pe/c6QM/OOCiFaWQWXEhbWVsen4w3ozFHbvu3ud87ij8AxoZ7q0SbB9dp9bwmVUkoeseuy633FJpEzVImz+zJ87bFinzgiekEyxd1AY/kZ9V8QmTva5NfupNwcAzEo/9/xEPj+TY2ax3Hj2CLeGjBSzxZuhEWmE5qjjGstnab63L5QzXz913ddbhoUrHKyKgpuX+KemkecZx07iUQF43E23vw0TMNnrkLGuHlYHHnyXdmDNbXq8E/MGXHSend9Y/BnN5m/soNj4Hg52OLHhLt0xlb9fyg0mpxiCcD0d8Wlt3S/e/UkDGmPGkWXRWXJd14csYd7DRKJb/bGsuXznwkuf FC27jgmq 4O66P45Ao8aUiIJEfkH1zMV+1IWheaDFkWYKpcYPsUrjxOdvkwtXjNDy4yCbddTiHjmsrZLnAifc1nraav+jr0z+jJXi9UsFmzCWYKmCV+J3GzRvORyYNwTw1hgmktLiJTNEgJSNlujfWdzJWDtx0LfAVjYJTaEcjJRpa1Wchx60HpKznKgOnDeWR4HVRgboO1KP3GDMh/KyVA33gkpuXYPBFICvEtt7sf/FE/Y/6ICNT4z2Az8YQgMbSXH0qF1zdTCMJ+I7i8tg1IM5hcUKtck9eGFd8gHxwXDX25yhfUegDxjkU2+YcDO1bJThyPGzmLcqlX/Hj371vz6Phm3QdrP/wN0+zL4A70Prx3+81Hv+5crNI5L81JOngYOcG68XylKwcmBUWwNlJkjPs3+abIvsFw3aiG/jqXBwSY/vVM4VTkdWX52pzDWrLUAulC0YVUNoG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, It seems this commit (ee4cdf7ba857: "netfs: Speed up buffered reading") broke booting vms using qemu. It still reproduces on top of linux-master. BPF CI has failed to boot kernels with the following trace [0]. Bisect narrowed it down to this commit. Reverting ee4cdf7ba857 on to of current bpf-next master with [1] (basically ee4cdf7ba857 where I had to manually edit some conflict to the best of my uneducated knowledge) gets qemu boot back on track. This can be reproed by following the build steps in [2]. Assuming danobi/vmtest [3] is already installed, here is the script used during bisect. #!/bin/bash cat tools/testing/selftests/bpf/config{,.$(uname -m),.vm} > .config make olddefconfig make -j$((4* $(nproc))) || exit 125 timeout 10 vmtest -k $(make -s image_name) "echo yeah" exit $? The qemu command invoked by vmtest is: qemu-system-x86_64 "-nodefaults" "-display" "none" "-serial" "mon:stdio" \ "-enable-kvm" "-cpu" "host" "-qmp" "unix:/tmp/qmp-971717.sock,server=on,wait=off" \ "-chardev" "socket,path=/tmp/qga-888301.sock,server=on,wait=off,id=qga0" \ "-device" "virtio-serial" \ "-device" "virtserialport,chardev=qga0,name=org.qemu.guest_agent.0" \ "--device" "virtio-serial" \ "-chardev" "socket,path=/tmp/cmdout-508724.sock,server=on,wait=off,id=cmdout" \ "--device" "virtserialport,chardev=cmdout,name=org.qemu.virtio_serial.0" \ "-virtfs" "local,id=root,path=/,mount_tag=/dev/root,security_model=none,multidevs=remap" \ "-kernel" "/data/users/chantra/linux/arch/x86/boot/bzImage" \ "-no-reboot" "-append" "rootfstype=9p rootflags=trans=virtio,cache=mmap,msize=1048576 rw earlyprintk=serial,0,115200 printk.devkmsg=on console=0,115200 loglevel=7 raid=noautodetect init=/tmp/vmtest-init4PdCA.sh panic=-1" \ "-virtfs" "local,id=shared,path=/data/users/chantra/linux,mount_tag=vmtest-shared,security_model=none,multidevs=remap" \ "-smp" "2" "-m" "4G" [0] https://gist.github.com/chantra/683d9d085c28b7971bbc6f76652c22f3 [1] https://gist.github.com/chantra/642868407d10626fd44febdfed0a4fce [2] https://chantra.github.io/bpfcitools/bpf-local-development.html#building-a-vm-friendly-kernel-for-bpf [3] https://github.com/danobi/vmtest