From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF83ACF9C6F for ; Mon, 23 Sep 2024 17:52:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3ECBA6B007B; Mon, 23 Sep 2024 13:52:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 39B736B0083; Mon, 23 Sep 2024 13:52:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23BB86B0085; Mon, 23 Sep 2024 13:52:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0783D6B007B for ; Mon, 23 Sep 2024 13:52:31 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A0D6081464 for ; Mon, 23 Sep 2024 17:52:30 +0000 (UTC) X-FDA: 82596747660.26.BFDBC8E Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf24.hostedemail.com (Postfix) with ESMTP id A476018000F for ; Mon, 23 Sep 2024 17:52:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=Z5Zm+5jV; spf=pass (imf24.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.179 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727113914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d012RvO8FEt4oNV/hdC2ORp0abycOdoKV3NqdL6MFLw=; b=K2tgqbnQ/6mUEaCMNoM/w0npYFLPOLuK2hpMvNJ1UqGbcM857r0dxLOP2R3+9tf3iHPsgC yI9hvcF/RulI/4XaZ8zBgVTzGMjplN+NnGoMxrDhYbE+Q9n6ZWBkeq1fnzy2S7pzQclfC7 aYLbJtz1jRXR3RNFE/csTGN4wHIE/PU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=Z5Zm+5jV; spf=pass (imf24.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.179 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727113914; a=rsa-sha256; cv=none; b=8ROLEd/iLZCRo2gT/1RDzIt685Lh19Q8bg4BCkFRAmu1Rp1xFA26eiWomz/ZZxfRVezNi3 MMlbHnf+hNVq1fcKhDyFb0yVrtVvehQk8Yxj6+h+su3PsCGegnoCUP+cj/7racft/DL7Qz 51X2S9roRSV3/Ci035lKpFtFDMgZH98= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-45821ebb4e6so36845011cf.2 for ; Mon, 23 Sep 2024 10:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1727113947; x=1727718747; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=d012RvO8FEt4oNV/hdC2ORp0abycOdoKV3NqdL6MFLw=; b=Z5Zm+5jVtz2qVlTiH3XblFYQSERXmPxLNRz/WuqMFPLBFOEDAs7ziOoefLIQzUY95F FggvFjh+KgMvxSYY0E1nDNewp0xWv1FFC5EnqtzAZvjvnnqAk5KaCaUrMlO39g60PqaA 6rd76O/68DSQpYQB7HivuoEDPgNQ7DVsEMwJWqY08Z0/j/kgA0rz8NDUAqbvU3SIe6Qz k+K+jWFni9J9vHgiSXbEP9L2PqKsx8haMlTP8NOKRGxn+roFBaUK2RrrxWkixY76CzaE oiur6KK4z0UNS49NwdicsEJ24NCk8FNZ+iO0sK6lbn8NLMRnisLN9mVy0X4rRkt/d1wB KPYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727113947; x=1727718747; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d012RvO8FEt4oNV/hdC2ORp0abycOdoKV3NqdL6MFLw=; b=dDZLxOtaVtXcBRsieIhFmZAcC4Qi0ex5wQceHr/MeQQb2uZCXyjo4lMCmbUULF7tIc oz3wasBGxEaC9I3vZoDcY5UcBteB0fwCPh2yIoxzz/pkXp97aEI9Jlm1udTjkW/kN/zv U/wPfsifwvLfjiCEePV30akq+Ts+vlYFsWRjh5KbkS+ySI7gWEkWyIyYDz8EGcsCzRMm 3Kz1Of11mIBUurXABX4YpWcLZQpXAPWyy6WLSV15L4hBQ6Kz7bdx3HOAiTs+GiSzhYYj 7KP++KQzoyl+/MrFsJtsFwWzZ8Ml8p951BCAa+I33wRJoFui7vfa3mdCElRu0TI9xCJ3 JNfQ== X-Forwarded-Encrypted: i=1; AJvYcCVEUXUhJPTKrT8R+R1E9oyjUc+yiTNgM5d84ENEHVcRW1uI84ngz0APGneq0bjm8Od6O8F5chBQ8w==@kvack.org X-Gm-Message-State: AOJu0Yyv1vV7hR6bEWTfz5ECg0O9tzNH6v4AuNvTDO2l8NYTwGdFm6mS BRQaCN24CWjYa2Izl9k2nN/YC0vXkTiDhEfVNFrg4K5w83m3+xfv5wsBz9lkeKw= X-Google-Smtp-Source: AGHT+IHVrqHIowyi3PGsNMuzErMWdcwmU1SRIkTjY6Vp086kbtdmtvbVDAGc60f4mvoOr4wDyCS+5A== X-Received: by 2002:a05:622a:107:b0:458:35f7:3950 with SMTP id d75a77b69052e-45b226f380cmr178883201cf.17.1727113947576; Mon, 23 Sep 2024 10:52:27 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45b17888cdbsm49348071cf.49.2024.09.23.10.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2024 10:52:26 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1ssnEY-000LlC-32; Mon, 23 Sep 2024 14:52:26 -0300 Date: Mon, 23 Sep 2024 14:52:26 -0300 From: Jason Gunthorpe To: Yunsheng Lin Cc: Ilias Apalodimas , Jesper Dangaard Brouer , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, liuyonglong@huawei.com, fanghaiqing@huawei.com, zhangkun09@huawei.com, Robin Murphy , Alexander Duyck , IOMMU , Wei Fang , Shenwei Wang , Clark Wang , Eric Dumazet , Tony Nguyen , Przemek Kitszel , Alexander Lobakin , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Kalle Valo , Matthias Brugger , AngeloGioacchino Del Regno , Andrew Morton , imx@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH net 2/2] page_pool: fix IOMMU crash when driver has already unbound Message-ID: <20240923175226.GC9634@ziepe.ca> References: <20240918111826.863596-1-linyunsheng@huawei.com> <20240918111826.863596-3-linyunsheng@huawei.com> <894a3c2c-22f9-45b9-a82b-de7320066b42@kernel.org> <0e8c7a7a-0e2a-42ec-adbc-b29f6a514517@kernel.org> <2c5ccfff-6ab4-4aea-bff6-3679ff72cc9a@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c5ccfff-6ab4-4aea-bff6-3679ff72cc9a@huawei.com> X-Rspam-User: X-Stat-Signature: edrigbrd7jxr3rw3sz8b5sm4grrb4uup X-Rspamd-Queue-Id: A476018000F X-Rspamd-Server: rspam11 X-HE-Tag: 1727113948-787959 X-HE-Meta: U2FsdGVkX182PRG9VGgA3ZHpzVzxVU62jV3SE10GgHxLWQIfjAXMfZhpVCjovGwwL5uld9SJoJwx22Ahez/BiQVvOTp+AFGQIBVPjty1kvtr2h23rpSAogT3iwXFSOnLuPl2o33xlpsWLLzUAm/BFWCJXz7k0Y7MFlR4hFgxIim3PGRIu5IDEUybumdfcIM81NjCmz3KZXta8zG4Djfrf8FEF60alsMUicFmTCmTjnXBUeWOyhCKegLb0ZZnJRztzZeaZxf5Vdl9bXVzdcQRS8S/KrWhYD3SXqDY+DS8kn3V0eFicrPK6+DqEA7xNoF6/8vlp1RVcQdnDJwFpxZ+gKGWAsHEhtJ77NYifLg9WMB6/G95tvU2ndlB4hKVT46aVMccTt6UGeprHZHbsRE5ivsPcZ8xwWIV9D9w55bNQUsEFqzBNzjfs3n5ZIl3C2a0aaSKsr8+wokZh5syAd0wlOCzlWuwesFhlwZo4w97XQL7D/dmOPQLa3w0B4f2GKo6OlRUj6xk2SvhpvuipEPv9lrw1nEeA2q2+MELv+71vb4vzEj/Gr8XMi9B5N7mq+UY8tAyKiSUtqxXl5Sbfo2IZ8MzJL14EagDQJ+nAX3HK/fs88xfcf67qyzPmyZPSjjn7JL2eL3XNFD7FkZcIsP6yPmo0seUPKqh91sCfqYO7Jg/n9/qAP//JA51jHZQT8Zb1QBh7PvQyaJaliCdPrmv1J3xKXJLieIW0DJMhG4oXaKatrFE+qFcXiOvMmy2GlS9v6Dm0lDjjmQ4IKY70Pp3N80mHDxHsWak/EiHCL00BCuF9e14PkJP/+tkTh+N/suRcThoVBIhj0NK1YK8rDDTCOgmBXzHR94EQ2jzc/XAFZQDOSXhIT/tIYQPZxLC50GHSRLWSxTbw+fcmCIACGLgbS/2epkCyh96z/EGw1KBxxdgtlq2q+P1LT4DsLiaL+VktttCTqO8c2ceEoy01NO /p9hoMWM CExfzZqHpI8Qu2Pwzro8mYHf8ziaJWVy4pBssVsQ6L5bIfn3fiYVVjUb+QbslpPte9MzDYr1KkB8hfpxjgbDq1BjDk/DG92ok+u+bKi5qq87264sc5FCZNuBwkO21Vx64svd3HuRV4SE01M6opaLjYDAEbfeUQAjc5i26/hVScjrJVsezevzu51eOkZf8S1xYsTK0vjyKavGubTfyOmUKfBG3OtD3Sd4vStGcNH9sOVH7hEAUfvNbQWh0DDiuHBmZqb8F7F8DTegRR6YdJBdFZS0Jx2VpgMUo2nVpAAgEt5Q12Qk1mVUciNJeC9ntyLDfKhYT2UblYx8mgpTUVFXI0lGxoYM480tBGcgLprSl0vye6EWpSvCjyRh/ib6DbnI31AliCQJ+1Gw4UF/1TQuOHFUkhw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 20, 2024 at 02:14:02PM +0800, Yunsheng Lin wrote: > I am not sure what dose the API that allows netdev to "give" struct device > to page_pool look like or how to implement the API yet, but the obvious way > to stall the calling of device_del() is to wait for the inflight > page to It is not device_del() you need to stall, but the remove() function of the device driver. Once all drivers have been unbound the DMA API can be reconfigured and all existing DMA mappings must be concluded before this happens, otherwise there will be problems. So, stalling something like unregister_netdevice() would be a better target - though stalling forever on driver unbind would not be acceptable. Jason