From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 268A8CF9C6F for ; Mon, 23 Sep 2024 16:36:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A65B96B0083; Mon, 23 Sep 2024 12:36:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F0036B0085; Mon, 23 Sep 2024 12:36:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C1086B008A; Mon, 23 Sep 2024 12:36:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6CA626B0083 for ; Mon, 23 Sep 2024 12:36:15 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 183031213F0 for ; Mon, 23 Sep 2024 16:36:15 +0000 (UTC) X-FDA: 82596555510.10.2D69F88 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 67A1CC000E for ; Mon, 23 Sep 2024 16:36:13 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OFpQbNg7; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727109243; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qxSBNw+8hjNTNvxxMS7OWc4p8c3uIe7fcyZitBGEUyA=; b=H9W8KL6wvt41dxXsssrlM2/Eor7UrBYoowQm/JIefqB0Akg7qF+buuRVA7PUbstTt810pZ B/tAQB+7iNdAG/eQ/Q3r7RvNetrgQuw6GzZ3T934i2Nx18Jfd+ii+HXzwjdks2lJMCLrLr c+XzX3krhcxH8I7qqs6DbMWJn7ozXAE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727109243; a=rsa-sha256; cv=none; b=DqixKiBJbd7usZ1ncXoRsc6yRx9LBd46HEruQ8obD9soGcAPL4Q7A0bOH/hmyvZWDWc75G CBeC7dmksN2/RG0h19Ua04N0zGx9PWvLbipThG/Cg2MAi7xDrby+FPnPg3dDdccmmG5Yrz /0nutyKz9ypD4EyrpDX8GJSeQOXxrIY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OFpQbNg7; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BCBD95C575D; Mon, 23 Sep 2024 16:36:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA204C4CEC4; Mon, 23 Sep 2024 16:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727109372; bh=1XU4JWrWMckwknKVBBKhzkqovdaB9PtL+kY6TeZaKKY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OFpQbNg7smZpnzLGjeV8w9DSE4xMPILouyTi7L540cGP/iKWjZUzwvwYg2yRKfJsr /Dc2jBLu7HNMK2YpeWahGi4FeB4NGrS8lndRHrIYPmNHABgWO6WENKQRUzpAdcD9us w2fyym4zmDIwQTiJMGd24yWpIis7CxeAJmvDVjoMjRtbchQ0rajm7u/KVZs0AAKK5U GREfYS0MUNRl0MS+c88j0geea68zzr2uOrCiNml7ywk44PqVzuSZKQ4oPsmWtgbfxN bOYvaNl/lzO/eA6mQyBEQx8vQwmRT6gSyIl2GhyxXGe2M4wUNNQc+n1K3AJWDf5CoP 2JSVdg4h/FeuA== From: SeongJae Park To: Ba Jing Cc: SeongJae Park , shuah@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] damon: access_memory_even: remove unused variables Date: Mon, 23 Sep 2024 09:36:07 -0700 Message-ID: <20240923163608.552593-1-sj@kernel.org> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20240903034300.10443-1-bajing@cmss.chinamobile.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 67A1CC000E X-Stat-Signature: 5m8671cj64zzxojeahxb1ozy5ngjq8tn X-Rspam-User: X-HE-Tag: 1727109373-210568 X-HE-Meta: U2FsdGVkX18FRJ//zdLznUGYL/cE95eQlsxvq+o6v+khuVO1dcqj+cPrmyrUWPGonEQT8gQ/L5PqH0EJ1XxDtk9H72R6bU2MBMvjZWc7u+vCLnOsbPObKIIOx7uZJk4x7Pd0P0OB8GGBRFOfCImc9UARi/x18YoI8365sMAztnaRGqvMRF3cgsJeTbwUhiJfK6yL1ACDgU0e843eVHGGdFkG1LBQd2UuyULGYFrCoYkQ7dyokB5+2DgJfjkIYXZx8IDu0g8tAclQZSTmvQcznI60QFufteXeopwdD8N+SlPIJ8XiWEaBaIFxHORw4Q0Mh/ZMd7Sj2mYqvXECbN6o41RV4yRxd8ojlc0Lt4tP9lO8x2hl6567OHjji2StaoIfTOUHeJAUFUlTYYzke1XyGil8ypaVWbq5xxs3ETU9ITOs2i5XTcoEslYEMTmZXh2bW5WRTovSFhN02o4eZ/ShCqpjqA01RQsvzkP8ser/aSvOtu8R4Afo+UzUqlk+FSOZols83/W96oBPxgObCdhgM4keSQ3dui4ghIMBTYh9UUSVxlBLPJ8d1X7LAfW0gX3o+OuDUymhVo0hKnbqcPXQZnzFqXDV+WRKdVOUmTCDLKJqen3MEsbXlitt8w+g2y9Y2N0sQw2oYm2SR1oweqK9HLXF/GM71SkphfatJnwT2lq70BHvIcWwJOoq77MujypdU9SRdw9HnCJTvJKsAquqncMVLIZQ6SYObiKD/tS6FfoYqTog5Nfteg3RailtYYDVymwqJ5UmrHeb/yeRZZqj8lY2OiOoOc+4EXmX1Om3UsWKCkSdcAg5NN+aFhna6bMckXPiPiaTLozEBBlhVsuTg9dzmncoqIvQSdmA6GKwriY7uScM5oX32LKFk5czP1W5lCFK/CLwm3gYhRPw2TiXZpj63cSTm+LO5SyEaS7nTbHWhgHK8ZfCIRy2UOasSn+9GfaNMqntkZK7BSa9ol5 mzUblca8 bAI/U0R8yR+axWAL8X0FhwvYO8sdGSNWCPej8Bg7xSbuZu4MrxIN+tl37tsvK+HKO+1E6Yt7H46LxwNAblv2WiGuv3doLfBMNhjZN/QpumK1L7dp7hEu4LkVzE/vg1TO1vMiaBVqh43zsj0JRACDNpLUUjSqWnr2uWJFsQ8by/eN8+JdK4CWAEZD4QLIGtqaN5GR2YNlrImtz/PcDFi4FU9WmPB6yRROij06mhtTrHWT7F5d/wxlhIwopiXKpke+kHBroN/DVIei9NKeYpgKP2dtkRj2/SNDETEZ65rFCzjvFm6A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Ba, On Tue, 3 Sep 2024 11:43:00 +0800 Ba Jing wrote: > These variables are never referenced in the code, just remove it. Nice finding, thank you! I'd prefer having 'selftests/damon/access_memory_even: ' as the commit subject prefix. > > Signed-off-by: Ba Jing Other than the above trivial nitpick, Reviewed-by: SeongJae Park Thanks, SJ > --- > tools/testing/selftests/damon/access_memory_even.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c > index 3be121487432..a9f4e9aaf3a9 100644 > --- a/tools/testing/selftests/damon/access_memory_even.c > +++ b/tools/testing/selftests/damon/access_memory_even.c > @@ -14,10 +14,8 @@ > int main(int argc, char *argv[]) > { > char **regions; > - clock_t start_clock; > int nr_regions; > int sz_region; > - int access_time_ms; > int i; > > if (argc != 3) { > -- > 2.33.0