linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Ba Jing <bajing@cmss.chinamobile.com>
Cc: SeongJae Park <sj@kernel.org>,
	shuah@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] damon: access_memory_even: remove unused variables
Date: Mon, 23 Sep 2024 09:36:07 -0700	[thread overview]
Message-ID: <20240923163608.552593-1-sj@kernel.org> (raw)
In-Reply-To: <20240903034300.10443-1-bajing@cmss.chinamobile.com>

Hi Ba,

On Tue,  3 Sep 2024 11:43:00 +0800 Ba Jing <bajing@cmss.chinamobile.com> wrote:

> These variables are never referenced in the code, just remove it.

Nice finding, thank you!

I'd prefer having 'selftests/damon/access_memory_even: ' as the commit subject
prefix.

> 
> Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>

Other than the above trivial nitpick,

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

> ---
>  tools/testing/selftests/damon/access_memory_even.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c
> index 3be121487432..a9f4e9aaf3a9 100644
> --- a/tools/testing/selftests/damon/access_memory_even.c
> +++ b/tools/testing/selftests/damon/access_memory_even.c
> @@ -14,10 +14,8 @@
>  int main(int argc, char *argv[])
>  {
>  	char **regions;
> -	clock_t start_clock;
>  	int nr_regions;
>  	int sz_region;
> -	int access_time_ms;
>  	int i;
>  
>  	if (argc != 3) {
> -- 
> 2.33.0


  reply	other threads:[~2024-09-23 16:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03  3:43 Ba Jing
2024-09-23 16:36 ` SeongJae Park [this message]
2024-09-23 16:44 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240923163608.552593-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=bajing@cmss.chinamobile.com \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox