From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A148CF9C6C for ; Sun, 22 Sep 2024 15:11:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 901D56B007B; Sun, 22 Sep 2024 11:11:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B1966B0082; Sun, 22 Sep 2024 11:11:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A03B6B0085; Sun, 22 Sep 2024 11:11:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 61DC86B007B for ; Sun, 22 Sep 2024 11:11:31 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D78261C6243 for ; Sun, 22 Sep 2024 15:11:30 +0000 (UTC) X-FDA: 82592713140.03.C7D8C50 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 44886100002 for ; Sun, 22 Sep 2024 15:11:28 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OLytZqJJ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727017875; a=rsa-sha256; cv=none; b=7Ve2E5fWQ8GHCxyhku5Swuw/zhbaySKVabLbLGtqu6RUYPcu7lUKszpIUj4QcFGyKTsUgl Jk9VrN9YMv6LPlDWjXv88Nl2uL1+38vF2jsWePIwS23xnlj/ilkHotQ13WNc5eZHVwqwf/ 54SmXL8Qb8U35Ox6xCGiVca1bxItmFE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OLytZqJJ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727017875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Es3sZlWYnyaCUnohN3CsWbGdWLRsSmP2mCUqllDN6ao=; b=1S2X/IIJz4+cwvSn9Dt9TJuv/tMTo0ZL6dFnvbHynvr6MvdlEzJiho/asxO3BZlTXGzCK+ vt12fPBaiIWszSTYME97eLU7fE4STN10tQrfCbAdlGAgbVswx59C/B8hH8/zVQpA6npDI5 IX6TzUChO8tSbPTBx2ZSqFRCCTGcWh8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 50B6A5C0068; Sun, 22 Sep 2024 15:11:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3E58C4CEC6; Sun, 22 Sep 2024 15:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727017886; bh=i9XCB8m7qYule9muylEf116wS7isyCTJubzHPe8ofZg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OLytZqJJUd7VwLMxOF6xDjhI/ZZcBeJV6FnnllQvG3BlF4rhSsa96t+5fCucXWf2A D7NrCx0V2MlaKc7/CASDrLGm3oh6BqC1EEnPTdYcWC0gxtWIH5pzBGSeCK9VLZghdl Z5CYylP0YQCigRgwkf3oMgRf6bv3pwBhbxDdtw6v7bxvmbjHEjOBLbzfcPqWs0RJHS azW9f/WwGZv3XxnCDF6+ugNeE32eRB3pb8DIjFfs72tKo66rnGxWY2XejeyqHPwrof eagtZI70RV904N+nrcPzM9JNsH1OAO9glYPfZX73eV1TjQENjVirydD6ggTJDI0tU+ NaK9i8r746omw== From: SeongJae Park To: Leo Stone Cc: SeongJae Park , akpm@linux-foundation.org, ruanjinjie@huawei.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org Subject: Re: [PATCH] mm/damon: fix sparse warning for zero initializer Date: Sun, 22 Sep 2024 08:11:20 -0700 Message-ID: <20240922151121.469051-1-sj@kernel.org> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20240921195511.364023-1-leocstone@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: ekmfhxnp7ce78gx8khfiwwck3pjheicz X-Rspamd-Queue-Id: 44886100002 X-Rspamd-Server: rspam02 X-HE-Tag: 1727017888-954399 X-HE-Meta: U2FsdGVkX18F19fwD/vDmAoqPdpTHb7Bu3Wxqxy7ieSNgjKisP1xqX9+RIlUN25TP3EzwoqU4jGwHgm58mcPCN6qlVDLk0DvjaPDGXrufzmc/tS2pRnuq64rrsKRri6gMUoXxvv+W9VZBzn9KeaGGMwNO702H4C9Ix5ibkT7Uif1IDn9ARyA8zLkctF8U0BKTVGWdy7kGdOSf+LVwkRr74vhQi9rcWpbaxFZES3efdNOfbVimToxSaRzzdiTpqeKeQjeQnhLm0w6TUroyD7cstMkEVQgfRHq8Hpw0oZ3xqz6bKEqesW6TkeQ86NpJIK/zWzTiqMbJdvVAMk2sJBc52+mnkWHxNPJDa0Kb8DyM3Vy1KAY7gIoeeIO4uoz6fNizhR8rwP9w7TRMah5a7G9MldDbP51wso/AGHbGsG4t1zk+nkz6VmnWXFsI3BOQk6FKNUYJMDUPbIcXJwEHq17sjh432iy8gP9EFGqJndjhTFApq7dJOHf8BAAWwanoHcAlQcB/XbATj0+Uy0oyVn7jFVG/LP/Xi/jPxU7UIv4FBDqQfPDVBZXSrsgDM9wCRj8n6BbpE1B6smvIoP0pXl0G+ojZ82nBBYP6sCbeqfsKCeJcrT9IRhBlGCPpWc4T2wEN4DFdeI36bqzkPOhqOaiVkcNWScVguonUKNHyoAM8tRVSmJ3Cc3x8J0mbbwgpdnaDwypraMDckmjohgLOZenHknSiSDfcL8K0ldlGuAPO98a8jq9Dk2mHYk9zkKM5flgJoOx1YGlk1Xr1qgRw/cUPLFxkS1+LgvGirdbf+pWvBhITWKhP54cCbMOlIvkvwqj4QLaLUi5ZGSbEvhm9nTXCmfpPVpROd8RFh7e+1D91S6uTm0Ynp1FuZnjOOHeftFAnVG+r0qSFHAVy+USwGX7jwLw9eqKVPMg+aiEglY/YBfbCy2FXb6b9ac3NffeeWePWwzlfOdPZZg4MPD6YVg DhOuK+SW /a5EpH2eV3pMr6g858eYPiT4376IZovdqJpt4Yd6W3jHAXzof+cdfnC/WTpGzj4HD9gGMMFhsZubLR8ZpScDR45GbPl77QtIC9JVcvYAa71/D84wKZh6wM4aw/q6CRWTW0//Ox8ibQvwBz6+xSoKzt2RGi0fP0a+Cvk4Qu1rNwpEXu+EVqtNPwU8DYgFsUwJ++jv0mBvNfE0uuomVVFjD3tKAA2F9EzxZ7yGwgkfhaIet0cvPTpsdbp+Q8Pyzls7keBaF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Leo, Thank you for this patch! On Sat, 21 Sep 2024 12:54:45 -0700 Leo Stone wrote: > sparse warns about zero initializing an array with {0,}, change it to > the equivalent {0}. > > Fixes the sparse warning: > mm/damon/tests/vaddr-kunit.h:69:47: warning: missing braces around initializer > > Signed-off-by: Leo Stone Reviewed-by: SeongJae Park I also think below tag would be good to add? 17ccae8bb5c9 ("mm/damon: add kunit tests") Thanks, SJ > --- > mm/damon/tests/vaddr-kunit.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/tests/vaddr-kunit.h b/mm/damon/tests/vaddr-kunit.h > index a339d117150f..3dad8dfd9005 100644 > --- a/mm/damon/tests/vaddr-kunit.h > +++ b/mm/damon/tests/vaddr-kunit.h > @@ -66,7 +66,7 @@ static int __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas, > static void damon_test_three_regions_in_vmas(struct kunit *test) > { > static struct mm_struct mm; > - struct damon_addr_range regions[3] = {0,}; > + struct damon_addr_range regions[3] = {0}; > /* 10-20-25, 200-210-220, 300-305, 307-330 */ > struct vm_area_struct vmas[] = { > (struct vm_area_struct) {.vm_start = 10, .vm_end = 20}, > -- > 2.43.0