* [PATCH] mm/damon: fix sparse warning for zero initializer
@ 2024-09-21 19:54 Leo Stone
2024-09-22 15:11 ` SeongJae Park
0 siblings, 1 reply; 3+ messages in thread
From: Leo Stone @ 2024-09-21 19:54 UTC (permalink / raw)
To: sj, akpm, ruanjinjie
Cc: Leo Stone, damon, linux-mm, linux-kernel, linux-kernel-mentees, skhan
sparse warns about zero initializing an array with {0,}, change it to
the equivalent {0}.
Fixes the sparse warning:
mm/damon/tests/vaddr-kunit.h:69:47: warning: missing braces around initializer
Signed-off-by: Leo Stone <leocstone@gmail.com>
---
mm/damon/tests/vaddr-kunit.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/damon/tests/vaddr-kunit.h b/mm/damon/tests/vaddr-kunit.h
index a339d117150f..3dad8dfd9005 100644
--- a/mm/damon/tests/vaddr-kunit.h
+++ b/mm/damon/tests/vaddr-kunit.h
@@ -66,7 +66,7 @@ static int __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas,
static void damon_test_three_regions_in_vmas(struct kunit *test)
{
static struct mm_struct mm;
- struct damon_addr_range regions[3] = {0,};
+ struct damon_addr_range regions[3] = {0};
/* 10-20-25, 200-210-220, 300-305, 307-330 */
struct vm_area_struct vmas[] = {
(struct vm_area_struct) {.vm_start = 10, .vm_end = 20},
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/damon: fix sparse warning for zero initializer
2024-09-21 19:54 [PATCH] mm/damon: fix sparse warning for zero initializer Leo Stone
@ 2024-09-22 15:11 ` SeongJae Park
2024-09-23 2:25 ` [PATCH v2] " Leo Stone
0 siblings, 1 reply; 3+ messages in thread
From: SeongJae Park @ 2024-09-22 15:11 UTC (permalink / raw)
To: Leo Stone
Cc: SeongJae Park, akpm, ruanjinjie, damon, linux-mm, linux-kernel,
linux-kernel-mentees, skhan
Hi Leo,
Thank you for this patch!
On Sat, 21 Sep 2024 12:54:45 -0700 Leo Stone <leocstone@gmail.com> wrote:
> sparse warns about zero initializing an array with {0,}, change it to
> the equivalent {0}.
>
> Fixes the sparse warning:
> mm/damon/tests/vaddr-kunit.h:69:47: warning: missing braces around initializer
>
> Signed-off-by: Leo Stone <leocstone@gmail.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
I also think below tag would be good to add?
17ccae8bb5c9 ("mm/damon: add kunit tests")
Thanks,
SJ
> ---
> mm/damon/tests/vaddr-kunit.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/damon/tests/vaddr-kunit.h b/mm/damon/tests/vaddr-kunit.h
> index a339d117150f..3dad8dfd9005 100644
> --- a/mm/damon/tests/vaddr-kunit.h
> +++ b/mm/damon/tests/vaddr-kunit.h
> @@ -66,7 +66,7 @@ static int __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas,
> static void damon_test_three_regions_in_vmas(struct kunit *test)
> {
> static struct mm_struct mm;
> - struct damon_addr_range regions[3] = {0,};
> + struct damon_addr_range regions[3] = {0};
> /* 10-20-25, 200-210-220, 300-305, 307-330 */
> struct vm_area_struct vmas[] = {
> (struct vm_area_struct) {.vm_start = 10, .vm_end = 20},
> --
> 2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2] mm/damon: fix sparse warning for zero initializer
2024-09-22 15:11 ` SeongJae Park
@ 2024-09-23 2:25 ` Leo Stone
0 siblings, 0 replies; 3+ messages in thread
From: Leo Stone @ 2024-09-23 2:25 UTC (permalink / raw)
To: SeongJae Park
Cc: Leo Stone, damon, linux-mm, linux-kernel, linux-kernel-mentees,
skhan, akpm, ruanjinjie
sparse warns about zero initializing an array with {0,}, change it to
the equivalent {0}.
Fixes the sparse warning:
mm/damon/tests/vaddr-kunit.h:69:47: warning: missing braces around initializer
Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests")
Signed-off-by: Leo Stone <leocstone@gmail.com>
---
v2: Added fixes tag. Thank you!
---
mm/damon/tests/vaddr-kunit.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/damon/tests/vaddr-kunit.h b/mm/damon/tests/vaddr-kunit.h
index a339d117150f..3dad8dfd9005 100644
--- a/mm/damon/tests/vaddr-kunit.h
+++ b/mm/damon/tests/vaddr-kunit.h
@@ -66,7 +66,7 @@ static int __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas,
static void damon_test_three_regions_in_vmas(struct kunit *test)
{
static struct mm_struct mm;
- struct damon_addr_range regions[3] = {0,};
+ struct damon_addr_range regions[3] = {0};
/* 10-20-25, 200-210-220, 300-305, 307-330 */
struct vm_area_struct vmas[] = {
(struct vm_area_struct) {.vm_start = 10, .vm_end = 20},
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-23 2:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-21 19:54 [PATCH] mm/damon: fix sparse warning for zero initializer Leo Stone
2024-09-22 15:11 ` SeongJae Park
2024-09-23 2:25 ` [PATCH v2] " Leo Stone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox