From: Wei Yang <richard.weiyang@gmail.com>
To: akpm@linux-foundation.org, Liam.Howlett@oracle.com
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH 2/4] maple_tree: use mt_pivot_count() to replace mt_slot_count() - 1
Date: Thu, 19 Sep 2024 23:48:30 +0000 [thread overview]
Message-ID: <20240919234832.24237-3-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20240919234832.24237-1-richard.weiyang@gmail.com>
We have (mt_slot_count() - 1 == mt_pivot_count()), except for
maple_dense node. Since mas_mab_cp() doesn't apply to maple_dense node,
it is fine to use mt_pivot_count() here.
By doing so we can save instruction to decrease 1 from mt_slot_count().
Below is the comparison of generated code.
Current:
.L1595:
lib/maple_tree.c:3165: mas_mab_cp(mas, split + skip, mt_slot_count(mas->node) - 1,
movl %ebx, (%esp) # prephitmp_234,
movzbl mt_slots(%edx), %ecx # mt_slots[_90], mt_slots[_90]
movl %esi, 4(%esp) # _26,
movzbl -23(%ebp), %eax # %sfp,
movzbl -21(%ebp), %edx # %sfp, split
decb %cl # tmp258
movzbl %cl, %ecx # tmp258, tmp260
addb %al, %dl #, split
movl -16(%ebp), %eax # %sfp,
movzbl %dl, %edx # tmp261, tmp262
call mas_mab_cp #
After applying this patch:
.L1595:
lib/maple_tree.c:3165: mas_mab_cp(mas, split + skip, mt_pivot_count(mas->node),
movl %ebx, (%esp) # prephitmp_231,
movzbl mt_pivots(%edx), %ecx # mt_pivots[_87], mt_pivots[_87]
movl %esi, 4(%esp) # _26,
movzbl -23(%ebp), %eax # %sfp,
movzbl -21(%ebp), %edx # %sfp, split
addb %al, %dl #, split
movl -16(%ebp), %eax # %sfp,
movzbl %dl, %edx # tmp256, tmp257
call mas_mab_cp #
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
lib/maple_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 51f49b29b8b0..8ff075645f21 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -3167,7 +3167,7 @@ static inline void mast_fill_bnode(struct maple_subtree_state *mast,
cp = false;
if (cp)
- mas_mab_cp(mas, split + skip, mt_slot_count(mas->node) - 1,
+ mas_mab_cp(mas, split + skip, mt_pivot_count(mas->node),
mast->bn, mast->bn->b_end);
mast->bn->b_end--;
--
2.34.1
next prev parent reply other threads:[~2024-09-20 0:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 23:48 [PATCH 0/4] refine mas_end of mas_mab_cp() Wei Yang
2024-09-19 23:48 ` [PATCH 1/4] maple_tree: not necessary to copy mas->end + 1 Wei Yang
2024-09-19 23:48 ` Wei Yang [this message]
2024-09-19 23:48 ` [PATCH 3/4] maple_tree: copy to mt_pivot_count() instead of mt_slot_count() Wei Yang
2024-09-19 23:48 ` [PATCH 4/4] maple_tree: now we are sure mas_end wouldn't exceed mt_pivots[mt] Wei Yang
2024-09-23 19:57 ` [PATCH 0/4] refine mas_end of mas_mab_cp() Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240919234832.24237-3-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox