Re: [PATCH v4 1/2] mm: Abstract THP allocation

[kernel test robot <lkp@intel.com>]

Hi Dev,

kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on linus/master v6.11 next-20240918]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dev-Jain/mm-Abstract-THP-allocation/20240916-174543
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20240916094309.1226908-2-dev.jain%40arm.com
patch subject: [PATCH v4 1/2] mm: Abstract THP allocation
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240919/202409191416.9etlfugV-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240919/202409191416.9etlfugV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409191416.9etlfugV-lkp@intel.com/

All warnings (new ones prefixed by >>):

   mm/huge_memory.c: In function 'vma_alloc_anon_folio_pmd':
>> mm/huge_memory.c:1152:23: warning: unused variable 'haddr' [-Wunused-variable]
    1152 |         unsigned long haddr = addr & HPAGE_PMD_MASK;
         |                       ^~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for GET_FREE_REGION
   Depends on [n]: SPARSEMEM [=n]
   Selected by [m]:
   - RESOURCE_KUNIT_TEST [=m] && RUNTIME_TESTING_MENU [=y] && KUNIT [=m]


vim +/haddr +1152 mm/huge_memory.c

  1148	
  1149	static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma,
  1150						      unsigned long addr)
  1151	{
> 1152		unsigned long haddr = addr & HPAGE_PMD_MASK;
  1153		gfp_t gfp = vma_thp_gfp_mask(vma);
  1154		const int order = HPAGE_PMD_ORDER;
  1155		struct folio *folio = vma_alloc_folio(gfp, order, vma, haddr, true);
  1156	
  1157		if (unlikely(!folio)) {
  1158			count_vm_event(THP_FAULT_FALLBACK);
  1159			count_mthp_stat(order, MTHP_STAT_ANON_FAULT_FALLBACK);
  1160			goto out;
  1161		}
  1162	
  1163		VM_BUG_ON_FOLIO(!folio_test_large(folio), folio);
  1164		if (mem_cgroup_charge(folio, vma->vm_mm, gfp)) {
  1165			folio_put(folio);
  1166			count_vm_event(THP_FAULT_FALLBACK);
  1167			count_vm_event(THP_FAULT_FALLBACK_CHARGE);
  1168			count_mthp_stat(order, MTHP_STAT_ANON_FAULT_FALLBACK);
  1169			count_mthp_stat(order, MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE);
  1170			return NULL;
  1171		}
  1172		folio_throttle_swaprate(folio, gfp);
  1173	
  1174		folio_zero_user(folio, addr);
  1175		/*
  1176		 * The memory barrier inside __folio_mark_uptodate makes sure that
  1177		 * folio_zero_user writes become visible before the set_pmd_at()
  1178		 * write.
  1179		 */
  1180		__folio_mark_uptodate(folio);
  1181	out:
  1182		return folio;
  1183	}
  1184	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki