From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7AD2C36018 for ; Tue, 17 Sep 2024 12:11:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A7336B0085; Tue, 17 Sep 2024 08:11:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 357736B0089; Tue, 17 Sep 2024 08:11:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21EC86B0095; Tue, 17 Sep 2024 08:11:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F2F986B0085 for ; Tue, 17 Sep 2024 08:11:58 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AA7D0A03DC for ; Tue, 17 Sep 2024 12:11:58 +0000 (UTC) X-FDA: 82574116716.19.DE02012 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id E051B4000B for ; Tue, 17 Sep 2024 12:11:55 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=d3XfgZEC; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726575004; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zhlxrTWnhBbwbc46MW2rL/AlPPkiCrXfY7yP7cHC66o=; b=EOqERuqYlGk0zZfmDmXWO+5kVDX5Wnx0TLlqlysUvNOV5uF2GOpVRXMs0C2XgFIsd+sgkx foF8OWnsYl6mcA9GjDJVmfs4LcCIecXk8DFZrt0yY32VAebCxaJTGgE0QvFRX5FN0Qdv0q l1aPZp3SfeS4zQ0qk3Jh1P8YVxxEVkU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726575004; a=rsa-sha256; cv=none; b=msJOnajIKG8XxjSCwPpYl4TsIMnstxeUsBy6QSv/JZrZMO0SHKfUiyrRwjc6hRfjflGt+P 2HC5thirRIPA5odvOvxo8+GA1lG7afmzA+u8P27S/KQsCViKfo1IyCda8RAPeCpX50T+iD dm0eZqMPT1IBasFAkRzdLqX8fbss5sU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=d3XfgZEC; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F1B2D5C030A; Tue, 17 Sep 2024 12:11:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED6CFC4CEC5; Tue, 17 Sep 2024 12:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1726575114; bh=aWYSdleccHLfIZAdozoHiH76a067cg/tvnibnZr87CU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d3XfgZECFaNKOjWIvkw91pWFcJi0Xk/To7xixDPKqYWUaRKFiPzEdquIJMULKsrpt 0yV2WtWil1yvQ23cwYvW1yLc0Sk4efzrOSpyh68xHt6/kqPyT+ltpWMcOojFE58ksq 8Rgw9EM+xB3Hn57NgWy6foUuR9RF0EvvAJes+RVA= Date: Tue, 17 Sep 2024 05:11:50 -0700 From: Andrew Morton To: kernel test robot Cc: Baolin Wang , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Ryan Roberts Subject: Re: [linux-next:master 12061/12283] mm/khugepaged.c:435:undefined reference to `shmem_hpage_pmd_enabled' Message-Id: <20240917051150.5779e3b1b351cb83662674cc@linux-foundation.org> In-Reply-To: <202409171905.9gqKNeeL-lkp@intel.com> References: <202409171905.9gqKNeeL-lkp@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: wyr99x5zzk51asnnfcqs8b4mcpwy9xtb X-Rspamd-Queue-Id: E051B4000B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1726575115-155467 X-HE-Meta: U2FsdGVkX190zcrEaC9nE5nJ7dOAFl8SgmqawCMxf0fB3kpALYu2iKdXyBkAogPJpDcZYXC76e1tIeYB8mDDHjXnb33wrlj2z/v+zFOnuckMVTISyGrTIVn73cFgXEUNor6XO2QXbLE6YamZt4tkRkYJSCjrFe0JB/0noA2C35KQBcTzAMOrYfM7BMDSFh0i6ck/QMVv3p12HJ+KRCVYSRNizkRuMd8GxIDzO/95uATf4OEV+jwtjPo7RdipPmGICcGGwthGMhHmgfkw1i/1e+xJWGhzk9DbBP3h12N9A2Ig2kvt38lGaZ05Xq7l433HGkr5Hi4PfRbSJytuM7GPW+XUrNj6zNJLgp1zuKllK96BtUmE0mJuqSaC0DLudfjIeNtQpPgY9XCw/c2N9H6YZEF4LVb58hhUufx/H5QUQG7s4HQvycbpMEdTBoCY5tb3A75XkHUvVbSP/H1ScCWc0HJNE8RTC12XmngnsYHX73jROzWt0c3zW29tKcL5/jtIr1jXaBwDX5EfJFU2cYhjoZNTXW/pKeL8JqmLfFojw7ZmI8AXE6UXJAX7HxB1JqwkcKNnG1ENFrkzsC4KyN2ZRQPtg6AV9ojgvnG/FUDBqh9BiycSlbNx7yRMSnwm+7EGLuUeZWjOLypPdkxZHwMl9UvLuRU2Nvka8T9hZEWstB329nlh0gh2J0xEjiSTdO/geg0rE1Kgm6nZpgpjR5mXJ/l0JKeOATnMEbBPAtHT7fFFiZYg0ZB/NMLn7DafeRJBERyQv5lHrrU9/ThF+l3GqC1stxnof5pfMeik5bxJKApsoH8XJ5IvFfMhWfyOvwpG8DtSF3rkMTLtcjpVVE4OU79V8np4oGlsWQZIYptMUxiQEP821GAcqEKKOZefdVcnW27OP3Wi8oZR2P22eUhT/5ymt8/adEIY92rahk1Pu+H2cjCAUmFrcVnYUlrgYM9PH4KAkinRjs/aWEPaRhx E0lPM+j0 sUR9xb1ClF+IQ/XmN9KHzd+oRdWKYU0Qg9rTSppbTQ/SRcSthIuSLQy1PVz42cWLQomMVp4l4iewoF/xFFYTa3eR9tE4PplVYSTrQ0GosnZZ7xN5IgJJ3kh3JknGGbXjW3JwvSTAyI8KuOe00O1Q1oV+c7JzxlLLCwO6mC31HnQfxL9zaj2hS+g0rSc2gh5KaeCuwCO3zAQOUa8tC1IW/RRtWu7cUEieczOi42hGdByFFSKCV7FTfmkke/S1lix9WkNxJhqlA/k6NcRBpJpI+cyXnIXl1F3uyWnhyOwFXSvkgz4CQWJUzpu84h0guWH5RuIYCQDEtVGkma/2zSA3jpxBkrO/PLG98M6u9N6x3vLDL+L4mPGT2wAUkvjZXC8zeT/qs+vqfAYEkQoEUJev8WUpZGKzDp1gOq+z5+fFwOizVIFfLlWuEkuaAAuzEpyYCvadaQMJAh0OXZQFpwNUnke9sJtyhGBH+P0WEkTeO/tqDvvl/DMwqlPMjQ0ZUn8o0Ry9lrSd2oZfCDsh4YojtTyga4NZskFi/mAkToejlcyHTHLioZp0M6xSkTEkGujwa9nzffd+Hg8pMXBgyzZl7HeRqqcesRidndw7ECC6ctmoMQO/ox8+RolZ44vCddZAKIH1H7fawv+9U5Q8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 17 Sep 2024 19:36:47 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 4f3e012d4cfd1d9bf837870c961f462ca9f23ebe > commit: 8b07e88e36961c4785dd13dbdbb5d7977b458940 [12061/12283] mm: shmem: fix khugepaged activation policy for shmem > config: loongarch-randconfig-s042-20221209 (https://download.01.org/0day-ci/archive/20240917/202409171905.9gqKNeeL-lkp@intel.com/config) > compiler: loongarch64-linux-gcc (GCC) 13.3.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240917/202409171905.9gqKNeeL-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202409171905.9gqKNeeL-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > loongarch64-linux-ld: mm/khugepaged.o: in function `hugepage_pmd_enabled': > >> mm/khugepaged.c:435:(.text+0x2338): undefined reference to `shmem_hpage_pmd_enabled' Thanks. I think this: From: Andrew Morton Subject: mm-shmem-fix-khugepaged-activation-policy-for-shmem-fix Date: Tue Sep 17 05:06:48 AM PDT 2024 fix build with CONFIG_SHMEM=n Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202409171905.9gqKNeeL-lkp@intel.com/ Cc: Baolin Wang Cc: David Hildenbrand Cc: Hugh Dickins Cc: Matthew Wilcox (Oracle) Cc: Ryan Roberts Signed-off-by: Andrew Morton --- include/linux/shmem_fs.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/include/linux/shmem_fs.h~mm-shmem-fix-khugepaged-activation-policy-for-shmem-fix +++ a/include/linux/shmem_fs.h @@ -114,7 +114,6 @@ int shmem_unuse(unsigned int type); unsigned long shmem_allowable_huge_orders(struct inode *inode, struct vm_area_struct *vma, pgoff_t index, loff_t write_end, bool shmem_huge_force); -bool shmem_hpage_pmd_enabled(void); #else static inline unsigned long shmem_allowable_huge_orders(struct inode *inode, struct vm_area_struct *vma, pgoff_t index, @@ -123,6 +122,11 @@ static inline unsigned long shmem_allowa return 0; } +#endif + +#if defined(CONFIG_TRANSPARENT_HUGEPAGE) && defined(SHMEM) +bool shmem_hpage_pmd_enabled(void); +#else static inline bool shmem_hpage_pmd_enabled(void) { return false; _