From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 042FEC3ABA2 for ; Mon, 16 Sep 2024 07:41:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84CF66B008C; Mon, 16 Sep 2024 03:41:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FB6F6B0092; Mon, 16 Sep 2024 03:41:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C3306B0093; Mon, 16 Sep 2024 03:41:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4E81C6B008C for ; Mon, 16 Sep 2024 03:41:44 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BE4C4A6E28 for ; Mon, 16 Sep 2024 07:41:43 +0000 (UTC) X-FDA: 82569806886.15.70C4B49 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id F0C221A000F for ; Mon, 16 Sep 2024 07:41:41 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=DQToUKuw; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726472471; a=rsa-sha256; cv=none; b=F98Y55H+TlIli4WnGcaAY2meOW47g8zoneM7aOLWWqXSc+9uXuK6VzqlW4MhlUkUz/NWP9 S/Esvvy86IuxSxuSuoB4i9PeNyIC17gWpkA+D/M3TvVwo8ac5YDbumKh3fD81UIACzXUD8 0C1CP0pcQvy3ZB4jKke6yAvjvJf6gyw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=DQToUKuw; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726472471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1lGc5ePBwgv55lIR//e77oJ7QcX1rPBxqQzgDYSs6Do=; b=6SQE5ZYoEyE2sU5OwfQz8xVGtREhrCINlGQuaKE6bsnC84uVeK/f1zLqdk5Iy9w6997PD3 nDOnVMKHj5Zk6bjHIcUZ8XDr51hntxffaenqNYN+kUeW7GWPCdAXo0I8IlTJBJLnWgIs9U EtOM0NX8HPFAG1qDLkyxz0htCFuO1Dg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 53FC0A416FB; Mon, 16 Sep 2024 07:41:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED106C4CEC4; Mon, 16 Sep 2024 07:41:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1726472500; bh=MJNU64e/Cm28j4kruSrPIYGA0DU5DT4s0QKn5OFOK0w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DQToUKuwz2Jb8fUUXg/iPHi2LSK/KgXrTbaXbMQx6mV2AQjd8nqsJ7lRGa/DOBaO1 vKxB1QjAdiyEn/9lBro9wqp49GEobRgmTrk6H18r7dGQnUw6xb5+wE5V2VxNnzcwjv OOqfIV0Flp77+wu60/UScGJrVh8wGVtO4GTM4dRg= Date: Mon, 16 Sep 2024 00:41:34 -0700 From: Andrew Morton To: Jingxiang Zeng Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, linuszeng@tencent.com, linux-kernel@vger.kernel.org, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, shakeel.butt@linux.dev, yosryahmed@google.com Subject: Re: [PATCH V2] mm/memcontrol: add per-memcg pgpgin/pswpin counter Message-Id: <20240916004134.0ef2f50862b59079e1ac2928@linux-foundation.org> In-Reply-To: <20240913084453.3605621-1-jingxiangzeng.cas@gmail.com> References: <20240913084453.3605621-1-jingxiangzeng.cas@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: F0C221A000F X-Rspamd-Server: rspam01 X-Stat-Signature: kwoszpgcjkd1sgrhkuaqpcnimqms4cro X-HE-Tag: 1726472501-884241 X-HE-Meta: U2FsdGVkX1/VSTCLVEVSN+9n4EXLmqOcUddp0263svB47zeR1mtQ9Gq20LaLTQNaC7Hho0Nzs8cIDvmjFxZbHsgZWCnYuN2adgfPYnc+syfJX40ux8Tq74swd1VNbTCNB1pGaCBDlQIds7WhT6V62TphQXEdToteBvahNhRYjPNpNV+Ck1f5JwYjhEIRYerXWBa5sZ+C8sG41hwnt/4FOZ8/xnSRD4EUJFf/uWgIO38McONCyiQCUBGNWEbcxOGk1rz7Kcr9/CKLokmGCsT+mkn90CCvhwLJNrV9rQXrPSmtbEbw1Qk3vTlWoB1QhFTijciJUC27G1b7pODvGrQMLzn25mcAXXuC8521QJtFVsPjlcKttNOHOUmzqyVnccAr0sFNKePsSKeZdedpNVRZujdtMV8d/CGSx2tHG3e5wt9X/GyzTkk9km8lI498c8cEIqQROE8cTkhAJHLgnCXnLQQOvVP1Y+SDGHKuPMs/qqqIFdvh4FqwpRYUCIAEN+aXJubeTyC2cixFkHFJLkhWHMh1E0jz4Df8iegkzZS1f3vSPTjtpPh1jJVGf1Cojs/BptRRFyeFBuMupAxUOyn366xg0qw6ejy0vYHJQ9SqJFApmi6fNazciYQhaTPPzvoDMLS5NH6Ys8ZylAYYRj5V8U3UbOnoKr67/A0kJkaH9JWd23rU6bEiCqUiebbfqLT5rGIT9bPOn82AGHpNZBztJ/Vdc1TJ5Ke8m8fnzhfdAibmu3VIKu60Vd5D2zAAVEl09StW541zNx+qiHknLtufc3oS0Zi2pCuMbvFHe0Bq4I+ADRefw2jyKEOWcYBomwKDqcuDtKXuE70+xu0q+TMu+3uRhDvh8l7Qcm+bbGneh9AVxEoUUGLqb/+3NIeqSEwHsfr0Qxn5cPow3bNS8LiB26KjXObPU2YVu+qKRnjCunWYg1Su4opMoxOsRiKrsDU4aGg8uY0+UhMVKvZr0yO TJs4g67X kyTLUa3LYWjgpTQ4WaK1bA2aIWSZ025ZWlz7q36scHfkC+NKdSuT/gyQ71s1KPutdr6GGFrx5txPufcXIqxtykuibJHn+hoxMgEuRRWZvxguFysLt85xzGv4dmYmxrV7i4W/SfGpbnLkiJY+TMgg3NqqiX/LAOEXq105PH24T2gRQa/iy7ckbR7BPvOANJiEG6qNWinb650etyRKJrDd7YmC4Es+ina1X2TbZY+5ZksELPmyi7noZ6hOHg+P6+ilR1KxQ0qEf/0m0Gc1XrTeHLPr086qyx2Cal4I74N7+HrffBWiVAqong/Te5EQj0wpoCFrVV30MLiGHZKx6g7yZy/PiAsYL0ERhwmWWhq0VnEz9KV0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 13 Sep 2024 16:44:53 +0800 Jingxiang Zeng wrote: > From: Jingxiang Zeng > > In proactive memory reclamation scenarios, it is necessary to estimate the > pswpin and pswpout metrics of the cgroup to determine whether to continue > reclaiming anonymous pages in the current batch. This patch will collect > these metrics and expose them. > Please explain the differences between v1 and v2: --- a/mm/memcontrol-v1.c~mm-memcontrol-add-per-memcg-pgpgin-pswpin-counter-v2 +++ a/mm/memcontrol-v1.c @@ -2729,8 +2729,6 @@ static const char *const memcg1_stat_nam static const unsigned int memcg1_events[] = { PGPGIN, PGPGOUT, - PSWPIN, - PSWPOUT, PGFAULT, PGMAJFAULT, }; _