From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C360FC3ABA1 for ; Sun, 15 Sep 2024 15:05:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A95116B007B; Sun, 15 Sep 2024 11:05:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A45006B0082; Sun, 15 Sep 2024 11:05:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90DBB6B0083; Sun, 15 Sep 2024 11:05:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6BC446B007B for ; Sun, 15 Sep 2024 11:05:01 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1BA05AB8F4 for ; Sun, 15 Sep 2024 15:05:01 +0000 (UTC) X-FDA: 82567295202.21.0A89831 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 173444000A for ; Sun, 15 Sep 2024 15:04:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E+24g+S+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726412578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PgPXoGAgWEmJuNaNaMNmxrMHZdG9YhV6gHMHUQ6h5z0=; b=C5TiBbaPvTuE2bQDdJPjotU9ZekzdyZ5axTgEGmm8GJfR3ObjEaj1kxvmVGzW/F9y+A+9A txhzSEKKTx9LFaaMxifOUjUliUoPyBnmFBvkJWfRaWbPZRu7UYH03cA6HxnHAbMyna8g/l Gm+7+xM5vLGnyyvS5DoLNb+4vTZ+OJA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726412578; a=rsa-sha256; cv=none; b=ZdaB38WBnUcgeBnsen+k79QVa+Z9ygyJqKI+c9sjuu6F3wJlsAggIIaTN4yxeQdTqUBMTa AzYA0kMuWbZlAgrXksDDKMiMAVIUta1RMn9AGKbJUVRnfkCgS3YEn4WqzsUg9ot5Bw0RyB tzE4FTvROm6BgeybkVp8HHBKrnMjS9U= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E+24g+S+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726412698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PgPXoGAgWEmJuNaNaMNmxrMHZdG9YhV6gHMHUQ6h5z0=; b=E+24g+S+iTPZd+IZllyY4dogO2wKL/REkdezclmY+yfo66xC+JBacIb/sWJ2B3BOxrglt3 brsCAlvyf0jC60ne/brzcxb1vC++HTIL0/p1G0mcyTpJOFp/1N7SoNvSLSa4VpapHQpYXS 69gAU5OEeGRm1OCZ5qIowkbY32/khXo= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-JbosABjIMUe7gj9-zuvLyw-1; Sun, 15 Sep 2024 11:04:52 -0400 X-MC-Unique: JbosABjIMUe7gj9-zuvLyw-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B0DA119560B1; Sun, 15 Sep 2024 15:04:49 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.40]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 09EE51956086; Sun, 15 Sep 2024 15:04:43 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 15 Sep 2024 17:04:37 +0200 (CEST) Date: Sun, 15 Sep 2024 17:04:30 +0200 From: Oleg Nesterov To: Andrii Nakryiko Cc: linux-trace-kernel@vger.kernel.org, peterz@infradead.org, rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, paulmck@kernel.org, willy@infradead.org, surenb@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, mjguzik@gmail.com, brauner@kernel.org, jannh@google.com Subject: Re: [PATCH 2/2] uprobes: add speculative lockless VMA-to-inode-to-uprobe resolution Message-ID: <20240915150429.GC27726@redhat.com> References: <20240906051205.530219-1-andrii@kernel.org> <20240906051205.530219-3-andrii@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240906051205.530219-3-andrii@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 173444000A X-Stat-Signature: h8x1ss59u5jn4th5qxba6e67meuen93t X-Rspam-User: X-HE-Tag: 1726412698-902282 X-HE-Meta: U2FsdGVkX1+JptlnK2MYS85WYjHQCmSOTQC52RnYvSdT5eKU3mj17H1ttkipx07VtImrSYvu9miby6bpdIwpX3UmO77qS9N0yMP65gG472MTOnSNtLNUu+cpl3swHjG/8HbVFW5qvnirC+wmJxOlw4CpoX1Bsdg6rXAVMkTkMSnTQGuh+i8OE+1iJYoA2ruK9e8Yf6oj2fysJc3veHXy1dYz+IucuJmXAMj9Q6JaxxMooyPDRlEBjZL87oUWvAeUDTElu4AM0DBgDG82g4lebzCFHtigVgsc7er7diQ2l6mZHgRVsvKxX8XGhHQPR05OSq0kLLnkjaSNZUjVSFSa91OplNLw5ddUMqlF520uCCQPN8AQwBHr00KZ53fWRs0FB7z0uYLM/PpMHkk/lLmOMZ8d6rSyyv50wgb1aaCPKwiq/eIHhhF4kwIvSShNm32b/iJMQTCWmafC7/bThz2B8GT7j3iSeu+3yN/HvSJ69SLQG1y4ZEtwotnAniznuK34ajXP5cR6qQXALNCklJeomU5i0dzCbJQNw1xzwgmxjoUXXUEQFLk6W31qVxix7e9+oS/knaZCIFfunSyhvwo1p49r2O2J4yQm5UoQHvELN2Jgo+QMycmL3dY+52c0ixYwDNGV5D7WnHR/AAHRxkBdOiMAEkCycEVZfE1/6qKjWiHv10pGQpQeXRYXBFodpEW8KmPeWofBiy+fsD+a+2GYq2c2uS+kxdmk5cz0iXw6Ww0a67Eg8AI+kJFQuzhuuw3aQIOWe8ki9qoGwSH8ZVPJcN30zPs1yRrBdUTZtLhI1wAuxvoLnSqhjuDHUn1KakYqYTJ1chzHoyRxYP9T9UFs6Yl2XEkNT0/DcardVhyQexbur6NjW2cf8DjphUbapdck9nC36oiAQaSl0K5TGnT8FtrD9m567ltIf/QlWGMYLZvivQl8nVa6dZLa/DpXYZ51uT5iB/sj5fh8xpNg9aR Rp6Spi2r lwcuhkqtwxuA638Unb+tXd0Z2/TIIxDteSX0BWntLaTosn7WLAlHr+zBYdhz0egwlfXPDebfNRlkS26gBDrH3KcLCvX4LB6HzsW8jSiezxIQP9rc8cXTgXgMZ9eIo3RvI7ZmaMIK7ZzkQS18qtQ3WIo5dtKFi3tz49B2WdCmpuZ7Vk04lL8jJZygbinOyt54ukHiFK9mNa6bY6N+78eKQXkB4APLXqVdY4W3rZ/4J6wtbWBDdW3FWnFWZDSIHqexJMAGrot/l5woJlhX3ydp1+NkL5AmfOUmYYYDI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09/05, Andrii Nakryiko wrote: > > +static struct uprobe *find_active_uprobe_speculative(unsigned long bp_vaddr) > +{ > + const vm_flags_t flags = VM_HUGETLB | VM_MAYEXEC | VM_MAYSHARE; ... > + if (!vm_file || (vma->vm_flags & flags) != VM_MAYEXEC) > + goto bail; Not that this can really simplify your patch, feel free to ignore, but I don't think you need to check vma->vm_flags. Yes, find_active_uprobe_rcu() does the same valid_vma(vma, false) check, but it too can/should be removed, afaics. valid_vma(vma, false) makes sense in, say, unapply_uprobe() to quickly filter out vma's which can't have this bp installed, but not in the handle_swbp() paths. Oleg.