linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: akpm@linux-foundation.org, Liam.Howlett@oracle.com
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
	Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH 2/2] maple_tree: not necessary to set pivot 0 before mab_mas_cp()
Date: Sun, 15 Sep 2024 01:25:48 +0000	[thread overview]
Message-ID: <20240915012548.31724-3-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20240915012548.31724-1-richard.weiyang@gmail.com>

mab_mas_cp() at least copy one pivot, which is pivot 0. This means the
pivot 0 set by mte_set_pivot() will be overwritten.

Just remote this redundant code.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
 lib/maple_tree.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 31964c5c677a..b02d812e1489 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -3174,7 +3174,6 @@ static inline void mast_split_data(struct maple_subtree_state *mast,
 	unsigned char p_slot;
 
 	mab_mas_cp(mast->bn, 0, split, mast->l, true);
-	mte_set_pivot(mast->r->node, 0, mast->r->max);
 	mab_mas_cp(mast->bn, split + 1, mast->bn->b_end, mast->r, false);
 	mast->l->offset = mte_parent_slot(mas->node);
 	mast->r->min = mast->l->max + 1;
-- 
2.34.1



  parent reply	other threads:[~2024-09-15  1:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-15  1:25 [PATCH 0/2] cleanup mast_split_data() Wei Yang
2024-09-15  1:25 ` [PATCH 1/2] maple_tree: the new max of left side subtree has been set Wei Yang
2024-09-15  1:25 ` Wei Yang [this message]
2024-12-02 17:32 ` [PATCH 0/2] cleanup mast_split_data() Liam R. Howlett
2024-12-02 22:14   ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240915012548.31724-3-richard.weiyang@gmail.com \
    --to=richard.weiyang@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox