From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDD3FFC6182 for ; Fri, 13 Sep 2024 21:54:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 303546B00BB; Fri, 13 Sep 2024 17:54:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28BD66B00BD; Fri, 13 Sep 2024 17:54:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 106596B00C1; Fri, 13 Sep 2024 17:54:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E35A56B00BB for ; Fri, 13 Sep 2024 17:54:38 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 668FE1C579B for ; Fri, 13 Sep 2024 21:54:38 +0000 (UTC) X-FDA: 82561069836.10.439FF98 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf24.hostedemail.com (Postfix) with ESMTP id 0D368180004 for ; Fri, 13 Sep 2024 21:54:34 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=cEu4g4Lt; spf=pass (imf24.hostedemail.com: domain of lkp@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726264422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1b5404QhlvrBGEZc5wA1p6Od7yduyTaS8w/B81sCm0I=; b=CedhqRuUWeEnl+VTAqGjn9m7rqTfE78/8D7EEyBZmWooBCHqh4miyqKca1QteZqJKAd8Mq qmaavcebRCOtZyC5max/xU/HShs2LGcEvEvS+MxL8iAAOqwo9OvaB7yFKuSwE45yuP/Nxx 5+wrCPW7WTRgqPoEw6u2ersx6QKSVOk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=cEu4g4Lt; spf=pass (imf24.hostedemail.com: domain of lkp@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726264422; a=rsa-sha256; cv=none; b=dPyDgz6bw7EzELPJiyQbrmGQZ2rzXq8d4TlmPlpSZ1NQmBehU4h3CMtxM7vDySdAzXwxrj 7/xIihvXYVQNA+skVsMoBOHrkhnA2vEgeMrPNVWplGzolv/3mnJ+d+MANDxqQ/9rYvTajS JR5UPX8kYNXL5zQhPfcrelNuhW8PVwQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726264476; x=1757800476; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3lZUdhEvXyxFpVtcD0HH4jrUJUk05bEvQqokX6JrCz4=; b=cEu4g4Lt2mx+p/a6blPZr/g1wWLpAB92B7y2LY7jpNgWH/FaM4E4xDbu dtVb13wBo36PeiJMVTxaZVJQrf7RLqiBMCcnTY5Cf45bjrIiCeJHyoFa3 CR9vxBBw8Fk41/xxm5WJ7LwtpfrABsnQ3n4z8nfgk2BJ/zzZyvgQxYJ7L nCWKy7JmSlQiSdLAwcRL1lx2+i/FAWBKnOhb5fHBm8EhLE0mHglOfBZPt Ql1kZeDFhXIzw/yTQY22Er/yzn3bWmnuQ2jesPetuG5z920M/j9kXzP5y cZndU0KoO5LSPmf9Lt+tJCKKnlA/oTjLQkNUhy9YvAC+OGkURhjE1WxfC g==; X-CSE-ConnectionGUID: iRcnr6nlSOGAU6L5nP/XMA== X-CSE-MsgGUID: CdswDINFR5qCZsNjUKZ16w== X-IronPort-AV: E=McAfee;i="6700,10204,11194"; a="28964279" X-IronPort-AV: E=Sophos;i="6.10,227,1719903600"; d="scan'208";a="28964279" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2024 14:54:32 -0700 X-CSE-ConnectionGUID: Gt72Uv39TH+t4tZEuHFxyQ== X-CSE-MsgGUID: L8tABuovQbKL349MY0ASiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,227,1719903600"; d="scan'208";a="72802513" Received: from lkp-server01.sh.intel.com (HELO 53e96f405c61) ([10.239.97.150]) by fmviesa004.fm.intel.com with ESMTP; 13 Sep 2024 14:54:28 -0700 Received: from kbuild by 53e96f405c61 with local (Exim 4.96) (envelope-from ) id 1spEFF-00074Y-1n; Fri, 13 Sep 2024 21:54:25 +0000 Date: Sat, 14 Sep 2024 05:54:03 +0800 From: kernel test robot To: Jesper Dangaard Brouer , tj@kernel.org, cgroups@vger.kernel.org, yosryahmed@google.com, shakeel.butt@linux.dev Cc: oe-kbuild-all@lists.linux.dev, Jesper Dangaard Brouer , hannes@cmpxchg.org, lizefan.x@bytedance.com, longman@redhat.com, kernel-team@cloudflare.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V11] cgroup/rstat: Avoid flushing if there is an ongoing root flush Message-ID: <202409140533.XqO09tth-lkp@intel.com> References: <172616070094.2055617.17676042522679701515.stgit@firesoul> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <172616070094.2055617.17676042522679701515.stgit@firesoul> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 0D368180004 X-Stat-Signature: cgpbggsdwrb95dtnzg86wsndk9gek6x1 X-HE-Tag: 1726264474-674585 X-HE-Meta: U2FsdGVkX19uUY5sY9FOPO1dIspG2ELdWKTgFFr66r9nknClMA0w32hTqZ/xZCbVXjqI/zU7Z+8xC+MivXDNIIPSxf0JOt56xqXI0WhEAE/brKLtSyso1gRbEFfYToBG2cpIFA4MqQaIBaOY3+aOYoYEtpv4phYUVN7uxRb6vfNP4Ek+PgbzugdDKn15xRGiGZWFfvgSaFXs54ZnrFPzynHNuiV/dG2z5ZosmCXUJB/bQN6/cFKKPedmqw74n5GBudEHzMqU0U8UFxJ6ZgnB5QGrc6G9HhvCMVMGLpNHU4ZAKONM9MiXtlo3Haf3INbCdzfk++8v4BK/x0hQFTP6y7a2w099Jz9Dg5ZqylQRCXfcGFuhNF/jb8agQO06XHcjIEOZLWRsNB+k+SqCUNhi8mc1RrBg/E7fr8fHOaaGzdo/bkRrmigHRa6CPImXR3ZntxQmOGybgS7UI3H3Q2YrswIuAH+JAEbVq1+A2SUulQaCFSGiR2LKa26MxWMsL/faJf2Xo27SY1NSSZTg8PVZFYRKNMSiwn5dgzCgvZO0IF2+n6GXEfwnx23xLdhCApF/pyj0z1ye/RJLOg61niRM4SXqIzTn2w6InEv75tbtyYYuHYhhZ7aWkgoQF0g0bplSKfHTFG74Wwk9bTurF2cA5N6C68OVqV/3T8htpqlNBuAtpaFyjT53tBj/DUmpQBZQDNkrlh5p/yph7rCU8FujNhwHAaj6iAfFL7/ER2M90x6OXdvrYz3Q1+qEXvSgcYPWgFX0i+WxGbXKMsZ4foL9vGodhPDU1Au75DJNl0WMSb1Arx33UV4IPuNJjACfaWJwmGltTKsOkex2wp0f6RX0VbgTkN8tJUkd2BRTqEmp7/KdIa2Q8/iRj3gZGMveZwpynf/g/MCn3D5g60fLKVONb3JMSo3ys9GqAzU1CLqx8h5vmOQZ3vFsWyTau7+eokVwYtQHDxd4/pkSfrSTise R3pCFV9w FKXepiorGqRAxz9kqS5MAn/lld2xfE3eNFzeyUuoqeIGiDgHUa++3QdQ7VVtcw0wyAvZT34C2+RsSbxIasKzwyMJ4uAdFfrp5qYEcUsTwWbORmGWwks2WT1GAvPaKBDhntyVRpxhAFURNxcYVzT29f4Tak2tut0n4EMcGUDye8aoWMSINWnYGQBncc/uOaXtGuN7UMqYV4jr0ZGPhwnmqV99DV+UnR1HDW9wzZD4isPBFsBVB9QuVr99ZHf4x3RSe/YpFQERAC/d39Jxh5fFWB16/Rx4T/aG0V/R1Ncl7lWj90uSDHo5ptJdxC77aO549Gi/cXw7ny8IoURoosa5YA5ZQV7LpPZFRkyJG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Jesper, kernel test robot noticed the following build errors: [auto build test ERROR on tj-cgroup/for-next] [also build test ERROR on axboe-block/for-next linus/master v6.11-rc7] [cannot apply to akpm-mm/mm-everything next-20240913] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jesper-Dangaard-Brouer/cgroup-rstat-Avoid-flushing-if-there-is-an-ongoing-root-flush/20240913-010800 base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next patch link: https://lore.kernel.org/r/172616070094.2055617.17676042522679701515.stgit%40firesoul patch subject: [PATCH V11] cgroup/rstat: Avoid flushing if there is an ongoing root flush config: i386-randconfig-141-20240914 (https://download.01.org/0day-ci/archive/20240914/202409140533.XqO09tth-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240914/202409140533.XqO09tth-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202409140533.XqO09tth-lkp@intel.com/ All errors (new ones prefixed by >>): mm/zswap.c: In function 'zswap_shrinker_count': >> mm/zswap.c:1225:17: error: implicit declaration of function 'mem_cgroup_flush_stats_relaxed'; did you mean 'mem_cgroup_flush_stats_ratelimited'? [-Werror=implicit-function-declaration] 1225 | mem_cgroup_flush_stats_relaxed(memcg); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | mem_cgroup_flush_stats_ratelimited cc1: some warnings being treated as errors vim +1225 mm/zswap.c 1197 1198 static unsigned long zswap_shrinker_count(struct shrinker *shrinker, 1199 struct shrink_control *sc) 1200 { 1201 struct mem_cgroup *memcg = sc->memcg; 1202 struct lruvec *lruvec = mem_cgroup_lruvec(memcg, NODE_DATA(sc->nid)); 1203 unsigned long nr_backing, nr_stored, nr_freeable, nr_protected; 1204 1205 if (!zswap_shrinker_enabled || !mem_cgroup_zswap_writeback_enabled(memcg)) 1206 return 0; 1207 1208 /* 1209 * The shrinker resumes swap writeback, which will enter block 1210 * and may enter fs. XXX: Harmonize with vmscan.c __GFP_FS 1211 * rules (may_enter_fs()), which apply on a per-folio basis. 1212 */ 1213 if (!gfp_has_io_fs(sc->gfp_mask)) 1214 return 0; 1215 1216 /* 1217 * For memcg, use the cgroup-wide ZSWAP stats since we don't 1218 * have them per-node and thus per-lruvec. Careful if memcg is 1219 * runtime-disabled: we can get sc->memcg == NULL, which is ok 1220 * for the lruvec, but not for memcg_page_state(). 1221 * 1222 * Without memcg, use the zswap pool-wide metrics. 1223 */ 1224 if (!mem_cgroup_disabled()) { > 1225 mem_cgroup_flush_stats_relaxed(memcg); 1226 nr_backing = memcg_page_state(memcg, MEMCG_ZSWAP_B) >> PAGE_SHIFT; 1227 nr_stored = memcg_page_state(memcg, MEMCG_ZSWAPPED); 1228 } else { 1229 nr_backing = zswap_total_pages(); 1230 nr_stored = atomic_read(&zswap_stored_pages); 1231 } 1232 1233 if (!nr_stored) 1234 return 0; 1235 1236 nr_protected = 1237 atomic_long_read(&lruvec->zswap_lruvec_state.nr_zswap_protected); 1238 nr_freeable = list_lru_shrink_count(&zswap_list_lru, sc); 1239 /* 1240 * Subtract the lru size by an estimate of the number of pages 1241 * that should be protected. 1242 */ 1243 nr_freeable = nr_freeable > nr_protected ? nr_freeable - nr_protected : 0; 1244 1245 /* 1246 * Scale the number of freeable pages by the memory saving factor. 1247 * This ensures that the better zswap compresses memory, the fewer 1248 * pages we will evict to swap (as it will otherwise incur IO for 1249 * relatively small memory saving). 1250 * 1251 * The memory saving factor calculated here takes same-filled pages into 1252 * account, but those are not freeable since they almost occupy no 1253 * space. Hence, we may scale nr_freeable down a little bit more than we 1254 * should if we have a lot of same-filled pages. 1255 */ 1256 return mult_frac(nr_freeable, nr_backing, nr_stored); 1257 } 1258 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki