From: kernel test robot <lkp@intel.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: [linux-next:master 9293/11623] drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c:1014:51: warning: 'DCEC' directive output may be truncated writing 4 bytes into a region of size between 0 and 53
Date: Fri, 13 Sep 2024 17:22:44 +0800 [thread overview]
Message-ID: <202409131718.JZ7cRIiX-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 57f962b956f1d116cd64d5c406776c4975de549d
commit: 056f2821b631df2b94d3b017fd1e1eef918ed98d [9293/11623] media: cec: extron-da-hd-4k-plus: add the Extron DA HD 4K Plus CEC driver
config: parisc-randconfig-r113-20240913 (https://download.01.org/0day-ci/archive/20240913/202409131718.JZ7cRIiX-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 14.1.0
reproduce: (https://download.01.org/0day-ci/archive/20240913/202409131718.JZ7cRIiX-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409131718.JZ7cRIiX-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c: In function 'extron_cec_adap_transmit':
>> drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c:1014:51: warning: 'DCEC' directive output may be truncated writing 4 bytes into a region of size between 0 and 53 [-Wformat-truncation=]
1014 | snprintf(cmd, sizeof(cmd), "W%c%u*%u*%u*%sDCEC",
| ^~~~
drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c:1014:9: note: 'snprintf' output between 13 and 72 bytes into a destination of size 61
1014 | snprintf(cmd, sizeof(cmd), "W%c%u*%u*%u*%sDCEC",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1015 | port->direction, port->port.port,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1016 | cec_msg_initiator(msg), cec_msg_destination(msg), buf);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/DCEC +1014 drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c
1000
1001 static int extron_cec_adap_transmit(struct cec_adapter *adap, u8 attempts,
1002 u32 signal_free_time, struct cec_msg *msg)
1003 {
1004 struct extron_port *port = cec_get_drvdata(adap);
1005 char buf[CEC_MAX_MSG_SIZE * 3 + 1];
1006 char cmd[CEC_MAX_MSG_SIZE * 3 + 13];
1007 unsigned int i;
1008
1009 if (port->disconnected)
1010 return -ENODEV;
1011 buf[0] = 0;
1012 for (i = 0; i < msg->len - 1; i++)
1013 sprintf(buf + i * 3, "%%%02X", msg->msg[i + 1]);
> 1014 snprintf(cmd, sizeof(cmd), "W%c%u*%u*%u*%sDCEC",
1015 port->direction, port->port.port,
1016 cec_msg_initiator(msg), cec_msg_destination(msg), buf);
1017 return extron_send_and_wait(port->extron, port, cmd, NULL);
1018 }
1019
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-09-13 9:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202409131718.JZ7cRIiX-lkp@intel.com \
--to=lkp@intel.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mchehab@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox