From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E85AFC6160 for ; Fri, 13 Sep 2024 16:41:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30A7D8D0005; Fri, 13 Sep 2024 12:41:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 292678D0003; Fri, 13 Sep 2024 12:41:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10BE28D0005; Fri, 13 Sep 2024 12:41:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E20F48D0003 for ; Fri, 13 Sep 2024 12:41:45 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 942C714081B for ; Fri, 13 Sep 2024 16:41:45 +0000 (UTC) X-FDA: 82560281370.04.DA0A7AC Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf26.hostedemail.com (Postfix) with ESMTP id 4F3C0140016 for ; Fri, 13 Sep 2024 16:41:43 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=G6IFee2U; spf=pass (imf26.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726245649; a=rsa-sha256; cv=none; b=PpaOwsTa7UlCVq3p4AE/+l5M68ajKICejNrNHNvbZVoeAA3LNaNICjDR6qepiZZx12aviK qOTC02X6M1RO3g4E+yR/6IjTFSCBA6lmSJrsTXgNX/oQq7DESMf8PwOYZmGDfRIF965D/v glB1YDQj0TBauvjfc04GioytX+ifFTs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=G6IFee2U; spf=pass (imf26.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726245649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7Dg3Ylc2He7FCFRo4RKK39b1kxUf9gVymcWyf4XGQS0=; b=tSHQMO1PM23Qr8IPFqc3c7deRwMNLmDbO7WKLABqI+HtPQr4Wefs8c0Pkjf5mwcv5Ox4RN KclJOx2bGIoJGZmLghp8tWODfRQwG89syrBWT5FcQIWUiY7IArbnnjQADWfDhWgTOJP4tZ CaKuC/E9YbCmsVQjvtCpmZn2r+1Poos= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 4004A40E0191; Fri, 13 Sep 2024 16:41:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TQ8_o6yyL2dF; Fri, 13 Sep 2024 16:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1726245694; bh=7Dg3Ylc2He7FCFRo4RKK39b1kxUf9gVymcWyf4XGQS0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G6IFee2UkMMI9gdLH6zlIgoVyztRuscsINHBnL4AzKQngx4n2l8xWmksx0E4E6lSv PqUUrhTwr8ClfsKmERZs8I7Xo3N3n+bWMD9tJDk4ex9DPeuCZn0p0diP7E3D48703/ ALMnKaKUIwSozfCX0MwhgxZ1n5q70AUm1H0BgyycI61JUrPHyNgmiJ1CHKfeXt6T0n Jv8GjHuEyRHfWBXNutLb+92iSgiaBUON+kWd0EUdbLxanATdjNiDTKsnCg+hMisveS mE3wTVbFsdGzLD7c3goAebISngPklPt012brCYGm9rM+gynhjwLWOTfC1Z2H6HXhN+ 2t9Cdz2+CKs7glxYh4vPjsZs+fGqj2UIh5V2cBbOw9RFRaKMpku096ws3s+3NyJwCw Zrpyktl6OqsxTO+lkZdNb02KSgB8t5reuFJuX3xM4O82XvzbtYIpSagddWn8mslsuK fHgE8X2Wv6CzuzfJF6nYj758oFRS4bSikMi/jrmlsHannUOaAov3csmbt97epXp+Xr JmE9z99pMQUvdeyWkOlTUa8/GrvgjiU4osg4Fx0vjcdhI5NZEVe6OCSBciAq+kLo2Q /Kh2BUGpj81g2XXF9dEfHIabwXCNaUz/Wmx3JPmw38mpAgX1p7MJzbZoNYZmN8LYKU m8nNaXiHsqNYuqXQqPXGgQjc= Received: from zn.tnic (p5de8e8eb.dip0.t-ipconnect.de [93.232.232.235]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AC2A140E0198; Fri, 13 Sep 2024 16:40:47 +0000 (UTC) Date: Fri, 13 Sep 2024 18:40:41 +0200 From: Borislav Petkov To: shiju.jose@huawei.com Cc: linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, jgroves@micron.com, vsalve@micron.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v12 01/17] EDAC: Add support for EDAC device features control Message-ID: <20240913164041.GKZuRrCeoFZBapVYaU@fat_crate.local> References: <20240911090447.751-1-shiju.jose@huawei.com> <20240911090447.751-2-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240911090447.751-2-shiju.jose@huawei.com> X-Stat-Signature: uhxo5m8ogb86ja9bbi6ytis8mtn36oyx X-Rspamd-Queue-Id: 4F3C0140016 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1726245703-930755 X-HE-Meta: U2FsdGVkX1/4DrYsSpkFsloWDzEyJwqgQlzNwz+SsvJnfqu3l38h13V83zRQ0vhZVk6ec/yjmfnu6eiksNbCBqh1KqRLwZPEeRDO4e8NMpMGstKvGEDQkQ1pXI7XRZtQBJ2gp/qwmd5UbM/WREtmnhDRrA9CEL9oelQuBIhgdPkQq93X4k4SULtve1sZMqUggZ3sLCzL2ybfHSQLZ4WcT3gDWPFL9AKxvv06czEuVwTwCnli958DXjpmPmOsao4t+P45hcyVV6Ao6NIl7OSoPZ7rNo54LdHcdr0WMmCAYMnCpCyPF10g9EU3M8YR0q+KIa+rhW2+19OthsMIi13/DiDRIzGpEDhY9EklyX5vzXfsJvhajUsUG2mmsfJmmC6oryv/Tjkj6fg7nEiCd+33LAbhphqzXc3OfuDpg9r5szNbyaj8LNQuUBdH2wnNLiEwwIfvUZws1ncbtkOYZ9IQ16UBKYSUFeAtfrlq3jbpoz2Rtyqk1UkS+21bm2CAJg9kIdRHD8/oWoZ9JNRg0j9LMJADfkwMH4+wr+DQ7c10hDcNt3tbo6WhXTdWqLZ7U4qFyhfEN7pSc3movBJMNtWkFp+VLeZvFuIuEqPi6Y6oceC7jsyA0uN3ltY4c/Dyt7t69Nst4jLIv5AvtrHD7EbPZqtYtp4oowtWjAXUVcGAHVe8EXALFlpxRPEKfuuZ7rdeEC/AKW6X6rkA+opmwIZGOzsB/fL1dNu018z+LgmIFJFZreP2YSupt/aOBRgmXmDQcJYYOsIjUfRLqVFDHtnEqZuas9EXJ57FUYezyGFuMSAmAONZRbN/No3sEok28QWtmNCwbWijZ91UeEg9g+BX3BqT7tD/fP+Z8oHc0HeSi+62E7HDAt44qNAJ1vcWKo27PWCcX+EEiJ8ZCR6Ru+Jph3JQFIoHx6UdBytHJRE2LtLRefuFtlXGRh5kDl8pMt0uG+qbmmHQ33ze6cWCz51 EBQibUVR F/6+B4H2e5xYx3jmVW8IjPNvdlvWg8ulsBfXG10GxelAKOgt8LDTXpqHeUB0U2w8Fqw4RcBNtL20GyQX6UdT5cIFGDIVRh9RZEqB+QUfG3Kmr9DQ1jNODCWuYzRw8gvi/Nl4uh1mYPqjGxI3TaR3NankY6tiUPkRKOvPA89TULHNceU93JtmzkHGPSdJqIfDwmXWkRMua6YxCiEP08St3L6Z3Gs3tOGqpgcEv/QrmAT41CN67WoiyYOcFNfzAQc1PQ9x1TxrrYfSbAkfpjb3O59HYYV0qbgnlcPCMu7k+ok8WL2c8rTGq5dtmd2sxktovoDX0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 11, 2024 at 10:04:30AM +0100, shiju.jose@huawei.com wrote: > +/** > + * edac_dev_feature_init - Init a RAS feature > + * @parent: client device. > + * @dev_data: pointer to the edac_dev_data structure, which contains > + * client device specific info. > + * @feat: pointer to struct edac_dev_feature. > + * @attr_groups: pointer to attribute group's container. > + * > + * Returns number of scrub features attribute groups on success, Not "scrub" - this is an interface initializing a generic feature. > + * error otherwise. > + */ > +static int edac_dev_feat_init(struct device *parent, > + struct edac_dev_data *dev_data, > + const struct edac_dev_feature *ras_feat, > + const struct attribute_group **attr_groups) > +{ > + int num; > + > + switch (ras_feat->ft_type) { > + case RAS_FEAT_SCRUB: > + dev_data->scrub_ops = ras_feat->scrub_ops; > + dev_data->private = ras_feat->ctx; > + return 1; > + case RAS_FEAT_ECS: > + num = ras_feat->ecs_info.num_media_frus; > + dev_data->ecs_ops = ras_feat->ecs_ops; > + dev_data->private = ras_feat->ctx; > + return num; > + case RAS_FEAT_PPR: > + dev_data->ppr_ops = ras_feat->ppr_ops; > + dev_data->private = ras_feat->ctx; > + return 1; > + default: > + return -EINVAL; > + } > +} And why does this function even exist and has kernel-doc comments when all it does is assign a couple of values? And it gets called exactly once? Just merge its body into the call site. There you can reuse the switch-case there too. No need for too much noodling around. > diff --git a/include/linux/edac.h b/include/linux/edac.h > index b4ee8961e623..b337254cf5b8 100644 > --- a/include/linux/edac.h > +++ b/include/linux/edac.h > @@ -661,4 +661,59 @@ static inline struct dimm_info *edac_get_dimm(struct mem_ctl_info *mci, > > return mci->dimms[index]; > } > + > +/* EDAC device features */ > + > +#define EDAC_FEAT_NAME_LEN 128 > + > +/* RAS feature type */ > +enum edac_dev_feat { > + RAS_FEAT_SCRUB, > + RAS_FEAT_ECS, > + RAS_FEAT_PPR, > + RAS_FEAT_MAX I still don't know what ECS or PPR is. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette