From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD1F4FA372B for ; Fri, 13 Sep 2024 08:42:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25AEE6B00CC; Fri, 13 Sep 2024 04:42:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20B676B00CD; Fri, 13 Sep 2024 04:42:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D2B96B00CE; Fri, 13 Sep 2024 04:42:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E27E96B00CC for ; Fri, 13 Sep 2024 04:42:13 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8845C140472 for ; Fri, 13 Sep 2024 08:42:13 +0000 (UTC) X-FDA: 82559072946.05.582DB18 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf01.hostedemail.com (Postfix) with ESMTP id CA2A940011 for ; Fri, 13 Sep 2024 08:42:10 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="U/9uu7Xw"; spf=pass (imf01.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726216877; a=rsa-sha256; cv=none; b=C06tCHvFLHFOB3FB4p6RHrCpb7qVTtyHMpXDidiq+UK9g2evCBMbrpGS0YI5A0pyzeGqPp DBTSwvNDk8yJavXUg+Pg1TA96nCzqyfErOu6aCuZUplug4Fi/Jc9LoqhYN0ev/6eGoQQkA jiIqBKObmtMMoIXoEqmYNX/qk+PJ+Wk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="U/9uu7Xw"; spf=pass (imf01.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726216877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LAf6vYkUz/5b6u9Gi1nkVzbA+KZwBVbDm216yFxN7iE=; b=bLLy7hjNe7Xv8GLIO6XoCUc1sOZctwaefWZpEdWEm/JJrn77dXz2C0utL2DyS+kg4ZRa8n rfJ28py5TBheIzEM0jz/W5+oRClu35UBc7a37i7F+c0bEOQb5z2PHuRVv1yFFH2pzmmaPv C/PCkxISQd5Q7hxNrIsmzfjzrgGgExM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 67FA9A45B9D; Fri, 13 Sep 2024 08:42:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 115F8C4CEC0; Fri, 13 Sep 2024 08:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726216929; bh=vLgohYNgBdTnlJ4g9SONXPoERXC0FWUfWH1OdJM2HjE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U/9uu7XwGITTR08CEgMHOSUUSUGIufRzU9l1duP3ChNczaWlfLp5etGZXZ/aM1Xkg LZSbo9JZbRcf142AOUyPHkHARiBGz6R/vRZog6BEjfrZvtrnZxnbUQrSMCKb+sTQ7g FHeAQ8XahsMUJjF69aMBCu8pFyju6gzaorOpe5gzFYRLz6G02kKKanD1O/5ZDV10yn 8hA1zUPdVq+Yky/e+FkuuZd81iKpKUCWDhnIv91V3o3iLgcxsh37fJWWDOxyepdd0V 6syKnsbBx1VHJR2K6VCcWt1A+LnfeKflCi1q9WhsXcP77yvjH+ROY1CbMPulTIl4RC 6Y6zzr5WSq57w== Date: Fri, 13 Sep 2024 10:42:04 +0200 From: Christian Brauner To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Kees Cook , Roman Gushchin , Jann Horn , Mike Rapoport , linux-mm@kvack.org Subject: Re: [PATCH] mm, slab: restore kerneldoc for kmem_cache_create() Message-ID: <20240913-sichel-gelesen-a3335086b967@brauner> References: <20240913083713.14838-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240913083713.14838-2-vbabka@suse.cz> X-Stat-Signature: f6ayxc9a54ae9t6fiywg3pizrroskxxr X-Rspamd-Queue-Id: CA2A940011 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1726216930-567987 X-HE-Meta: U2FsdGVkX193hjVSqrZ2gzhDXCCQOSZIBEKt7It2IbMzfQ27N7ON6409BYf/SnZSJOT5I/Q3/Fim+XddMJwm1b/kKWV0aJCvfwbIpmt/cdAajoKiG1//S+KvJ2UZc11unLPawEfaSRLlunkbbPKn1lc4FZciLbDcBj2lFVUJANLZOmDsI/x63l3AqM4K0VDeBXsdzYKpzPr50wp2NMdEXZLat7C+rOFXhgTwDvhixYkoLK2KYDJsJmI0sVh7lrzIXRtZpC3wgrOn8/PRAtypHPrp3MJ/FhZJT4Xuhncetv6J+/O90WMnpaeMLair/nmuyzE+TrAhtBzCrJtZEZK1VX6weama7XRCl8vrCByBnOZYxr3271Tjkt4p6dHnwZ25T/Tt2nvCXXKcjLGSsl9fUS9vZ8qlkwktS5r4fHZdAPjKfbs+CvgiJSsrk38rSTRRRHtdkkaK4rL2dbmyxw2DKNvYlwXub+EWQV1L3R4ZPCMPEmx8kLQJeTc2NApvaNQdOG92/vHqkeixMxwSK6o9nFwuPANAnwsmrWWemQHQEIwphMdsFBp4OfUJBKVl9g+8BLc9/afnShhbAD1E05SpWhwK8HiROMwuw+T/cIeyHAyMo/Y6G4HD7xNTGWTQaagKf/saHZzAZojXzbK+mmQ56wdNXBs5Ln4G3qv2nvgvjsJ+BMji6K4ZTXCouQyt1HgBAQEFPaV3qQEGuCmfgUGhFwGMsNWHYc1uW2600rm1C7Mpg4y5wNfOPdw8gZMZuZnyhPQRwVgVl5rLLgMYuSMMEaROJXNfQ5Q1UxGY3GRfFHoXL02YTcl9rDA+t4+yE1eWbh2FanfjNlhPXyEBtd0InyIEDraf80Trjl1QLXxz3mDKcSpp9F0kZoG0Ijai2dW9P9LG6uen4JU9v7V3EsCYjwC5fhuvLqkAp1ftkpPQLijhcM1OxiFM/Tr9CSmzzZ9r5fH4Nuaje1QnyAPVT+H ENS08Nkz uROy8BWIJYKZ4l+MAWrRCnSsxCBsDOuBIcHAnHeZyUc8L69Lg/6VITvB00Ahjr11vLVyj0mIXLo/mEsVrW+oUsxhgFCi39yLtrp2vbnoSuWz46kDnHHcPviTItkSC0CdhT+YVOPRoAyLn7AD6o/SAPIiVEpTzchhv9AgSsDDPUJdvIf5gTTHrSKrBwHENuBcaQ7MnxhBhwU8Q+WgH9ximrJK2pRpRHThc0VKpCAgYviLSH+Vv6p2AkprR16xZWVMLmQNl8SZwxRy5osOTXMhfBmhoj2m2d7I1jI8OshF66z8Ps2I8kktOjR3EGAJu/dVGxk3YN6WCR8a3RFEqRIbK5rgWxWWQNqk7B8oEany1Af0D+1HSn4zZlfXV/wHAY+Hppf7xadJb4dO6t8tpcQkLVCRUyAWvT9vjNQ6coi5VtKTwIgqpZDJuaIBtCj5zh87RmYOg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 13, 2024 at 10:37:14AM GMT, Vlastimil Babka wrote: > As kmem_cache_create() became a _Generic() wrapper macro, it currently > has no kerneldoc despite being the main API to use. Add it. Also adjust > kmem_cache_create_usercopy() kerneldoc to indicate it is now a legacy > wrapper. > > Also expand the kerneldoc for struct kmem_cache_args, especially for the > freeptr_offset field, where important details were removed with the > removal of kmem_cache_create_rcu(). > > Signed-off-by: Vlastimil Babka > --- > A late change, but only changes comments and it means we won't regress > the kerneldocs due to the refactoring. Further improvements are possible > (i.e. turning descriptions of the main SLAB_ flags to kerneldocs) but > that can wait. Looks good to me, Reviewed-by: Christian Brauner