From: Christian Brauner <brauner@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Kees Cook <keescook@chromium.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Jann Horn <jannh@google.com>, Mike Rapoport <rppt@linux.ibm.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm, slab: restore kerneldoc for kmem_cache_create()
Date: Fri, 13 Sep 2024 10:42:04 +0200 [thread overview]
Message-ID: <20240913-sichel-gelesen-a3335086b967@brauner> (raw)
In-Reply-To: <20240913083713.14838-2-vbabka@suse.cz>
On Fri, Sep 13, 2024 at 10:37:14AM GMT, Vlastimil Babka wrote:
> As kmem_cache_create() became a _Generic() wrapper macro, it currently
> has no kerneldoc despite being the main API to use. Add it. Also adjust
> kmem_cache_create_usercopy() kerneldoc to indicate it is now a legacy
> wrapper.
>
> Also expand the kerneldoc for struct kmem_cache_args, especially for the
> freeptr_offset field, where important details were removed with the
> removal of kmem_cache_create_rcu().
>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> A late change, but only changes comments and it means we won't regress
> the kerneldocs due to the refactoring. Further improvements are possible
> (i.e. turning descriptions of the main SLAB_ flags to kerneldocs) but
> that can wait.
Looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>
next prev parent reply other threads:[~2024-09-13 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 8:37 Vlastimil Babka
2024-09-13 8:42 ` Christian Brauner [this message]
2024-09-15 7:48 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913-sichel-gelesen-a3335086b967@brauner \
--to=brauner@kernel.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rppt@linux.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox