From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DF68EED601 for ; Thu, 12 Sep 2024 13:27:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EE336B00A3; Thu, 12 Sep 2024 09:27:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8766E6B00A5; Thu, 12 Sep 2024 09:27:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 716D56B00A7; Thu, 12 Sep 2024 09:27:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 529F16B00A3 for ; Thu, 12 Sep 2024 09:27:10 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0C8F5806CC for ; Thu, 12 Sep 2024 13:27:10 +0000 (UTC) X-FDA: 82556162220.27.7645674 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by imf28.hostedemail.com (Postfix) with ESMTP id C4155C0007 for ; Thu, 12 Sep 2024 13:27:07 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="RXW/dnbQ"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf28.hostedemail.com: domain of lkp@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726147511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G1NgTMGovpDTDBeV4FrS9LKZyZkdNj+WztU9dg/B7f0=; b=zPuzGGiZESRlufXP00MY1hHJ4UfG0KvOq6KjxmFH7O3qgBjS8yzJRZmNk1FpNQrigyRdQ5 SWtLtTx3rq9Y2hyK7tA782jX174FNVvglaH+mcL9T8kbfGFcayxewpYHDgEANPzpuXy5KQ YJyqP2tye5TBX564zIkRgljS5mVQrYs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726147511; a=rsa-sha256; cv=none; b=Kw/LEa5pU5pr65nEJ9dZWEvDvNcqI3YUFGFUFabe+3o8YMAM9k4NKYHBI7Njnfh9XKOQaK fOA5+DiIxhQ8DHPrgQtqJMM+X3/hRwzuj38VGRFs1WkTbSZ5DM6Dfn+/d9jQH7vyREUrzx Ftq7eXKFTJ44J+Wi7BIBv8IH6g5hwnQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="RXW/dnbQ"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf28.hostedemail.com: domain of lkp@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=lkp@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726147628; x=1757683628; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tUaS76VvQX4XGFhuk6gjFwHoQxCFkYEuml2w3T1DJ/E=; b=RXW/dnbQpcRzi4iJPHUxsO6Q13SRPXEBsfYrFBTrlRG/DhsRTtZEYFh/ eLwetmM9w9MEt8meflnPDvvobTbnaTPGpSFqfLVa49cOD/auo8IldMB8w OP6Z71BlPzgVAVUJpso/zpPqWOVssYm5mcOASIUhLaIsD0Z92VbIv0N2y jYBZYNoLFPUnmISfysdHN/n4bcONiS2jv82T5f91/OEwioeWIhu0/ocAC GkItUsQhJEmxQDF1DaqpknI1z1VXIhVkBlR5P3ewgVjuqt+06AHWKU3uJ coEn9wT1dZKwbbHHDl2M/5X//kPqsJvnqbSPwjYAFihmDKydBmJmOGU9E Q==; X-CSE-ConnectionGUID: mpjCWmlYSLKkqFvX4BOPPA== X-CSE-MsgGUID: YITeIx27RMag7lClH9qE6A== X-IronPort-AV: E=McAfee;i="6700,10204,11192"; a="24873072" X-IronPort-AV: E=Sophos;i="6.10,223,1719903600"; d="scan'208";a="24873072" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2024 06:27:07 -0700 X-CSE-ConnectionGUID: pQ2ZG9unS2e3JtVKjW+iTw== X-CSE-MsgGUID: NYS44og0SFeXSbvdpqmaGA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,223,1719903600"; d="scan'208";a="72519619" Received: from lkp-server01.sh.intel.com (HELO 53e96f405c61) ([10.239.97.150]) by orviesa005.jf.intel.com with ESMTP; 12 Sep 2024 06:27:01 -0700 Received: from kbuild by 53e96f405c61 with local (Exim 4.96) (envelope-from ) id 1sojqc-0005DX-1Z; Thu, 12 Sep 2024 13:26:58 +0000 Date: Thu, 12 Sep 2024 21:26:48 +0800 From: kernel test robot To: Dev Jain , akpm@linux-foundation.org, david@redhat.com, willy@infradead.org, kirill.shutemov@linux.intel.com Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, mark.rutland@arm.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, jglisse@google.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dev Jain Subject: Re: [PATCH v3 1/2] mm: Abstract THP allocation Message-ID: <202409122144.jqe4JROY-lkp@intel.com> References: <20240911065600.1002644-2-dev.jain@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240911065600.1002644-2-dev.jain@arm.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C4155C0007 X-Stat-Signature: qnt89udzhhwj3169poroutuzabqehpde X-Rspam-User: X-HE-Tag: 1726147627-365725 X-HE-Meta: U2FsdGVkX18+lZhY5RFLeHEYKonzurN+6wLbBtwEZZfy0ayQf/0f/pWcFJiYdqzsLV4rjFlMxe3F3CwGXqujnkhTIZ+MjsSlZNX23XcLFtXU3xfJwd5/2ltISa+ciZ8CvfOI3wmGYcnq5uHl6vwRPXAtMPC922VqbP+IzfWMHHgdgcxvg99Zu8MBGrwZf2l5Q71OVUnHYF+YzEurkx7la8gKVzhsI3rnkz6ZhYy2MQgW8mVnw6VZPdFC7zsQOoG8HNtUZdFofsUlzhot99DNvVukqsj6OLg5wWSTXW8QiYzkGFnmWoRLYhB2MSV+USmymd8QlK9jVxn/qegYUQrmbQxGAI1nd75BJ6K3YxHaiXWCSqjjCcYUxPnpd+uufwiicXFxVrTF9EGgbDdGUFCJouSU4TvvZhTKdmDfZ/Uu9KDHL2FYaiky5t5ri42/FJHWi0DEpn8MjtPoJOxY4dM+xAs8fpe1GUe5WwKh4CjiWjjf1WkTx/XxIvVfxC0M6lJgMkERjRsNeOgFal3f82+3JWXLOlQRqzy0O2YWdM6yodrLCzW8QD/Zg2kyu2BliFlpZfIcSiUDtv+4058yVVMXVBB+ILToe1OrJHQFa8g9g+q20RGgVFWEtaaEH8vsP0yh/qA8EPPfB/2HNlziGvHqtxpReFUs3WI/HHFfOMxQsyzQ4KFSHkOglHuKho/HPKUILkMZ3KmokVzkPni2wDjn6s3SmahH7XuNrfgS4qYP1ybtd7XBHjtSGWHagjta4qEhZL8RQ6X7D1qfl4Kdp1klsXVoDcrJFa2U05I+LVNB1MjLd30SQRiv1C/IByK/1l7y81YfJISdCz3C4iXYqUEetb0Xzk8aqoFFlRedYlLvG8vuBkaFBxBVKvng7nvMRz/NQm020mrgaWtGTAEixpoCDWqdLrZveuZEB9sNm3XyXI7C42lwSixIqcRr4KcVEuQiym1Bb94S0L9gUnqSbxi OzPRZZxf vzBqmhsQ2sIKvXMJJxF8soQRDQG8J3U2qHeBGLK5c/NPSrQ7vCvtC+SHrkiC9X8QwbyYXGOdXAO4akX0FDnK6FHQR+Qm6G8ywkb44YVSuOgLLp7K2fCo4UdGMXR8P8rm3PQ2P57sPaHRdjybS2FGqL2W9Bw/45URHsuiU1J9qnoAh1msg80tKetpxplA/Dv4Dw40ts6/pfXBWEUr8TtzRboPj7kKAKNYFCqYQ54EVlakFOnHq6DjRwgSxpIjWM4NjjDvahNjLtc67T9lEljac0kwXRPrY5J0h4ZJ0glYr80/qca3qmpDl+3/laJ2tKdHTG0QGWErtg79VpbZo/s4IcC7qAPf4O2PaaeA0J+AqBfAn4hnxCDdfc2YK0E2nmt+U3fBWxZPonw7khpkANs6lXrcUPKb7lzGLJ+Pj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Dev, kernel test robot noticed the following build warnings: [auto build test WARNING on v6.11-rc7] [also build test WARNING on linus/master] [cannot apply to akpm-mm/mm-everything next-20240912] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dev-Jain/mm-Abstract-THP-allocation/20240911-145809 base: v6.11-rc7 patch link: https://lore.kernel.org/r/20240911065600.1002644-2-dev.jain%40arm.com patch subject: [PATCH v3 1/2] mm: Abstract THP allocation config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240912/202409122144.jqe4JROY-lkp@intel.com/config) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240912/202409122144.jqe4JROY-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202409122144.jqe4JROY-lkp@intel.com/ All warnings (new ones prefixed by >>): >> mm/huge_memory.c:1012:6: warning: variable 'pgtable' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] 1012 | if (unlikely(!folio)) { | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:77:22: note: expanded from macro 'unlikely' 77 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ mm/huge_memory.c:1051:6: note: uninitialized use occurs here 1051 | if (pgtable) | ^~~~~~~ mm/huge_memory.c:1012:2: note: remove the 'if' if its condition is always false 1012 | if (unlikely(!folio)) { | ^~~~~~~~~~~~~~~~~~~~~~~ 1013 | ret = VM_FAULT_FALLBACK; | ~~~~~~~~~~~~~~~~~~~~~~~~ 1014 | goto release; | ~~~~~~~~~~~~~ 1015 | } | ~ mm/huge_memory.c:1006:19: note: initialize the variable 'pgtable' to silence this warning 1006 | pgtable_t pgtable; | ^ | = NULL 1 warning generated. vim +1012 mm/huge_memory.c 1001 1002 static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf) 1003 { 1004 struct vm_area_struct *vma = vmf->vma; 1005 struct folio *folio; 1006 pgtable_t pgtable; 1007 unsigned long haddr = vmf->address & HPAGE_PMD_MASK; 1008 vm_fault_t ret = 0; 1009 gfp_t gfp = vma_thp_gfp_mask(vma); 1010 1011 folio = pmd_thp_fault_alloc(gfp, vma, haddr, vmf->address); > 1012 if (unlikely(!folio)) { 1013 ret = VM_FAULT_FALLBACK; 1014 goto release; 1015 } 1016 1017 pgtable = pte_alloc_one(vma->vm_mm); 1018 if (unlikely(!pgtable)) { 1019 ret = VM_FAULT_OOM; 1020 goto release; 1021 } 1022 1023 vmf->ptl = pmd_lock(vma->vm_mm, vmf->pmd); 1024 1025 if (unlikely(!pmd_none(*vmf->pmd))) { 1026 goto unlock_release; 1027 } else { 1028 ret = check_stable_address_space(vma->vm_mm); 1029 if (ret) 1030 goto unlock_release; 1031 1032 /* Deliver the page fault to userland */ 1033 if (userfaultfd_missing(vma)) { 1034 spin_unlock(vmf->ptl); 1035 folio_put(folio); 1036 pte_free(vma->vm_mm, pgtable); 1037 ret = handle_userfault(vmf, VM_UFFD_MISSING); 1038 VM_BUG_ON(ret & VM_FAULT_FALLBACK); 1039 return ret; 1040 } 1041 pgtable_trans_huge_deposit(vma->vm_mm, vmf->pmd, pgtable); 1042 map_pmd_thp(folio, vmf, vma, haddr); 1043 spin_unlock(vmf->ptl); 1044 __pmd_thp_fault_success_stats(vma); 1045 } 1046 1047 return 0; 1048 unlock_release: 1049 spin_unlock(vmf->ptl); 1050 release: 1051 if (pgtable) 1052 pte_free(vma->vm_mm, pgtable); 1053 if (folio) 1054 folio_put(folio); 1055 return ret; 1056 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki