From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1E28EE0206 for ; Wed, 11 Sep 2024 17:15:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71717940079; Wed, 11 Sep 2024 13:15:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C72B940066; Wed, 11 Sep 2024 13:15:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58E3A940079; Wed, 11 Sep 2024 13:15:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3980C940066 for ; Wed, 11 Sep 2024 13:15:18 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DF6B9C1A01 for ; Wed, 11 Sep 2024 17:15:17 +0000 (UTC) X-FDA: 82553108274.06.B9F2016 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by imf27.hostedemail.com (Postfix) with ESMTP id 7945B40018 for ; Wed, 11 Sep 2024 17:15:14 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UN245LJ9; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of lkp@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726074887; a=rsa-sha256; cv=none; b=zeCXpQWbVXMhkrwNOqxzcqqg5CKlPcrL7rZBT2uwb0zbl7gSp00YGJp/9alS0R72e87wjK WJCP5W/7M7uI0vZ34UebOo9wi91NR1p2Qd1x3Iht9yYRhE0ncuq97Pi5PhuPDU1UedsyQf HnwrKWQJJOjyX60jH2IjFXsOYVIPpAI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UN245LJ9; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of lkp@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726074887; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=5vSvhIVDyF6mdJSh0WqbJ3Sz+A/uKHoov500/vV1UAI=; b=YZTqYyPA29dZ517Ga0Bl1xqTzQne5z+tQeL7jgcMHs+hx8yjVHmnNyQBCEvxfGtuXL2yTR xVxiEzI2Nbyin2rbB2soHxhWO6le2+7dej6XoAnihDfiNuc2JkkyRa01ELhLVGel1/IHyI qbxYrl3kk2Ocdjk0Df6vPmrxSUuYbjg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726074914; x=1757610914; h=date:from:to:cc:subject:message-id:mime-version; bh=14W9sIWxLUkCkWLoX76SEaH8D6Xp9ESnArpldzuG1aY=; b=UN245LJ9jD9u1PVKtVkp17ZHHaBnha5B82/R+PtjTyrmjtRjq7losAef YXa8NAm1XT2vzBh4Xu1ilEx9oUD502MQAHAcxnDxLP3y6NimeUslDn87V shfjr+t+RdiaNt8Ii2A7j3oWLzpwMbk0YQ8mbtSN7BwEVuzYrkZPtaxLA AUp9mRfxjO10GKesqQHggE2LTV23+16C6Xhnv4kw9RaFpxUiCa5GQO2xV gPTTtkHOY9TtYLlIGZyUdUDpiHawOTMqMjO+7YaaCBPj/Wkf2sEQlFNhF NdaszVtvrdinPL6p4DNjpAdhcJ2v6fTv1dGZjjGJEZVuAc2orjCS0KaOY w==; X-CSE-ConnectionGUID: KYQGMyqLS8Kn4EUb2AE5YA== X-CSE-MsgGUID: 40W3Pfs9QTe0/eGWec2erQ== X-IronPort-AV: E=McAfee;i="6700,10204,11192"; a="36026770" X-IronPort-AV: E=Sophos;i="6.10,220,1719903600"; d="scan'208";a="36026770" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2024 10:15:06 -0700 X-CSE-ConnectionGUID: zGGpojq+RVaWs0OINNlC2w== X-CSE-MsgGUID: pOup2aJWR0y/ehEKQ7SjyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,220,1719903600"; d="scan'208";a="67489902" Received: from lkp-server01.sh.intel.com (HELO 53e96f405c61) ([10.239.97.150]) by fmviesa008.fm.intel.com with ESMTP; 11 Sep 2024 10:15:04 -0700 Received: from kbuild by 53e96f405c61 with local (Exim 4.96) (envelope-from ) id 1soQvm-0003sg-1R; Wed, 11 Sep 2024 17:15:02 +0000 Date: Thu, 12 Sep 2024 01:14:59 +0800 From: kernel test robot To: "Luis Henriques (SUSE)" Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Theodore Ts'o , Jan Kara Subject: [linux-next:master 5690/11210] fs/ext4/fast_commit.c:362:21-23: WARNING !A || A && B is equivalent to !A || B Message-ID: <202409120149.GdjqoVYQ-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: 7945B40018 X-Rspamd-Server: rspam01 X-Stat-Signature: 9m4gesk9s8ytkiipc7ksjnr6s7ejk5zz X-HE-Tag: 1726074914-265369 X-HE-Meta: U2FsdGVkX19M97/uefkL6eUlxg3e79FMHVBVdv0qXjyYE5eGnq5ervFWvzA1lrpIlk52cDGx8k9KDGIHEKINvt27AGTgpswHjaju1S0aiw0miWtG+FCxsu9/UFD5OFCdltN2gXeTMvn6AJhJzLXJc0JPQ/M32JPfEYyO7X73e+fY+voebT6cVDZgeNQQnoiO3JeF5h3rZuHSIECPcfWo+kEOVTGQbYfofYObMvyomHrLLVh+12so6l2UnavJMnptOumKq3oCueByulTAUi+9CIdEtJLo0K1HvE0/jADNCQV+YGzXmie7fmNAFOLNvOENzCnJRxjNE9lhwpqpN/ZDx1z53IVrcMXGm6NvPbNCOMpLP0p/vS+d0mRFWQ+Atm8EYNDQlcLBRcmJzPpdi7niHYG1oRQKHfdYerzzhl/ppOboWCfQXT9BF+nvZDMJIVnUBEXN2RRd7tLte0cW83y4SGtMWKbu9+YfARtAmlk2VgSkUA4TU77UgElW9HegQtAAcvlllIr/GbPWmKVGcv/zICAzrmmyvHbFZzU2kiJSXm+lvtordwdBeh7lHBCUr5JvGNmmaGgHwCzi1HSM2yUja8r/gUEh5pBVhLEt6yqbkAFxp/8G38JW/QgJmK8UQyWMOT9UvW7Qc2etx0cFDpFQugILHkS2QxQ+Meb5DQ+oR5JSNvtLfE9Oq0zq1m0rkB+YPbdJchfKmVYd1lP5fq1J23uSuVIMntVauuhdMoqKZ0ihHdZxG3Hn8iOhUkda/oWq6I4Lz9vvHf7BgAW0RhA6v+GEj++7zw/2UxnuQpvh/atshLDzIIQyb2c3OJ+XH9ewEi6t8EenUsdKAc8Ivv/tR24Ry6wzapbiJLe0L8/0GB2+EoLWeBtbAlAiukPUJk2gCN5fVuEUh1ihLD5Si9MusWqNgYYQPt03bHIBGbXXB0bVzaiQYPsOeTSpfKQvAzHRwDujmEbl2mHwPQ88Sla gejBK0kA QbEtUW2nwjqAjHr9N8ErRCTRtey/JoHmlQtun95qZpsm7Q0BkQglW66U/JwL0G3CqUl6mAAKXXok306WMVfLehBnxmbq83g+SY+YhXozlSe5S6HJ9ip7AZZVOZMekYjWBLrcW7vcYK2iutbFS/lvypKboQHC/kQf23j7Mc5tD/S6qcmGatEY+zMGvvLfQQ2VUerfoWFN6dC94sFobn66BgmrApeWIozwmDHTn2eu8/1PGgr/PlzVSlpiq0RPC64tft9b9G8+mt+zTKAVxk/OqaccPb0o9DyJvuyTMEUlFBcyQBAMwcbAIAjcxcMkIrXdwsNG0U/TdXCpvTt5MavEW0CaM5qykaLWuy9at1onamvUtp2McO1KfIJsPwiCC0yZPyf/mQT3cJvf8mEMD0sGg/NgwXTcUjIRxz2y98zGih4mga4gH9uPZhZ1zyruKtHWa/4wA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 32ffa5373540a8d1c06619f52d019c6cdc948bb4 commit: ebc4b2c1ac92fc0f8bf3f5a9c285a871d5084a6b [5690/11210] ext4: fix incorrect tid assumption in ext4_fc_mark_ineligible() config: loongarch-randconfig-r063-20240911 (https://download.01.org/0day-ci/archive/20240912/202409120149.GdjqoVYQ-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 14.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202409120149.GdjqoVYQ-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> fs/ext4/fast_commit.c:362:21-23: WARNING !A || A && B is equivalent to !A || B vim +362 fs/ext4/fast_commit.c 332 333 /* 334 * Mark file system as fast commit ineligible, and record latest 335 * ineligible transaction tid. This means until the recorded 336 * transaction, commit operation would result in a full jbd2 commit. 337 */ 338 void ext4_fc_mark_ineligible(struct super_block *sb, int reason, handle_t *handle) 339 { 340 struct ext4_sb_info *sbi = EXT4_SB(sb); 341 tid_t tid; 342 bool has_transaction = true; 343 bool is_ineligible; 344 345 if (ext4_fc_disabled(sb)) 346 return; 347 348 if (handle && !IS_ERR(handle)) 349 tid = handle->h_transaction->t_tid; 350 else { 351 read_lock(&sbi->s_journal->j_state_lock); 352 if (sbi->s_journal->j_running_transaction) 353 tid = sbi->s_journal->j_running_transaction->t_tid; 354 else 355 has_transaction = false; 356 read_unlock(&sbi->s_journal->j_state_lock); 357 } 358 spin_lock(&sbi->s_fc_lock); 359 is_ineligible = ext4_test_mount_flag(sb, EXT4_MF_FC_INELIGIBLE); 360 if (has_transaction && 361 (!is_ineligible || > 362 (is_ineligible && tid_gt(tid, sbi->s_fc_ineligible_tid)))) 363 sbi->s_fc_ineligible_tid = tid; 364 ext4_set_mount_flag(sb, EXT4_MF_FC_INELIGIBLE); 365 spin_unlock(&sbi->s_fc_lock); 366 WARN_ON(reason >= EXT4_FC_REASON_MAX); 367 sbi->s_fc_stats.fc_ineligible_reason_count[reason]++; 368 } 369 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki