From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9604EEE49B3 for ; Wed, 11 Sep 2024 14:11:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD995940040; Wed, 11 Sep 2024 10:11:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8A1F940021; Wed, 11 Sep 2024 10:11:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C514B940040; Wed, 11 Sep 2024 10:11:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A346A940021 for ; Wed, 11 Sep 2024 10:11:05 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1A26FC196E for ; Wed, 11 Sep 2024 14:11:05 +0000 (UTC) X-FDA: 82552644090.17.1DA26B3 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by imf07.hostedemail.com (Postfix) with ESMTP id A2A5C40025 for ; Wed, 11 Sep 2024 14:11:01 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Afx43FRT; spf=pass (imf07.hostedemail.com: domain of lkp@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726063810; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Xi1RrBJTlO5wuMwSL3xA0S4YBJPCOlOruJIqUpfbUGI=; b=yMmUB8l+wHWl8SZ+mu0g1I8GiE5StKV9ElqJEjGg1MuNnEReDREEGb8mEHi3WS8YnGOr0V 6KKIK3RauF3w0pty/uQyMzYVeq8qFwNVrO26zwG092wuyhLKZtiSz8Ewwo0TZcL3cRT2Qs KL1f7e3gf+JNloh3yThn1d8JA7Ee0YY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Afx43FRT; spf=pass (imf07.hostedemail.com: domain of lkp@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726063810; a=rsa-sha256; cv=none; b=WRC1GpEn/o7mzkPLB/mnsBwMjRfJTB7YxEL8KU4TDYKCZGc5zkqeKjB7OnW8FVU2ncyO/6 aWax5Pr2MGmH3PNKiqLU+SVg8RIsP0CHyZByOwWP59PRjAGqMT/prXHF0UHiiOGWpQqDvw iGApqXN1L6jiSj4COSxrXIXmUjbf8y8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726063862; x=1757599862; h=date:from:to:cc:subject:message-id:mime-version; bh=p5gmolZjzQBvwEBiiga93t2Pw/gLHekFerxyfDcc4/8=; b=Afx43FRTg7++lolaJSLZklpT1uwcpynM/KJPf9/aDONrVdVKO1Mnxuyc eyJ4gzfp2I08Ef4S5ok+GD5PGw6NPwkPNHjauaNyhsGxYMwYZiXs9vaPz ii06mFS8ZPpRGj/CIX1iQ6VFXnEm1TcSOaYz+kk+jy1oYr9QXOumlQi2y YvJLc+/RxImltowSFoMF5B7GDc11GhDJ8hz5/eP2KQpIlOHh060ztqFAy oOFqlHy/ym4L/4hzaLWPuaSxGABqtuw/OkkjeQFl29snjx4VwwBt60NfV GuL+K9lHDcGp6XzxSNDBR9XlGHPzx835nFinfaFZj2PIPBrOmUSAeZgbM w==; X-CSE-ConnectionGUID: FM1n9zj+RjC3icVO4rzNZA== X-CSE-MsgGUID: 2RGzyy2yQ9SlxeGycrOP4g== X-IronPort-AV: E=McAfee;i="6700,10204,11192"; a="36253975" X-IronPort-AV: E=Sophos;i="6.10,220,1719903600"; d="scan'208";a="36253975" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2024 07:10:58 -0700 X-CSE-ConnectionGUID: WaGUhO/UTQGO08nmGiok4A== X-CSE-MsgGUID: uZsAnaBxQbumAFfdKO9HHg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,220,1719903600"; d="scan'208";a="67001192" Received: from lkp-server01.sh.intel.com (HELO 53e96f405c61) ([10.239.97.150]) by fmviesa006.fm.intel.com with ESMTP; 11 Sep 2024 07:10:57 -0700 Received: from kbuild by 53e96f405c61 with local (Exim 4.96) (envelope-from ) id 1soO3a-0003gg-3D; Wed, 11 Sep 2024 14:10:54 +0000 Date: Wed, 11 Sep 2024 22:10:29 +0800 From: kernel test robot To: Kent Overstreet Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: [linux-next:master 10182/10862] fs/bcachefs/btree_cache.c:452:13-14: Unneeded semicolon Message-ID: <202409112245.V7Yx5g8S-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A2A5C40025 X-Stat-Signature: wzg5ie4hmm8d6w5wph4hu4spao74mu7m X-HE-Tag: 1726063861-438126 X-HE-Meta: U2FsdGVkX18uCPznxXzb4FdG88kjbO/K9eBNrpmXQX8V4dkgZpYz1UnYOWBHTIqnYrUJt9v/RcGhNini1y++iNK9XXhbUC5Fb0GDHxXly7MlR1LkUeqj3BO0uqOjhz80PB2bhJAYG3yDsF6NkRTsFTdsWQK/+PM2IPn9TYtIeHlSZoYuPF4AA9jsxJhSLSdr9r/tAjy+BNYywW7FUzKYfCCtn+8E2zZ9FWNhqJl6o6iFIA0jdMm4JzUI/XkAPH7FfjZn6LXmbp5x3c9HskbfGQVWvnw1uPn9enuzqIsKak5URXZmvQjH7+6U+8leZGFMEZuM3kVXUOZgDkn2CsxC2hwvQwR5YiLuqqj9CyWhiSk3epRqn5DiCdMd3NDw757BhQ+NnIlqePeODRDOokSQImi+neu6zEeUVT/97rVdA9l0cHjt/wWC5F7QXd/lxzHbggZvv4FVA1KSfGOvD+AV7VaERyM2NK3hPImrvvEAaQTMPyhLPdvaM/QOO0PXr9q3vAVChPyRSMdh0ABxGpbdscqk+ohN9FWdu2B9kZxGoqcBfIGayNfrt6V+Fl7lwo5jpKx+RUFrejTAwT5/Wl/2W1uaO+5qVggdWnKO6Vi8NmgABC4iyRY/o85IzWiaOwE6MvlcmU4v8B44M/OBG/y+jeWe6yOafs8C/9QyeaS/XTSLtcgM1T+ta45K5XcM4KKAEYuyOE7eVZU1yslQDfmMK01c6MFlnWco3FPp0GDUZJpI3yVDUasoTWEOIh4asGC2kzoK+wY6FzT7lKWlPc06MJJMDyGr4wU8vPFstqi621WjzVDiZ2lWyNeISCa0yOy3+wFtnlauzCIXCIYYi6GLeVkxpXB8YGFKJ5jowGlcBN85WAkuUAhRmIRLJm8rWQu9Uw8UiI/a2dJnfhluWDqFlzKjU/5Y4XVZ9fs9PEt+1JO5cn2C4+6tKqJyzF4Gc3NI/7SBpoDSt0t6h8mb0eZ BI8zA31v 1vuVb47AQbZ6anCKhBNkBwrJCJEuZASbvNeGj0R/E8BIt7NF9gxIYZ13bEv/JLD2LviOJSS16P6Yor55nrTpm8hGOD92C4qJQCBuo531M5TOUhblDk+udUU6yanwfMHsTc62olVPZnD9JXuUnsoqj9YTjeO3BbPl/BbGalE8ZGQ7GNnaYf/ZFcWztYmVizIrEB48Sjy7b8G57ICAEiSTSALSvS9m5G6Mrv4+pn8g4S1wPfk9Gj2sGmof3oKVEp00Bx7ejBLxeunmxY/17NMFSxC9V8LsCV3PF06OzhGFclgdJ6b5gty0xUmCbbsCj7SPX+jPTaVHiPn5pyNTC5LnFackq/H20GIGjIcG9uZlCZh+nh/x+UXpxPkprSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 32ffa5373540a8d1c06619f52d019c6cdc948bb4 commit: 4a4dd0714322bb7338902cd7efad725307ea0dee [10182/10862] bcachefs: Don't count "skipped access bit" as touched in btree cache scan config: loongarch-randconfig-r063-20240911 (https://download.01.org/0day-ci/archive/20240911/202409112245.V7Yx5g8S-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 14.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202409112245.V7Yx5g8S-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> fs/bcachefs/btree_cache.c:452:13-14: Unneeded semicolon vim +452 fs/bcachefs/btree_cache.c 391 392 static unsigned long bch2_btree_cache_scan(struct shrinker *shrink, 393 struct shrink_control *sc) 394 { 395 struct bch_fs *c = shrink->private_data; 396 struct btree_cache *bc = &c->btree_cache; 397 struct btree *b, *t; 398 unsigned long nr = sc->nr_to_scan; 399 unsigned long can_free = 0; 400 unsigned long freed = 0; 401 unsigned long touched = 0; 402 unsigned i, flags; 403 unsigned long ret = SHRINK_STOP; 404 bool trigger_writes = atomic_read(&bc->dirty) + nr >= 405 bc->used * 3 / 4; 406 407 if (bch2_btree_shrinker_disabled) 408 return SHRINK_STOP; 409 410 mutex_lock(&bc->lock); 411 flags = memalloc_nofs_save(); 412 413 /* 414 * It's _really_ critical that we don't free too many btree nodes - we 415 * have to always leave ourselves a reserve. The reserve is how we 416 * guarantee that allocating memory for a new btree node can always 417 * succeed, so that inserting keys into the btree can always succeed and 418 * IO can always make forward progress: 419 */ 420 can_free = btree_cache_can_free(bc); 421 nr = min_t(unsigned long, nr, can_free); 422 423 i = 0; 424 list_for_each_entry_safe(b, t, &bc->freeable, list) { 425 /* 426 * Leave a few nodes on the freeable list, so that a btree split 427 * won't have to hit the system allocator: 428 */ 429 if (++i <= 3) 430 continue; 431 432 touched++; 433 434 if (touched >= nr) 435 goto out; 436 437 if (!btree_node_reclaim(c, b, true)) { 438 btree_node_data_free(c, b); 439 six_unlock_write(&b->c.lock); 440 six_unlock_intent(&b->c.lock); 441 freed++; 442 bc->freed++; 443 } 444 } 445 restart: 446 list_for_each_entry_safe(b, t, &bc->live, list) { 447 touched++; 448 449 if (btree_node_accessed(b)) { 450 clear_btree_node_accessed(b); 451 bc->not_freed[BCH_BTREE_CACHE_NOT_FREED_access_bit]++; > 452 --touched;; 453 } else if (!btree_node_reclaim(c, b, true)) { 454 freed++; 455 btree_node_data_free(c, b); 456 bc->freed++; 457 458 bch2_btree_node_hash_remove(bc, b); 459 six_unlock_write(&b->c.lock); 460 six_unlock_intent(&b->c.lock); 461 462 if (freed == nr) 463 goto out_rotate; 464 } else if (trigger_writes && 465 btree_node_dirty(b) && 466 !btree_node_will_make_reachable(b) && 467 !btree_node_write_blocked(b) && 468 six_trylock_read(&b->c.lock)) { 469 list_move(&bc->live, &b->list); 470 mutex_unlock(&bc->lock); 471 __bch2_btree_node_write(c, b, BTREE_WRITE_cache_reclaim); 472 six_unlock_read(&b->c.lock); 473 if (touched >= nr) 474 goto out_nounlock; 475 mutex_lock(&bc->lock); 476 goto restart; 477 } 478 479 if (touched >= nr) 480 break; 481 } 482 out_rotate: 483 if (&t->list != &bc->live) 484 list_move_tail(&bc->live, &t->list); 485 out: 486 mutex_unlock(&bc->lock); 487 out_nounlock: 488 ret = freed; 489 memalloc_nofs_restore(flags); 490 trace_and_count(c, btree_cache_scan, sc->nr_to_scan, can_free, ret); 491 return ret; 492 } 493 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki