From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF099EE57D7 for ; Wed, 11 Sep 2024 22:23:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70E286B0088; Wed, 11 Sep 2024 18:23:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BE5D6B0089; Wed, 11 Sep 2024 18:23:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 585AD6B008A; Wed, 11 Sep 2024 18:23:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3A9F96B0088 for ; Wed, 11 Sep 2024 18:23:05 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B1A081A1344 for ; Wed, 11 Sep 2024 22:23:04 +0000 (UTC) X-FDA: 82553883888.09.40FEF10 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id E50FF40009 for ; Wed, 11 Sep 2024 22:23:02 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Ru1n3iJ/"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726093306; a=rsa-sha256; cv=none; b=lJSrj/IPwmebe9HAt1PxRYR1c7/bfiqGBDHpqAfNUvMIY2b+hMnmnZnkOup02m5RYBle++ 9en2rcXo8e39DsWq2Ujeink8Cr5UxxI2EXq90A9z8rzHH9uAacnB6SSF0ZhGmK6mEd9Bau 7CZ6pQOWuovR6kjCeYVJDISXBxDJZP4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Ru1n3iJ/"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726093306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5NfDitYrRm3afkh+Gbs4546GykfgFV2OWLIsACf/xJ4=; b=QN63/IOR+v1qWJEgzHSwj2NUnEbNSxvU4reKHcr9nZOkHH1VxmWGVvohy5/xRfOm0Dnbgy Ues0UK4XsyCLK85uYg5QmrJY6DAZkQbFkKKQt6vTjpiWb1A8JwauXdGii1x0nEz9yx3bhF ME1sqGucBkroZ+CpvA4/wamEIePZurY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 45DF15C06A4; Wed, 11 Sep 2024 22:22:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C602C4CEC0; Wed, 11 Sep 2024 22:23:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726093381; bh=CeTttMY+Q4kBmD++wQT3MC8a2EQVjkLZY1H2aiNffnI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ru1n3iJ/B8YJ1ZpgyY7IPBFRjhOFSewXm+3nGEPbUuOBmiMrGjYq2F/mpQA2TxToG fpljZNIoepfHYLq2EN5kI3d4T4LCCyjpNzyJOY5kgy5RoOygkrCa8mST66x1vNK/NP iHyqEoFEfqLFjM0kMM9B8ak0y9EAlthfn4+4qAzLeX+KoHAWlJLu+UNrJSVGirLU7E QQuTI4YAN6T9W1DmjiX/MtTNyjOothx/MqXh6vb1A7qmAUnIiclq/rvdg1RpskTB1X LByUYumU0YY6Wc7JI+n7ueaRFXSxbXtj1VIYc1U549v9P4WRf4X4tcwZQTKX2UZzXx 4hBeueanl4QCw== Date: Wed, 11 Sep 2024 15:23:00 -0700 From: Kees Cook To: Suren Baghdasaryan Cc: Vlastimil Babka , Kent Overstreet , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, "GONG, Ruiqi" , Jann Horn , Matteo Rizzo , jvoisin , Xiu Jianfeng , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 4/5] alloc_tag: Track fixed vs dynamic sized kmalloc calls Message-ID: <202409111518.9D90EE197@keescook> References: <20240809072532.work.266-kees@kernel.org> <20240809073309.2134488-4-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: E50FF40009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 53e8xw9h311eqn38s1w984wzcgdn6bhk X-HE-Tag: 1726093382-989470 X-HE-Meta: U2FsdGVkX18nr78lKW46yI7FPeje/IW1TGSAX2suFoDbd45nX7MRBlFlfxgARr8AZNr6uqSlPU2MO7RKlAt8N1H8A2CbIlpu7GVrb7K7+lXDVlUa30AN3y+18IW0a3gVur2bcOozNFcD4SYGeVuBkpDq7AXmPW0L6NOCT+CaSa06u3Z21T0gUqJyOcAkGbN3AiFAXpJGfY2AOBvcvv3GBxVcmBUhUFyK6VfAvZbknJsDx3YrTtY4AGZdlXDSTeb486+YfNTJt6YhiDvbRg4rRqR54fBQBXDTJBq4EusOTNQ9WWkdzQKBWUKTXJydg2UCA52BlogY3xC7qnPn8wr1g39y/p6ksYKHRbeg08KoAbudyDXQhrOTYAfrh4Xr2n+JopHYI5/HqZgAJbhK7XnA7c+hsT3V6SG1XGeErjQi43nrD0aLJLBN3eYyIUUWAWhEMi/SRl1SkSUKgGobUEAAoj+HowX4WltvqLSTC2/VYzbfAaEXSCKitDebllP/f/2RBvWV7+4RXC1XGPctbAizx92+cOjNaGjQp4waLazETUzdP1HsidGt0+ll44rcUTrEK1uN3Krykdrtnf2aZFoT8K5/cCcGqr3V+5wrmBNMLza+h4m0JXvIy2DxdI/C0D3KJ0zlsza4oEVRyf9ZBV19qNcN3gIU4D58ASBHqsdPc+LG5H4IY7AfBPc99J8cICQuRonC/uUcgMpDTnQcf5yhOVRZp+weYisvUGaewQRV1h9UmXTyqfxrcHa0tupk9TkgxSgU8ZP0+9l9DWkeiQWb0zkyBXlQnjD9ca+rifobV4R1PGZ2xGNN/vNMJIBjffyWPFoKmH4YSM9nMLrMo07B4bK6tHq0DI21Tr1RzdUM/Jpa6ocl1lh3OJwQfv26ZOI7TlMRv362HCuwNsBFgXhrAXMWzcs+AIgc3LiZbUOe/G8zPhh4KNarYl4332kaafDPTdTPrVu+GrHVVR+pozN ZWSf4QnU ZPpkldKszSI0z4hKzMnQ6siROkvJaSnLh//bdCX+z3K9733KHvhGcMIS7sZzcRn/uCrplaaXeeow0Cggwu6abpU7dW9vdJ7xFwuZMf7hvYQElwK9V6lQSSU+f+V/qjVlzY7jBlN7UZvZXKskE/HrzUgyOvdN2vH0DMqQbly2SoCma2Q40HEj8vrQEvsYvl7zEaH5h1ketvzxTsRZfLix892x5Ve5FaMaIs0GtzzsdbA5oVnV+2pmK9+6CjZeVo4DgOKXJLEM0kH6SqwHPtc9pERq0ZZ1K8BUyRsMl/MoEJCqi4eKErNY8YmwDIajY/AQldLEPzeWzA90cz6XZpdljrK68311bp93Gl14nzQjMWc7cbuxC1DN2V5xhiJ1Duk+yQV7U5o7Af8RMHYuq9pliYfvcKqC7dmDTP4/F4kiUQ6PM7jY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 09:00:37AM -0700, Suren Baghdasaryan wrote: > On Fri, Aug 9, 2024 at 12:33 AM Kees Cook wrote: > [...] > > -#define kmem_cache_alloc(...) alloc_hooks(kmem_cache_alloc_noprof(__VA_ARGS__)) > > +#define kmem_cache_alloc(...) alloc_hooks(kmem_cache_alloc_noprof(__VA_ARGS__)) > > nit: seems like an unnecessary churn. Whoops, yes. This was left over from an earlier pass and I failed to get the whitespace correctly restored. I will fix this this. > > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > > index 81e5f9a70f22..6d2cb72bf269 100644 > > --- a/lib/alloc_tag.c > > +++ b/lib/alloc_tag.c > > @@ -78,6 +78,14 @@ static void alloc_tag_to_text(struct seq_buf *out, struct codetag *ct) > > > > seq_buf_printf(out, "%12lli %8llu ", bytes, counter.calls); > > codetag_to_text(out, ct); > > +#ifdef CONFIG_SLAB_PER_SITE > > + seq_buf_putc(out, ' '); > > + seq_buf_printf(out, "size:%s(%zu) slab:%s", > > + tag->meta.sized == 0 ? "non-slab" : > > "non-slab" term sounds overly specific and we might extend this to > some other allocations as well in the future. I would suggest > "unknown" instead. Heh, yeah. I went back and forth on the name for this and went with non-slab because we do know what it isn't. It's not some kind of unexpected state. Maybe "untracked", or "unsized", though both seem inaccurate from certain perspectives. > > > + tag->meta.sized == SIZE_MAX ? "dynamic" : "fixed", > > + tag->meta.sized == SIZE_MAX ? 0 : tag->meta.sized, > > + tag->meta.cache ? "ready" : "unused"); > > I don't see "struct alloc_meta" having a "cache" member... Oops, yes, as you found this should have been associated with the next patch that adds "cache". > Since you are changing the format of this file, you want to also bump > up the file version inside print_allocinfo_header(). Okay, yeah. In that case I'll probably split the report into a separate patch after "cache" is added so there's only a single bump in allocinfo versioning. -- Kees Cook