From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 346EDEE57DB for ; Wed, 11 Sep 2024 22:18:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B02BE6B0083; Wed, 11 Sep 2024 18:18:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB2496B0085; Wed, 11 Sep 2024 18:18:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 979C76B0088; Wed, 11 Sep 2024 18:18:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7966F6B0083 for ; Wed, 11 Sep 2024 18:18:00 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0E6C41A0DD7 for ; Wed, 11 Sep 2024 22:18:00 +0000 (UTC) X-FDA: 82553871120.08.66946BC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 592D31C000E for ; Wed, 11 Sep 2024 22:17:58 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="aG/xfp1A"; spf=pass (imf18.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726092939; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gFwXqKqx2rMPuai6dNwNW0VH+rsSDHzzQm6YfA78VfI=; b=Se80una7LpYym+7fsq8w1kE+eC6nmmkRn+3YoqPAjef1LCIojL2ABGS/xnCVq7n0jKnkdV x7KJYb7QsaK4H1KTVQ4HfSk164NUrxTcmGU2KxvrjN6Sk9KJ/2zR05CgMOFjDOnACx1lvX d4XDRw+L0bldIIWZOt9KIfoko0QOacQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="aG/xfp1A"; spf=pass (imf18.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726092939; a=rsa-sha256; cv=none; b=PKUjnkJSxf/Kyes7fjNZrTKSkIVKYsrtcXL/L8C+ToLF6e5lvfbKFErZm/aHIYheOyLlR5 5UpV0ilCMTz9qWGaEB4dzmXfRj3CrMseluILi7mufrgWWVHexvDqovAixQnR+UoGG5rl2Y t8aOnNTZjW6v2vo/TtIOyXpD1IJQymc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B48F45C06DE; Wed, 11 Sep 2024 22:17:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF085C4CEC6; Wed, 11 Sep 2024 22:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726093077; bh=8hESPHedU+ENYGrgiTg2aQkKK1dO07lnpjlYWMsSgFY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aG/xfp1AsFxxDmMA21Vujsx3gz8BU65cYKDoFnLk8hluj+5HCFGjrxMuCw+Z6D5Yb Ar9ABnQnEjtJeJk9eC4nNpHOrjlLuQPoxnp/I+gyMuU9QSUy/3/9s5TqbW6gmkHRqq DgoM07a/lkJiEOR+K67MpXSaX10dyo+BbWUAdDX8dKdqCk5uMWDrKhC5tDkovC5Hwz FmHAMspWVWb/nLMkj/cxJmxC6fPJZ/8QJVBbxOomWn/hrrVytKWHbo1BQh5rjMcv9L TbjQeCBm2eBjdZcj45gIHmmvyqw6IOG6hA3Ev5C/nc1gzmXBuXmYRnIjQt2xL0tYX0 GEyZyen2H3vHA== Date: Wed, 11 Sep 2024 15:17:56 -0700 From: Kees Cook To: Suren Baghdasaryan Cc: Vlastimil Babka , Kent Overstreet , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, "GONG, Ruiqi" , Jann Horn , Matteo Rizzo , jvoisin , Xiu Jianfeng , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 2/5] codetag: Run module_load hooks for builtin codetags Message-ID: <202409111517.2461E9DC4@keescook> References: <20240809072532.work.266-kees@kernel.org> <20240809073309.2134488-2-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 592D31C000E X-Stat-Signature: 4h8icodm11cc6fso41qrh47ybjaen84e X-Rspam-User: X-HE-Tag: 1726093078-838199 X-HE-Meta: U2FsdGVkX1/pbpf5Dz+/FAqg62coJfvEV9KjvrHxaWuM415TncFji47ZZDeRewmbi7gtNpo7LgHaQtUgm8wmEV0mhvCzIm3TqGN9IhxrYQVFIJVIr7w71jfl2Pe/7TRLYnB0mTia0b18+WYkV59fQOoLTX26NfLKC4k1H8boPF0jPGKfhP1vHCxk4Md/vyBu+SzidlSoFucm3pYdlFaR8rngjY2obIp7erGdQ0KOOUNz6juVlBPbl9dWZB8Bbea8yFF9CkLHbKbrgQI7DgUcgUBtetm/ZW5CTA3n9OwSnXV6GTol2bBjwtabU7lsJ8HTacPjCIWpfwknlX80LX83GI/XHPh1IJm8gGcZzmbSpW1xgGSg/fgE+jbVlHu9mS2khGW/WjmITG/ckesLQ3EHZsSqOY5LLJ5QFq5DrpyrQkf+aK27Xe46i/V+EPKj1A7O/52FUAgHFS9M3BPg0Fg5YdAiPx+QcOb2/F2j3Y21hhEn52ljUBrdqsCWRX9Rv9vljeE8eHIuiaEGplP3GXs+D2/4PkXgvOL+Zz01tufdn5TN1vnG2NswdNZE6+5jBdYeVdncqUElLTtqSueIN4iBpRpCcowoIv0Wco4HPwoPkyf3JhG6UtHv9Ew7uutF8PIsSvph2gFtkV9P7cfcCiUzFGJ+FAkT9aC2SW7M+a7V/Was5/ZCiLtVGaJ7TxMEp+gL1wBOab0ZtNPVTmun3dooqN1e7IqF74hDyGY+rygkBbdJ4x1ZkCwB1Sw7CnIpWPO3P6X+/ZHE8uLFteIDFXtxwwBM05Du4UwTsfwu0APLsIaYNG4EepGs2Q1PZgd/KaFLJuGouAiDQ2EfKOt77bL5ejKtmj0DvWg5sDz2vlgFiL67Wr7UmTJpx+UdKzDCAIddOGTLvt0DUrOtPN+3X2ofm1UinUVwbvb+9HLPgCzAkVp54Sj5Ujmr0/hq4uKcVFDZFqT8+HknnKTGr/I/WCF T0sRAh+4 EKTgDDdzz1b5WDlL0aTtPjzp/X7zWgC7sRrEslgPLJXguD+Ih2b1uBTStvpZsozHMUzhLWhWeMxlGPn4mp2jGeNAb5HcqWRJBKs4B0lByU72VgRkeh2bOZdz3tXC22sHPYCpGV9HsIraUAGcNZBSt38+EoKmRc+ykZH9YFBzYR/mqnuF0xCzKLvjZb4uJU1jK0Sx+XU7DKvQEORC1LLWdfOsq8PtvPbky52jybIycOYrHOEjR8UHpJbODqdJJC2MhiA6jnofrlDf94+aU664tMPbj/zWuMtP2TN1e8QWXvSxFTGR19diGIKhqdDiDwzgvpymBATY1UEx4qSsPO9/RB5wEFapp7KvEGR6Ob4hTBNNngXVpkftcasvSDlQhdoWYvWPhaSvxsLXaWM/YoPrVdLoUgNE50BEazYDwX+RSHNrgiVRV6roZRiN7ddAAnaxRO4Tvm5Sw9nuZ9IM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 08:02:13AM -0700, Suren Baghdasaryan wrote: > On Fri, Aug 9, 2024 at 12:33 AM Kees Cook wrote: > > > > The module_load callback should still run for builtin codetags that > > define it, even in a non-modular kernel. (i.e. for the cmod->mod == NULL > > case). > > > > Signed-off-by: Kees Cook > > Hi Kees, > I finally got some time and started reviewing your patches. > Coincidentally I recently posted a fix for this issue at > https://lore.kernel.org/all/20240828231536.1770519-1-surenb@google.com/ > Your fix is missing a small part when codetag_module_init() is using > mod->name while struct module is undefined (CONFIG_MODULES=n) and you > should see this build error: > > In file included from ./include/linux/kernel.h:31, > from ./include/linux/cpumask.h:11, > from ./include/linux/smp.h:13, > from ./include/linux/lockdep.h:14, > from ./include/linux/radix-tree.h:14, > from ./include/linux/idr.h:15, > from lib/codetag.c:3: > lib/codetag.c: In function ‘codetag_module_init’: > CC drivers/acpi/acpica/extrace.o > lib/codetag.c:167:34: error: invalid use of undefined type ‘struct module’ > 167 | mod ? mod->name : "(built-in)"); > | ^~ Ah-ha! Excellent. Thanks; I will double-check that your version of this doesn't have any surprises for how I was using it here. I expect it'll be fine. -Kees -- Kees Cook